diff --git a/includes/entity.inc b/includes/entity.inc index 25f7584..dc43e73 100644 --- a/includes/entity.inc +++ b/includes/entity.inc @@ -360,9 +360,23 @@ class DrupalDefaultEntityController implements DrupalEntityControllerInterface { // This ensures the same behavior whether loading from memory or database. if ($conditions) { foreach ($entities as $entity) { - $entity_values = (array) $entity; - if (array_diff_assoc($conditions, $entity_values)) { - unset($entities[$entity->{$this->idKey}]); + // Iterate over all conditions and compare them to the entity + // properties. We cannot use array_diff_assoc() here since the + // conditions can be nested arrays, too. + foreach ($conditions as $property_name => $condition) { + if (is_array($condition)) { + // Multiple condition values for one property are treated as OR + // operation: only if the value is not at all in the condition array + // we remove the entity. + if (!in_array($entity->{$property_name}, $condition)) { + unset($entities[$entity->{$this->idKey}]); + continue 2; + } + } + elseif ($condition != $entity->{$property_name}) { + unset($entities[$entity->{$this->idKey}]); + continue 2; + } } } } diff --git a/modules/simpletest/simpletest.info b/modules/simpletest/simpletest.info index 5583c2f..7b139ba 100644 --- a/modules/simpletest/simpletest.info +++ b/modules/simpletest/simpletest.info @@ -15,6 +15,7 @@ files[] = tests/bootstrap.test files[] = tests/cache.test files[] = tests/common.test files[] = tests/database_test.test +files[] = tests/entity_crud.test files[] = tests/entity_crud_hook_test.test files[] = tests/entity_query.test files[] = tests/error.test diff --git a/modules/simpletest/tests/entity_crud.test b/modules/simpletest/tests/entity_crud.test new file mode 100644 index 0000000..04d2fad --- /dev/null +++ b/modules/simpletest/tests/entity_crud.test @@ -0,0 +1,45 @@ + 'Entity loading', + 'description' => 'Tests the entity_load() function.', + 'group' => 'Entity API', + ); + } + + /** + * Tests the functionality for loading entities matching certain conditions. + */ + public function testEntityLoadConditions() { + // Create a few nodes. One of them is given an edge-case title of "Array", + // because loading entities by an array of conditions is subject to PHP + // array-to-string conversion issues and we want to test those. + $node_1 = $this->drupalCreateNode(array('title' => 'Array')); + $node_2 = $this->drupalCreateNode(array('title' => 'Node 2')); + $node_3 = $this->drupalCreateNode(array('title' => 'Node 3')); + + // Check that the first node can be loaded by title. + $nodes_loaded = entity_load('node', FALSE, array('title' => 'Array')); + ksort($nodes_loaded); + $this->assertEqual(array_keys($nodes_loaded), array($node_1->nid)); + + // Check that the second and third nodes can be loaded by title using an + // array of conditions, and that the first node is not loaded from the + // cache along with them. + $nodes_loaded = entity_load('node', FALSE, array('title' => array('Node 2', 'Node 3'))); + ksort($nodes_loaded); + $this->assertEqual(array_keys($nodes_loaded), array($node_2->nid, $node_3->nid)); + } +} diff --git a/modules/taxonomy/taxonomy.test b/modules/taxonomy/taxonomy.test index 665f9ae..fdf354b 100644 --- a/modules/taxonomy/taxonomy.test +++ b/modules/taxonomy/taxonomy.test @@ -690,15 +690,20 @@ class TaxonomyTermTestCase extends TaxonomyWebTestCase { $term_objects[$key] = reset($term_objects[$key]); } + // Test editing the node. + $node = $this->drupalGetNodeByTitle($edit["title"]); + $this->drupalPost('node/' . $node->nid . '/edit', $edit, t('Save')); + foreach ($terms as $term) { + $this->assertText($term, 'The term was retained after edit and still appears on the node page.'); + } + // Delete term 1. $this->drupalPost('taxonomy/term/' . $term_objects['term1']->tid . '/edit', array(), t('Delete')); $this->drupalPost(NULL, NULL, t('Delete')); $term_names = array($term_objects['term2']->name, $term_objects['term3']->name); - // Get the node. - $node = $this->drupalGetNodeByTitle($edit["title"]); + // Get the node and verify that the terms that should be there still are. $this->drupalGet('node/' . $node->nid); - foreach ($term_names as $term_name) { $this->assertText($term_name, format_string('The term %name appears on the node page after one term %deleted was deleted', array('%name' => $term_name, '%deleted' => $term_objects['term1']->name))); }