WEBVTT 117 00:09:55.210 --> 00:09:59.720 Benji Fisher: welcome. This is the triple disability meeting for January thirteenth, 2,023, 118 00:10:00.000 --> 00:10:05.049 Benji Fisher: I'm Benji Fisher moderating and also here are Aaron Mchale, sharing this screen. 119 00:10:05.350 --> 00:10:10.230 Benji Fisher: and Ralph Caller and Simo Helston. So go ahead. Aaron. 120 00:10:10.680 --> 00:10:17.019 Aaron McHale: Thanks. So this i'm looking at is one that's been on there has popped onto our 121 00:10:17.040 --> 00:10:31.310 Aaron McHale: that little back for you. This is here, and i'm going to mention it because it's relevant to the met issue that we've been looking around reorganizing the block items. The administration menu. So they should. We're looking at is 122 00:10:31.710 --> 00:10:36.300 Aaron McHale: number 2, 3, 1, 7, 9, 8, one. 123 00:10:36.870 --> 00:10:43.790 Aaron McHale: and that is the block content. Add edit. Delete needs proper breadcrumbs. 124 00:10:43.930 --> 00:10:51.630 Aaron McHale: the idea is it to be fair. This is a problem that you see across like core this isn't just block, but it's 125 00:10:52.410 --> 00:10:57.650 Aaron McHale: this one, if they some examples that so that the you know, create 126 00:10:57.680 --> 00:11:04.770 Aaron McHale: creating, editing, deleting custom lots, and they don't use it. Have a proper outcome, and you can see the screenshot there. It's literally just 127 00:11:05.080 --> 00:11:06.910 Aaron McHale: home is the breadcrumb. 128 00:11:08.760 --> 00:11:18.530 Aaron McHale: Now there is not so much proposed resolution, and the issue summary but if we come down to that past the discussion. 129 00:11:18.750 --> 00:11:23.870 Aaron McHale: There's some additional screenshots. Yeah, there's a little bit inactivity. 130 00:11:24.100 --> 00:11:28.700 Aaron McHale: Yeah. So you can see, like, for instance, here with the 131 00:11:28.810 --> 00:11:40.630 Aaron McHale: the you block on to revision Ui, which was very recently committed. You can see that you get like you got the bread from it goes home, and then the block. Id number one. And then 132 00:11:40.970 --> 00:11:46.150 Aaron McHale: you obviously got the revision screen. We're in this case, so that arguably is even 133 00:11:46.200 --> 00:11:55.529 Aaron McHale: somebody's even less helpful that the bread from just as one and not to be honest, i'm not sure if that's because laurel and called the block one, or but I presume that's because that's the block Id 134 00:11:55.690 --> 00:11:56.320 Aaron McHale: And 135 00:11:56.780 --> 00:12:00.719 Aaron McHale: so I can. And I suggested an idea that 136 00:12:00.870 --> 00:12:02.849 Aaron McHale: for this which. 137 00:12:02.940 --> 00:12:10.930 Aaron McHale: because the the the idea that being discussed an issue was around. We could just introduce a bread from Builder and and force the breadcrum to be. 138 00:12:10.970 --> 00:12:13.279 Aaron McHale: you know, home content. 139 00:12:13.450 --> 00:12:16.120 Aaron McHale: lock and then the the 140 00:12:16.340 --> 00:12:25.000 Aaron McHale: you know. I guess maybe the block Id or or whatever. So you would see here. So instead of just being hold them in the block, Id it would have the, you know, admin content 141 00:12:25.030 --> 00:12:31.459 Aaron McHale: block paths, Assuming that we eventually get the moving possible or over its content that gets committed. 142 00:12:31.750 --> 00:12:46.729 Aaron McHale: And so we could do that. but we would. The urls wouldn't change, so I I suggest the idea. What if we change the URL here for blocks to be slash, admin, slash, content, such block, and then the block Id 143 00:12:47.050 --> 00:12:48.070 Aaron McHale: and that would 144 00:12:48.280 --> 00:12:50.659 Aaron McHale: achieve the same result. 145 00:12:50.770 --> 00:13:00.039 Aaron McHale: But it would mean that the URL that you see in the address bar is then also consistent with where you navigate to to access blocks. 146 00:13:00.810 --> 00:13:01.650 Aaron McHale: And 147 00:13:01.720 --> 00:13:04.350 Aaron McHale: the thing that's different here. 148 00:13:06.970 --> 00:13:08.360 Aaron McHale: oh, can you still hear me. 149 00:13:10.750 --> 00:13:19.250 Aaron McHale: Yes, yeah, okay. Sorry. I can tell the Mike indicators something. I Just the the final thing i'll say is the thing that's different about 150 00:13:19.400 --> 00:13:34.230 Aaron McHale: this is versus like, because you get the same. You technically get the same problem with users and the nodes. No, it's a lesser extent, because, like, if you put them in, you know. Usually you have a URL with that, anyway. and other things. But the difference here is with blocks. 151 00:13:34.690 --> 00:13:47.870 Aaron McHale: You're always going to be within the context of the Admin Ui. So you're not going to navigate from the front end of the site like you're not going to go from the homepage to like the block view page. The block edit, like blocks, are always meant to be put placed within 152 00:13:48.150 --> 00:13:55.359 Aaron McHale: another page. So I think in this case, changing the URL to be aligned with where 153 00:13:55.380 --> 00:14:02.129 Aaron McHale: the block the block listing is, makes a lot of sense in this case, and also has the side effect of then 154 00:14:02.170 --> 00:14:03.610 Aaron McHale: fixing the breadcrumb. 155 00:14:04.210 --> 00:14:11.770 Aaron McHale: So that was my proposal on this issue and of assistance, as I noted here, we're actively working on as a working on the 156 00:14:12.100 --> 00:14:22.059 Aaron McHale: the re-organizing the block items. Anyway, if I would, I want to bring this issue up and see if that makes sense as us to do as a so follow up to the myth is shore around that? 157 00:14:22.080 --> 00:14:29.230 Aaron McHale: so i'm going to stop and it happy to go over anything if I just said, or if anyone has any questions. if that may all make sense. 158 00:14:31.470 --> 00:14:33.910 Benji Fisher: yeah, I think it makes a lot of sense. 159 00:14:34.280 --> 00:14:41.960 Benji Fisher: I I at least don't have any questions about the context. Let's start there, Sima route. Do you have any questions about 160 00:14:42.170 --> 00:14:43.350 Benji Fisher: context? 161 00:14:43.470 --> 00:14:44.980 Benji Fisher: What the problem is? 162 00:14:48.290 --> 00:14:49.340 Ralf Koller: Go ahead. No. 163 00:14:51.000 --> 00:14:53.870 Simo Hellsten: yeah. The problem, I think, is clear. 164 00:14:55.550 --> 00:15:01.160 Benji Fisher: Okay, By the way, I'm pasting into the zoom chat a link to today's 165 00:15:01.350 --> 00:15:02.600 Benji Fisher: test site. 166 00:15:02.860 --> 00:15:06.189 Benji Fisher: which does have the most recent 10.1 167 00:15:06.630 --> 00:15:08.050 Aaron McHale: perfect 168 00:15:08.230 --> 00:15:11.200 Benji Fisher: and usual login the admin. Admin. 169 00:15:11.730 --> 00:15:18.930 Aaron McHale: That's great, because that's I did not on the site prepared for this so I can. Then, 170 00:15:19.140 --> 00:15:23.530 Aaron McHale: we can demonstrate actually, as well just quickly demonstrate this. 171 00:15:23.900 --> 00:15:30.910 Aaron McHale: So. And this is actually, in fact, the Block library is still under, like because it's structure, it's even more helpful because it's 172 00:15:31.220 --> 00:15:40.700 Aaron McHale: Yeah. And yeah, we're we're in the Bolt library. Oh, and it has lots of blocks that's really helpful, because in money. So I don't have to create a blog to show this. So if I click on a block 173 00:15:40.880 --> 00:15:51.189 Aaron McHale: you can see i'm just like taking straight to the block LED of Horn. But the breadcrum is just home. It's not even like, and also the URL is a you know, slash block 5. So 174 00:15:52.290 --> 00:15:55.150 Aaron McHale: you know, you click home, and you'll be taken back to home. Which is 175 00:15:55.380 --> 00:16:14.489 Aaron McHale: It's not really helpful. And then we can probably. Yeah. So we can see the the example, the provision here where the Id I guess that for some reason the breadcrum for block is socially just using the the block Id in the breadcrum, which again is probably like not really helpful, and that's potentially even a follow up issue to this one to be like. 176 00:16:14.650 --> 00:16:30.300 Aaron McHale: Can we make this, you know, because this is not consistent behavior? We never really in the breath, and we never show the Id of something, so we should probably also have it, so that the breadcrum shows the actual title of the block rather than the block. Id to be consistent with other places. 177 00:16:36.510 --> 00:16:41.630 Benji Fisher: Yeah. So I I guess as as a usability question. 178 00:16:42.410 --> 00:16:46.500 Benji Fisher: you know, we we are not concerned with how it's implemented. 179 00:16:46.590 --> 00:16:49.000 Benji Fisher: there there should be bread crumbs. 180 00:16:49.220 --> 00:16:52.869 Benji Fisher: and and maybe we should, you know. 181 00:16:53.400 --> 00:16:57.100 Benji Fisher: Think a little bit about exactly what the bread crumbs should be. 182 00:16:57.350 --> 00:17:01.249 Benji Fisher: and think about it in the context of the other ongoing issues. 183 00:17:01.790 --> 00:17:03.149 Aaron McHale: right 184 00:17:03.430 --> 00:17:06.870 Benji Fisher: as as an implementation issue. 185 00:17:07.500 --> 00:17:08.450 Benji Fisher: I 186 00:17:08.760 --> 00:17:16.680 Benji Fisher: You know I I always recommend when when site building that that people pay attention to the Urls, and 187 00:17:17.420 --> 00:17:30.470 Benji Fisher: you know, instead of doing the work of creating custom, bread crumbs, just make sure that your URL is not your structure, your your your your site, navigation, so that the breadcrumbs take care of themselves. 188 00:17:32.780 --> 00:17:37.950 Benji Fisher: But there, there's there's also another point. Could Could you go to the 189 00:17:37.990 --> 00:17:46.060 Benji Fisher: It is issue Page: yeah, over here. And yeah, and there's already a related link to 190 00:17:46.530 --> 00:17:48.110 Benji Fisher: The issue for moving 191 00:17:48.400 --> 00:17:50.619 Benji Fisher: block, these 2. 192 00:17:51.720 --> 00:17:52.550 Aaron McHale: Yeah. 193 00:17:54.930 --> 00:17:56.150 Benji Fisher: So 194 00:17:56.320 --> 00:18:03.219 Benji Fisher: the the latest development there is that we've gotten some attention from the release managers. 195 00:18:05.340 --> 00:18:06.330 and 196 00:18:10.180 --> 00:18:16.070 Benji Fisher: and I guess for the sake of the recording this will be issue 2, 8, 6, 2, 5, 6, 4, 197 00:18:16.160 --> 00:18:19.099 Benji Fisher: move, custom, block library content. 198 00:18:20.070 --> 00:18:22.310 Aaron McHale: which is still loading. 199 00:18:23.970 --> 00:18:28.650 Benji Fisher: Yeah, you're saying it's very 200 00:18:28.720 --> 00:18:32.830 Aaron McHale: Yeah, it's such a big issue, and I don't know my computer is doing other stuff. So 201 00:18:32.890 --> 00:18:33.870 Aaron McHale: I don't know. 202 00:18:39.330 --> 00:18:41.240 Benji Fisher: So. 203 00:18:41.430 --> 00:18:43.180 Benji Fisher: So so yeah, the the 204 00:18:44.290 --> 00:18:45.340 Benji Fisher: they they 205 00:18:45.620 --> 00:18:46.460 Benji Fisher: did 206 00:18:46.650 --> 00:18:49.890 Benji Fisher: object to the disruptive nature. 207 00:18:50.080 --> 00:18:54.180 Benji Fisher: they point out that not only might people have 208 00:18:54.340 --> 00:18:56.670 Benji Fisher: links who knows where 209 00:18:56.790 --> 00:19:05.709 Benji Fisher: saves an email saves in their browser. Tabs what? Not but also the shortcut 210 00:19:06.580 --> 00:19:07.650 Benji Fisher: module 211 00:19:08.330 --> 00:19:12.520 Benji Fisher: does not store internal routes it stories actual paths 212 00:19:12.800 --> 00:19:15.660 Benji Fisher: which which I didn't realize. 213 00:19:17.310 --> 00:19:18.720 Benji Fisher: So 214 00:19:19.570 --> 00:19:25.930 Benji Fisher: So they've decided that for for all of these issues we're we're going to have to do something 215 00:19:26.410 --> 00:19:28.790 Benji Fisher: to 216 00:19:29.330 --> 00:19:31.000 Benji Fisher: to to help people 217 00:19:31.230 --> 00:19:34.580 Benji Fisher: use the existing routes, or the existing. 218 00:19:34.650 --> 00:19:36.150 Benji Fisher: because he 219 00:19:38.440 --> 00:19:41.150 Benji Fisher: and the the latest recommendation 220 00:19:41.300 --> 00:19:42.810 Benji Fisher: it is 221 00:19:42.860 --> 00:19:43.750 Benji Fisher: to 222 00:19:44.160 --> 00:19:45.939 Benji Fisher: postpone this issue. 223 00:19:46.550 --> 00:19:53.679 Benji Fisher: create a separate issue to handle the the one that's already been fixed. 224 00:19:54.040 --> 00:19:58.539 Benji Fisher: yeah, 131 is is the latest comment. What i'm talking about now? 225 00:20:02.490 --> 00:20:08.989 Benji Fisher: and and that. But anyway, what once we do that, you know, once we have 226 00:20:09.490 --> 00:20:13.799 Benji Fisher: sort of a strategy for creating a redirect. 227 00:20:17.260 --> 00:20:20.090 Benji Fisher: then there should be less. 228 00:20:20.170 --> 00:20:20.950 Benji Fisher: Yeah, good 229 00:20:21.610 --> 00:20:27.759 Benji Fisher: it. It should be easier to make further changes in the URL structure. 230 00:20:28.110 --> 00:20:28.830 Aaron McHale: Yep. 231 00:20:29.230 --> 00:20:37.699 Benji Fisher: so I haven't had a chance to it since that comments posted yesterday. but I I I plan to 232 00:20:37.810 --> 00:20:42.899 Benji Fisher: postponed this issue, create the the 233 00:20:43.170 --> 00:20:44.540 Benji Fisher: suggests here 234 00:20:44.930 --> 00:20:46.840 Benji Fisher: and start working on it. 235 00:20:47.290 --> 00:20:52.689 Benji Fisher: and and once that's done, I think it should be fairly easy 236 00:20:52.880 --> 00:20:55.620 Benji Fisher: to change the path for 237 00:20:56.030 --> 00:20:58.440 Benji Fisher: the block added forms as well. 238 00:21:03.680 --> 00:21:07.399 Aaron McHale: Yeah. So I think that it makes sense. And 239 00:21:09.010 --> 00:21:16.869 Aaron McHale: I guess it it would be this. Yeah, it would be the same thing. So I I guess if we're if we think that obviously changing 240 00:21:17.060 --> 00:21:20.429 Aaron McHale: changing the path is is a good a good approach. 241 00:21:22.970 --> 00:21:24.469 Aaron McHale: i'll try to where it was. 242 00:21:26.030 --> 00:21:27.630 Aaron McHale: Yeah, we can 243 00:21:27.700 --> 00:21:29.800 Aaron McHale: so I can suggest that. 244 00:21:30.050 --> 00:21:31.860 Aaron McHale: Well, I can recommend that on here. 245 00:21:32.080 --> 00:21:36.720 Aaron McHale: I guess. Do we want to block this issue on the wall 246 00:21:36.820 --> 00:21:38.429 Aaron McHale: you're going to create? 247 00:21:38.730 --> 00:21:41.339 Aaron McHale: I can see it's already blocked on 248 00:21:42.770 --> 00:21:44.130 Aaron McHale: something. 249 00:21:45.150 --> 00:21:57.269 Aaron McHale: Oh, the custom block library. Yeah, so that will. This will happen after the custom. Walt library issue gets done. so I guess it's a case, I guess, because that's going to be on the issue of that. 250 00:21:57.620 --> 00:22:01.049 Aaron McHale: Yeah, okay, sorry. This one. So 251 00:22:01.200 --> 00:22:05.120 Aaron McHale: i'll just recommend that on the issue that we've talked about it, and we 252 00:22:05.270 --> 00:22:05.850 Aaron McHale: we 253 00:22:06.180 --> 00:22:09.609 Aaron McHale: recommend just we go ahead and update the URL as well. 254 00:22:09.930 --> 00:22:11.320 Aaron McHale: And obviously that 255 00:22:12.370 --> 00:22:19.729 Aaron McHale: certainly simplifies the issue, because I know from trying to implement break from builders myself. There. 256 00:22:20.160 --> 00:22:23.530 Aaron McHale: there, there is sometimes a tricky thing to get right. So 257 00:22:23.580 --> 00:22:27.289 Aaron McHale: yeah, the the the simpler we can make the implementation the better. 258 00:22:28.190 --> 00:22:36.109 Aaron McHale: And I don't think there was anything. Let me just double check my comment. I don't think there was anything else. 259 00:22:36.450 --> 00:22:37.469 Aaron McHale: Go ahead, Ralph. 260 00:22:40.700 --> 00:22:51.189 Ralf Koller: It's I just remembered. we've talked it's already a while ago in early 2,022 261 00:22:51.400 --> 00:22:55.209 Ralf Koller: about the h one issue in a threat. Aaron and me 262 00:22:55.230 --> 00:22:56.470 Ralf Koller: and 263 00:22:56.550 --> 00:22:57.490 Ralf Koller: there I 264 00:22:58.320 --> 00:22:59.400 Ralf Koller: mate 265 00:22:59.750 --> 00:23:07.399 Ralf Koller: a point about breadcrumbs which applies here as well. It's out of the scope for this issue, but in general it still applies 266 00:23:07.620 --> 00:23:09.729 Ralf Koller: my my link it 267 00:23:09.780 --> 00:23:12.120 Ralf Koller: the direct link to the comment. 268 00:23:13.850 --> 00:23:15.469 Ralf Koller: Neil's Norman group 269 00:23:15.510 --> 00:23:20.209 Ralf Koller: hosted 11 design guidelines for desktop and mobile. 270 00:23:20.910 --> 00:23:24.740 Ralf Koller: and a few of the points listed there. Apply 271 00:23:25.070 --> 00:23:29.270 Ralf Koller: also to triple. And yeah, so the issue as well. 272 00:23:31.950 --> 00:23:39.639 Ralf Koller: for example, including the current page as the last item in the breadcrumbs trail. It applies, for example, for 273 00:23:40.130 --> 00:23:41.689 Ralf Koller: the node edit page 274 00:23:41.800 --> 00:23:46.030 Ralf Koller: as well as in that case for blocks. 275 00:23:46.880 --> 00:23:48.870 Ralf Koller: but in other 276 00:23:49.570 --> 00:23:54.209 Ralf Koller: context of the triple admin interface it. Isn't 277 00:23:54.240 --> 00:23:57.699 Ralf Koller: used in the program trail, so it's inconsistent. 278 00:23:57.760 --> 00:24:04.580 Ralf Koller: and then a breakcom trail. The breadcrum corresponding to the current page should not be a link 279 00:24:06.640 --> 00:24:07.380 Ralf Koller: which 280 00:24:07.720 --> 00:24:17.250 Ralf Koller: is in the triple case and breadcrumbs that should start with a link to the homepage. You currently have a home button in the trooper. so 281 00:24:17.390 --> 00:24:22.380 Ralf Koller: you have it twice, and it should be only once, and I agree as well in that case. 282 00:24:22.400 --> 00:24:25.669 Ralf Koller: because you have in the platform the home button leading to the 283 00:24:26.330 --> 00:24:29.590 Ralf Koller: homepage of the front end instead of the 284 00:24:30.070 --> 00:24:31.960 Ralf Koller: home of the admin interface. 285 00:24:32.660 --> 00:24:34.399 Ralf Koller: And that's also 286 00:24:35.350 --> 00:24:36.459 Ralf Koller: sub optimal 287 00:24:36.780 --> 00:24:39.359 Ralf Koller: and the last one is 288 00:24:39.860 --> 00:24:44.910 Ralf Koller: also, if you have a long, upright crum don't use programs that wrap to multiple lines. 289 00:24:45.500 --> 00:24:47.130 Ralf Koller: There's already an issue 290 00:24:47.500 --> 00:24:49.740 Ralf Koller: I've listed in the slack comment. 291 00:24:54.720 --> 00:24:57.690 Ralf Koller: but I thought the Redram, and 292 00:24:57.930 --> 00:24:59.959 Ralf Koller: how they are treated in triple. 293 00:25:00.700 --> 00:25:02.479 Ralf Koller: My people have an issue as well. 294 00:25:03.340 --> 00:25:04.150 Aaron McHale: Yeah. 295 00:25:08.160 --> 00:25:13.480 Aaron McHale: yeah, this is a useful resource, I think, and and certainly that would be worth 296 00:25:13.690 --> 00:25:17.249 Aaron McHale: looking at as part of a pull up issue. Because there's some general. 297 00:25:17.480 --> 00:25:18.160 Aaron McHale: you know. 298 00:25:18.350 --> 00:25:23.549 Ralf Koller: recommendations here, and and a few programs. Sorry. Go ahead. 299 00:25:23.980 --> 00:25:30.820 Aaron McHale: I was gonna say some like this issue is slightly easier than the product problem that's being in my mind about bread comes, which is like. 300 00:25:31.440 --> 00:25:33.269 Aaron McHale: If you go to a 301 00:25:34.210 --> 00:25:36.620 Aaron McHale: like, if you go to, you know the 302 00:25:37.370 --> 00:25:38.589 Aaron McHale: you use a profile 303 00:25:39.380 --> 00:25:41.339 Aaron McHale: right? and you go to edit it. 304 00:25:42.140 --> 00:25:42.850 Aaron McHale: I mean 305 00:25:43.940 --> 00:25:48.899 Aaron McHale: that itself is a bit annoying. But like I don't even did the break from just disappear? 306 00:25:50.250 --> 00:25:55.720 Aaron McHale: I i'm not there. That's weird. Sometimes you didn't under that 307 00:25:56.010 --> 00:25:57.590 Simo Hellsten: menu. 308 00:25:58.340 --> 00:26:00.009 Aaron McHale: Oh, thank you. 309 00:26:00.230 --> 00:26:15.660 Aaron McHale: That's okay. Fun. Bug: but in the case of like user. Like, the breadcrum kind of makes sense. If You're the user i'm open. But it makes a lot more. But my sense is, you go to people and you're administering a user and you click on it, and then the breadcrum. 310 00:26:16.560 --> 00:26:17.260 or, to 311 00:26:17.490 --> 00:26:25.390 Aaron McHale: illustrate that slightly Better like, go to edit against the user the break room Doesn't: Reflect the trail I was on which is one of the recommendations of 312 00:26:25.600 --> 00:26:29.610 Aaron McHale: I guess you could say an article and one of the solutions that would be like 313 00:26:29.720 --> 00:26:40.549 Aaron McHale: this is a much bigger thing, but like is to potentially have, like a add like administrative path to edit users and then, like the user's own profile, it would be a separate 314 00:26:40.660 --> 00:26:41.930 Aaron McHale: us. 315 00:26:42.070 --> 00:26:45.689 Aaron McHale: And and you can argue the same thing for other agency sites. 316 00:26:47.130 --> 00:26:49.130 Ralf Koller: but that's a greater issue. 317 00:26:49.190 --> 00:26:51.819 Ralf Koller: But if you go in, for example, into configuration. 318 00:26:53.150 --> 00:26:59.419 Ralf Koller: And then into you don't have admin, too. But there, 319 00:26:59.640 --> 00:27:01.760 Ralf Koller: yeah, Basic side settings, for example. 320 00:27:04.950 --> 00:27:05.770 Ralf Koller: Then 321 00:27:06.090 --> 00:27:10.460 Ralf Koller: the last item in the breadcrumbs system and not basic size settings. 322 00:27:10.660 --> 00:27:16.089 Ralf Koller: for example, that's in and in in contrast go to content. And on a node, edit page 323 00:27:22.000 --> 00:27:23.290 Ralf Koller: and some roll up. 324 00:27:25.510 --> 00:27:26.260 Aaron McHale: Oh. 325 00:27:26.820 --> 00:27:27.570 Aaron McHale: older 326 00:27:32.290 --> 00:27:35.489 Benji Fisher: you you can just at the address and remove the Es 327 00:27:35.670 --> 00:27:36.550 Benji Fisher: from the path. 328 00:27:37.940 --> 00:27:40.679 Aaron McHale: Yeah, let's just be okay again. 329 00:27:42.140 --> 00:27:43.319 Aaron McHale: But how do I? 330 00:27:43.910 --> 00:27:44.930 Aaron McHale: Oh, No. 331 00:27:48.220 --> 00:27:51.689 Benji Fisher: Again the breadcrumbs Looks like it's in under the toolbar. 332 00:27:51.860 --> 00:27:53.370 Aaron McHale: Yeah, so they 333 00:27:54.720 --> 00:27:56.509 Aaron McHale: No, i'm trying to like, Get it. 334 00:27:56.930 --> 00:27:58.900 Aaron McHale: How do I get the till bar to disappear 335 00:27:59.160 --> 00:28:01.830 Benji Fisher: you. You click on the 336 00:28:02.220 --> 00:28:06.109 Aaron McHale: the way I find it. Kind of 337 00:28:06.800 --> 00:28:07.750 Aaron McHale: Oh. 338 00:28:07.980 --> 00:28:10.180 Aaron McHale: okay, sorry, Ralph. Continue 339 00:28:10.380 --> 00:28:16.920 Ralf Koller: no worries. But there, you see the current page is the last item in that case, and it is a link. 340 00:28:17.250 --> 00:28:18.040 Ralf Koller: But the 341 00:28:18.140 --> 00:28:22.099 Ralf Koller: the more consistent and more clear pattern would be 342 00:28:22.990 --> 00:28:24.389 Ralf Koller: to add the current. 343 00:28:24.450 --> 00:28:28.150 Ralf Koller: the current page as the last link, but not as a as a link. 344 00:28:28.600 --> 00:28:30.350 Ralf Koller: Yeah, is it? 345 00:28:30.400 --> 00:28:32.209 Ralf Koller: And in that case 346 00:28:34.080 --> 00:28:37.460 Ralf Koller: you get back to the to the added patch if you click it. 347 00:28:37.860 --> 00:28:44.209 Aaron McHale: Yeah, I guess in this case you've got this links to the viewp. So you would have like the breadcrumbs. Then. 348 00:28:44.510 --> 00:28:45.980 Aaron McHale: Yeah, 349 00:28:46.720 --> 00:29:00.350 Aaron McHale: But that is an example of the thing I mentioned. Where, like the in the case of block, like we should probably be using this pattern of like we don't use the node Id and the breadcrumbs right? So it's probably using the name of the block rather than the bulk Id I would. 350 00:29:00.570 --> 00:29:02.420 Aaron McHale: I would guess. 351 00:29:02.810 --> 00:29:03.980 Aaron McHale: Well, sir, of it 352 00:29:05.320 --> 00:29:07.650 Aaron McHale: different in some use cases so 353 00:29:11.160 --> 00:29:17.129 Benji Fisher: right? And I noticed that on the user edit page as well, it had the username rather than the numeric. Id 354 00:29:17.790 --> 00:29:18.610 Aaron McHale: right 355 00:29:19.170 --> 00:29:23.100 Benji Fisher: You had your hand up for a while. Is there something you wanted to add. 356 00:29:23.210 --> 00:29:34.450 Simo Hellsten: Yeah, I already. wrote it to the chat. That also when you're editing texting tax on me. Taxonomy is you? The bread Gram goes to 357 00:29:34.520 --> 00:29:37.420 Simo Hellsten: like admin structure 358 00:29:37.940 --> 00:29:39.079 Simo Hellsten: Texan on me. 359 00:29:40.070 --> 00:29:41.490 Simo Hellsten: but when you 360 00:29:41.710 --> 00:29:44.589 Simo Hellsten: but with with, when you start editing terms 361 00:29:45.090 --> 00:29:48.090 Simo Hellsten: then you go back to home 362 00:29:48.690 --> 00:29:51.349 Simo Hellsten: and to him texting on me 363 00:29:51.420 --> 00:29:55.569 Simo Hellsten: a a note, a home, and a term name 364 00:29:55.700 --> 00:29:56.770 Simo Hellsten: Red Crump. 365 00:29:57.820 --> 00:30:02.259 Aaron McHale: The the tax on the taxonomy background is broken in all other ways. So 366 00:30:02.480 --> 00:30:06.010 Benji Fisher: it goes to the list. And and now I edit one of the actual terms. 367 00:30:06.700 --> 00:30:10.180 Aaron McHale: Yeah. 368 00:30:10.460 --> 00:30:13.319 Simo Hellsten: Now it's all already also hidden there. But 369 00:30:16.420 --> 00:30:17.609 Simo Hellsten: so that 370 00:30:18.000 --> 00:30:20.680 Aaron McHale: and that's like example of a case where 371 00:30:20.990 --> 00:30:22.950 Aaron McHale: having 372 00:30:23.820 --> 00:30:26.300 Aaron McHale: I guess, like what would you call that like an admin 373 00:30:26.850 --> 00:30:30.270 Aaron McHale: admin roots and like front-facing routes, might be 374 00:30:30.290 --> 00:30:32.729 Aaron McHale: also helpful, because that would help with 375 00:30:33.890 --> 00:30:38.379 Aaron McHale: like, because the URL is like taxonomy slash term session 29, because 376 00:30:38.450 --> 00:30:39.910 Aaron McHale: you might be 377 00:30:42.670 --> 00:30:46.950 Aaron McHale: You might be using this on the front end like you're viewing it. But 378 00:30:47.040 --> 00:30:57.960 Aaron McHale: we might also have, like an admin we could include. You have, like an admin such structures like tax on research time. Whatever path that then preserves the breadcrum for the admin side of things. 379 00:30:59.990 --> 00:31:00.630 Ralf Koller: Yep. 380 00:31:02.290 --> 00:31:03.770 Aaron McHale: Well, 381 00:31:03.950 --> 00:31:06.300 Benji Fisher: And and 382 00:31:06.390 --> 00:31:10.990 Simo Hellsten: at least this one has the Id in the URL. But you see the name 383 00:31:11.940 --> 00:31:15.640 Aaron McHale: in bread. 384 00:31:16.030 --> 00:31:22.289 Aaron McHale: and this is a thing that's the theme where, like you saw this on the user page as well, and on on the here we've got the 385 00:31:22.350 --> 00:31:27.429 Aaron McHale: and not as a link. We've got the name of the page in the breadcrum. But 386 00:31:27.880 --> 00:31:29.639 Aaron McHale: well in the 387 00:31:29.880 --> 00:31:45.239 Aaron McHale: in, in your, in the admin theme. I'm. I'm. Get sick of these programs in the admin theme. We we don't do that so like. I wonder if that's actually a a theme specific implementation of something they've done in in Umami to make bread from show that the 388 00:31:46.050 --> 00:31:47.460 Aaron McHale: the page cycle? 389 00:31:54.120 --> 00:31:55.439 Benji Fisher: Hmm. I don't know 390 00:31:57.600 --> 00:32:07.960 Aaron McHale: so mindful we're approaching half way through the meeting, and I also feels like we've reached the natural point in discussion to conclude: 391 00:32:08.980 --> 00:32:11.569 Aaron McHale: and I anyone has any final thoughts on this. 392 00:32:15.200 --> 00:32:24.379 Benji Fisher: I I I have a couple of thoughts and and first of all, what once we're finished with with block content, and we've 393 00:32:27.100 --> 00:32:31.259 Benji Fisher: and and and we sort of understand how to make the changes we're discussing. 394 00:32:31.620 --> 00:32:34.410 Benji Fisher: That will make it much easier to 395 00:32:34.770 --> 00:32:36.980 Benji Fisher: look at other portions of the site. 396 00:32:37.420 --> 00:32:40.940 Benji Fisher: like, for example, taxonomy. maybe 397 00:32:41.080 --> 00:32:42.330 Benji Fisher: the 398 00:32:42.440 --> 00:32:49.070 Benji Fisher: the different vocabulary should be under the structure menu, but the terms should be under content. 399 00:32:49.420 --> 00:32:54.020 Benji Fisher: that working system it it's certainly worth worth the discussion. 400 00:32:57.490 --> 00:33:05.780 Benji Fisher: And and the the other thing is that it. Maybe we should go back to to the original issue, and and come up with 401 00:33:06.200 --> 00:33:10.540 Benji Fisher: sort of a specific recommendation of what the breadcrumbs should be. 402 00:33:12.030 --> 00:33:14.569 Benji Fisher: unless that's already been discussed here. 403 00:33:16.840 --> 00:33:18.449 Aaron McHale: I I think the 404 00:33:18.760 --> 00:33:21.269 Aaron McHale: I guess it would just be based on 405 00:33:21.490 --> 00:33:25.000 Aaron McHale: let me see. I think it was. The idea was it would just be based on 406 00:33:25.030 --> 00:33:26.390 Aaron McHale: but 407 00:33:26.440 --> 00:33:28.709 Aaron McHale: passed to. 408 00:33:29.670 --> 00:33:32.720 Aaron McHale: Was there one on the issue? Somebody hold up. 409 00:33:33.760 --> 00:33:35.270 Aaron McHale: yeah. It was like. 410 00:33:35.670 --> 00:33:48.089 Aaron McHale: So the proposal a solution. But Erica, she point to custom vault library, which again, obviously bear in mind that this issue is basically postponed on the one moving into content. So I think everybody seems to be okay with that being 411 00:33:50.260 --> 00:33:53.390 Aaron McHale: in that. In that case it would be, you know, admin content 412 00:33:53.780 --> 00:33:55.549 Aaron McHale: block library 413 00:33:55.640 --> 00:33:58.959 Aaron McHale: blocks, whatever that ends up being, and then the 414 00:33:59.200 --> 00:34:03.989 Aaron McHale: the the the name of the block. The idea of blocks would be in the breakfast. 415 00:34:05.310 --> 00:34:07.279 Aaron McHale: because that would be what we would. Then. 416 00:34:07.720 --> 00:34:17.849 Aaron McHale: assuming we we that's what we agree then, that would logically follow that we're recommending. Will the URL should then be like slash, admin slash, content, sess blocks, and then the block. Id 417 00:34:22.239 --> 00:34:30.090 Benji Fisher: right. So if you do make the path that that will affect the bread crumbs will have home, and then we will have what we have Admin: naturally. 418 00:34:30.489 --> 00:34:39.329 Aaron McHale: Yeah. let's go to content. I think we would. So take media, for instance. So yeah, it would go at home admin content 419 00:34:39.460 --> 00:34:40.439 Aaron McHale: Media. 420 00:34:40.610 --> 00:34:45.649 Aaron McHale: Well, yeah, home admin content blocks, and then the you know the ball height 421 00:34:48.100 --> 00:34:49.219 right? But 422 00:34:49.659 --> 00:34:55.189 Ralf Koller: but wouldn't it be more consistent to use the title of the block instead in the block. 423 00:34:56.020 --> 00:35:06.059 Aaron McHale: yes, I think we should open a follow up issue to deal with, with, make using the block title rather than the Id, because that is definitely something we identified as an inconsistency. 424 00:35:12.900 --> 00:35:15.869 Benji Fisher: I i'd be inclined to do it as part of the same issue. But 425 00:35:18.800 --> 00:35:21.790 Benji Fisher: who whoever actually works on it can can decide. 426 00:35:22.240 --> 00:35:23.620 Aaron McHale: Yeah, I 427 00:35:24.170 --> 00:35:30.660 Aaron McHale: I guess it for it, because because if we're recommending that we're actually changing the path. This issue becomes. The implementation of this issue is 428 00:35:30.770 --> 00:35:37.520 Aaron McHale: not about making a breadcrum builder and changes the better, but actually just implementing the changing of the past, which 429 00:35:37.600 --> 00:35:42.709 Aaron McHale: by consequence changes the background. So we to scope, while we probably would 430 00:35:42.860 --> 00:35:48.690 Aaron McHale: what that to be its own issue, because it's dedicated to changing how the breadcrum is 431 00:35:49.360 --> 00:35:50.319 Aaron McHale: to slate. 432 00:35:53.090 --> 00:35:55.379 Aaron McHale: which I don't know actually if it would. 433 00:35:55.910 --> 00:35:58.470 Aaron McHale: Now it is a thumbs up to that 434 00:35:59.120 --> 00:36:00.410 Benji Fisher: and I 435 00:36:00.800 --> 00:36:07.439 Benji Fisher: I I I've been advocating on on the the other block issues that as we change paths we also 436 00:36:07.510 --> 00:36:09.759 Benji Fisher: change page titles. 437 00:36:12.860 --> 00:36:16.390 Benji Fisher: maybe that's not not exactly the same thing. 438 00:36:17.380 --> 00:36:24.990 Aaron McHale: not sure where to break. Well, actually, this is yeah, this is a funny, Not that I think about it. This is a weird case, because 439 00:36:25.420 --> 00:36:30.180 Aaron McHale: normally the breadcrumb comes from the page title. So 440 00:36:31.400 --> 00:36:33.030 Aaron McHale: Oh, do you know what, though? 441 00:36:34.860 --> 00:36:45.350 Aaron McHale: So blocks doesn't technically have a view? You know I'm going to look into this more. It might end up being a fall if it's. If okay, it might end up Being part of this issue depends on what's happened here, because 442 00:36:45.510 --> 00:36:52.700 Aaron McHale: you would then expect I don't know how this has gotten to be one, because you would expect it. It would just use the title of 443 00:36:53.430 --> 00:37:04.620 Aaron McHale: it. What it does is it uses the title of like, whatever it thinks. This this path is so block 5, so it could be that they're just it wasn't able to generate a title, which is why there's 444 00:37:04.730 --> 00:37:06.529 Aaron McHale: the ideas here, so. 445 00:37:06.600 --> 00:37:11.360 Aaron McHale: and that maybe needs more investigation is to to understand why that's happened. 446 00:37:11.800 --> 00:37:12.520 Yeah. 447 00:37:12.870 --> 00:37:17.120 Benji Fisher: yeah, blocks are funny that they they don't have a view. 448 00:37:18.370 --> 00:37:20.410 Benji Fisher: Yeah. So block 449 00:37:20.640 --> 00:37:25.909 Benji Fisher: slash, 5 is the edit form. It's not block 5 slash at it. 450 00:37:26.410 --> 00:37:35.410 Aaron McHale: Yeah. And I guess we probably keep that like that, because again it's from my perspective to avoid the issues you can see with 451 00:37:35.710 --> 00:37:38.309 Aaron McHale: taxonomy with the breakdown 452 00:37:38.460 --> 00:37:41.729 Aaron McHale: The fact that edit is the first time 453 00:37:42.920 --> 00:37:53.270 Aaron McHale: and it's or I guess, because the the canonical path here goes to edit means that edits the first tab, and then all the all other tabs kind of follow up with that. So I think that makes sense to 454 00:37:53.360 --> 00:38:03.769 Aaron McHale: keep it that way rather than trying to introduce like a slash edit. And then it breaks the bright comfort. All the other tabs, which is what you can see happening with them on the taxonomy side. 455 00:38:04.710 --> 00:38:05.379 Right? 456 00:38:13.760 --> 00:38:14.910 Aaron McHale: Okay, 457 00:38:15.500 --> 00:38:32.910 Aaron McHale: I think we're. I think we're at a good point. I'll update this issue just with the summary of what we've discussed, and then we can figure out from there, if it needs any, follow up issues or or anything like that. But it is already postponed on the moving block library to content. So we'll just 458 00:38:33.020 --> 00:38:39.580 Aaron McHale: work on the assumption of the path. The plot fly. Green blocks will end up being under admin content box. 459 00:38:43.740 --> 00:38:46.410 Benji Fisher: Yeah, I I agree. I think this is 460 00:38:46.710 --> 00:38:48.290 Benji Fisher: a good stop in place. 461 00:38:52.510 --> 00:38:53.909 Aaron McHale: I will. 462 00:38:54.030 --> 00:38:55.460 Aaron McHale: We'll stop sharing. 463 00:38:56.730 --> 00:38:57.490 Benji Fisher: Okay. 464 00:39:01.060 --> 00:39:03.339 I don't take any minutes. Find the right window. 465 00:39:08.470 --> 00:39:10.039 That's right. That's done. 466 00:39:11.170 --> 00:39:16.990 Benji Fisher: Okay. So i'm. Now looking at issue number 2, 8, 6, 2, 8, 5 9 467 00:39:17.190 --> 00:39:22.850 Benji Fisher: create a top-level extendable content admin that behaves like structure. 468 00:39:28.320 --> 00:39:29.729 Benji Fisher: And 469 00:39:30.220 --> 00:39:33.419 Benji Fisher: I guess the context is that 470 00:39:33.440 --> 00:39:35.969 Benji Fisher: a few people have advocated 471 00:39:38.810 --> 00:39:43.349 Benji Fisher: solving this issue either before or along with the 472 00:39:43.740 --> 00:39:48.679 Benji Fisher: rearrangement of the block admin pages that we've been working on 473 00:39:51.240 --> 00:39:52.709 Benji Fisher: and 474 00:39:54.460 --> 00:39:56.379 Benji Fisher: well, let's. Let's read the 475 00:39:56.730 --> 00:40:03.580 Benji Fisher: some of the issues summary. Now that we have 2.8 positively encouraged developers screen multiple types of content entity. 476 00:40:04.060 --> 00:40:07.629 Benji Fisher: we need to stop assuming that all content is made from nodes. 477 00:40:07.990 --> 00:40:17.660 Benji Fisher: Even in core tuple we have node content, comments, files, custom blocks, taxonomy, terms, and more as of 8.4. We also have media. 478 00:40:18.100 --> 00:40:20.089 Benji Fisher: and the proposed resolution 479 00:40:20.190 --> 00:40:26.009 Benji Fisher: is to change the menu, admin slash, content to use the same page lab as admin structure. 480 00:40:26.290 --> 00:40:29.210 Benji Fisher: and then have the current node content. View 481 00:40:29.270 --> 00:40:30.890 Benji Fisher: a sub page of that 482 00:40:30.940 --> 00:40:33.760 Benji Fisher: comments to another sub page, etc. 483 00:40:34.620 --> 00:40:38.919 Benji Fisher: so let's let me switch over to 484 00:40:39.980 --> 00:40:44.120 Benji Fisher: by sample sites, and we have admin content. 485 00:40:45.050 --> 00:40:49.060 Benji Fisher: which is currently mainly the list of nodes 486 00:40:50.910 --> 00:40:54.499 Benji Fisher: and has sub tabs for files and media. 487 00:40:54.640 --> 00:40:56.109 Benji Fisher: I guess I 488 00:40:56.500 --> 00:40:57.959 Benji Fisher: this is the demo 489 00:40:58.450 --> 00:41:02.429 Benji Fisher: the money demo profiles, and maybe comments. Aren't enabled 490 00:41:02.630 --> 00:41:05.989 Benji Fisher: If they were, there would be a separate tab for them here. 491 00:41:08.440 --> 00:41:11.389 Benji Fisher: we're already proposing 492 00:41:11.440 --> 00:41:14.369 Benji Fisher: making the list of custom blocks 493 00:41:14.700 --> 00:41:17.430 Benji Fisher: a a further sub tab. 494 00:41:19.180 --> 00:41:21.530 Benji Fisher: and for comparison 495 00:41:24.040 --> 00:41:26.649 Benji Fisher: Let me go to admin structure. 496 00:41:31.340 --> 00:41:33.540 Benji Fisher: and this is 497 00:41:33.750 --> 00:41:39.100 Benji Fisher: what what I sometimes call a a container page. It it 498 00:41:39.300 --> 00:41:40.750 Benji Fisher: has nothing but 499 00:41:41.220 --> 00:41:49.009 Benji Fisher: a list of links which which also show up in the administration menu that this must be 500 00:41:49.650 --> 00:41:56.850 Benji Fisher: and the proposal is that the Content page look a lot like this. You have the title content. 501 00:41:57.140 --> 00:41:59.469 Benji Fisher: and then a link for 502 00:42:00.140 --> 00:42:01.410 Benji Fisher: nodes 503 00:42:01.920 --> 00:42:05.679 Benji Fisher: where we tie yourselves in. Not that we've decided to 504 00:42:06.060 --> 00:42:08.340 Benji Fisher: refer to notes as content. 505 00:42:08.540 --> 00:42:09.929 Why. 506 00:42:11.930 --> 00:42:13.490 Benji Fisher: nodes. 507 00:42:13.670 --> 00:42:16.140 Benji Fisher: comments, files, media 508 00:42:16.170 --> 00:42:18.209 Benji Fisher: blocks whatever. 509 00:42:19.680 --> 00:42:20.939 Benji Fisher: So 510 00:42:21.380 --> 00:42:25.649 Benji Fisher: the argument in favor is consistency. 511 00:42:26.390 --> 00:42:28.890 Benji Fisher: Perhaps there is a feeling that 512 00:42:29.610 --> 00:42:32.970 Benji Fisher: that we're getting too many tabs 513 00:42:34.300 --> 00:42:42.320 Benji Fisher: on this page. i'm not sure. Maybe there's an objection to having the 2 levels of of tabs, tabs, and sub tabs. 514 00:42:44.150 --> 00:42:54.539 Benji Fisher: and the the argument against making that change is that well, nodes are still commonly used, and we want to be able to get to this listing 515 00:42:54.960 --> 00:42:56.929 Benji Fisher: pretty conveniently. 516 00:42:59.910 --> 00:43:03.269 Benji Fisher: and and I think Aaron has 517 00:43:04.010 --> 00:43:05.920 Benji Fisher: has made that argument 518 00:43:06.210 --> 00:43:07.310 Benji Fisher: that 519 00:43:07.850 --> 00:43:10.549 Benji Fisher: getting to the stage would require an extra click. 520 00:43:11.010 --> 00:43:12.049 If 521 00:43:12.210 --> 00:43:14.960 if we implement this, this proposal. 522 00:43:19.910 --> 00:43:21.880 Benji Fisher: and its usual slack is 523 00:43:21.910 --> 00:43:26.410 Benji Fisher: making it hard for me to see the 524 00:43:28.750 --> 00:43:30.579 Benji Fisher: opened up, the slack chat. 525 00:43:30.690 --> 00:43:33.680 Benji Fisher: don't see anything new there. 526 00:43:35.690 --> 00:43:37.270 Benji Fisher: Anything more you 527 00:43:37.450 --> 00:43:40.990 Benji Fisher: any of you would like to bring up for for this issue 528 00:43:43.420 --> 00:43:44.419 Aaron McHale: empty. 529 00:43:45.560 --> 00:43:48.229 Aaron McHale: Yeah, I mean to build on that a little bit like. 530 00:43:48.810 --> 00:43:54.580 Aaron McHale: you know. If we take the example of a you know, publishing site like a media publishing site or something. 531 00:43:56.020 --> 00:43:59.520 Aaron McHale: you know, having the content like 532 00:43:59.710 --> 00:44:05.940 Aaron McHale: go to? Well, you know, and as such concept people is of content in a way it. It feels 533 00:44:06.070 --> 00:44:08.390 Aaron McHale: it feels right, because 534 00:44:08.420 --> 00:44:11.319 Aaron McHale: you know everything else coming to fall off from 535 00:44:11.630 --> 00:44:25.040 Aaron McHale: notes in a way like like I know it would be an article generally stick in the publishing site, right? And so media would be attached. Those articles, like files of it has articles. you know, blocks. Even so, 536 00:44:25.590 --> 00:44:34.949 Aaron McHale: in that context that that that kind of makes a lot of sense right, that this is the thing you land on, and then all the other things almost feel like assets of content. 537 00:44:35.090 --> 00:44:35.810 Aaron McHale: And 538 00:44:36.480 --> 00:44:45.579 Aaron McHale: but in in a site it's a bit less straightforward. That might not be the case, and the situation more like a a lay. It more like the structure. Page might. 539 00:44:45.790 --> 00:44:49.199 Aaron McHale: So another type of site. Quite well. So. 540 00:44:49.370 --> 00:44:54.459 Aaron McHale: And I think that's part of the problem with this issue is like, there's not really a clear 541 00:44:55.020 --> 00:44:58.770 Aaron McHale: it's not clear in all cases, 542 00:44:59.120 --> 00:45:03.289 Aaron McHale: And and so I I guess I don't have a definitive answer there. But 543 00:45:03.390 --> 00:45:07.679 Aaron McHale: It's just something that I think that can see why this has just gotten stuck for a long time. 544 00:45:10.360 --> 00:45:14.480 Simo Hellsten: I think, one of the cases where one might not to 545 00:45:14.530 --> 00:45:17.080 Simo Hellsten: Why, one, maybe that wouldn't need 546 00:45:17.240 --> 00:45:23.169 Simo Hellsten: list of node Content would be a site that uses commerce products 547 00:45:23.540 --> 00:45:31.110 Simo Hellsten: us and has a is a headless like the back end for headless commerce site. 548 00:45:31.240 --> 00:45:42.150 Simo Hellsten: and but in that case all the commerce of would be in its own menu, anyway, so the products would wouldn't be under content, even if they would be the main content 549 00:45:42.760 --> 00:45:44.399 Simo Hellsten: like 550 00:45:45.760 --> 00:45:47.429 Simo Hellsten: in that that kind of 551 00:45:47.940 --> 00:45:52.010 Simo Hellsten: situation I can see that one wouldn't need that content listing. But 552 00:45:52.300 --> 00:45:55.720 Simo Hellsten: then again, it wouldn't be 553 00:45:56.370 --> 00:45:59.859 Simo Hellsten: something. Then you you could just hide the content part 554 00:45:59.960 --> 00:46:02.510 Simo Hellsten: kind of you. You wouldn't. It wouldn't be 555 00:46:02.900 --> 00:46:04.950 Simo Hellsten: on the way of anything. I guess 556 00:46:06.250 --> 00:46:10.500 Benji Fisher: that's right. The Commerce Module adds a top level entry to the 557 00:46:10.760 --> 00:46:13.869 Benji Fisher: Administration menu for commerce. 558 00:46:14.140 --> 00:46:16.639 Benji Fisher: and underneath that it has 559 00:46:17.770 --> 00:46:23.489 Benji Fisher: product, types, profit, variation types, and the list of products and me. 560 00:46:23.940 --> 00:46:26.680 Benji Fisher: maybe not for this product variations I forget. 561 00:46:28.330 --> 00:46:31.639 Benji Fisher: So so commerce based site. 562 00:46:32.170 --> 00:46:34.290 Benji Fisher: this issue doesn't matter much, does it 563 00:46:36.520 --> 00:46:37.169 Aaron McHale: it? 564 00:46:37.210 --> 00:46:39.979 Aaron McHale: I guess it's it's funny, because 565 00:46:41.210 --> 00:46:51.620 Aaron McHale: this whole thing really starts to fall apart. If you uninstall the node module, because what you end up with is is a a slash. Admin such content, which still exists with a content tab. 566 00:46:51.960 --> 00:46:54.209 Aaron McHale: But it's a completely empty page. 567 00:46:54.330 --> 00:46:58.879 Aaron McHale: And so that really illustrates the problem. If you get, if you do that. 568 00:46:59.010 --> 00:47:12.260 Aaron McHale: and maybe there's a that's a middle ground solution, where, if the node module, because what's what's actually happening is that this route is provided by the system module, which is why it still exists. If the node modules are installed. But but no, it takes over this route. 569 00:47:12.800 --> 00:47:13.629 Aaron McHale: So 570 00:47:13.680 --> 00:47:22.450 Aaron McHale: maybe a part way to solving this would be actually, if the no module isn't installed. You get that you get a structure like Page. 571 00:47:22.750 --> 00:47:26.829 Aaron McHale: when, if it's, if it's installed, you get this content view instead. 572 00:47:27.810 --> 00:47:31.670 Benji Fisher: That's an interesting compromise. I think that's that's worth considering. 573 00:47:31.930 --> 00:47:33.140 Benji Fisher: Go ahead for help. 574 00:47:35.010 --> 00:47:40.629 Ralf Koller: and also a plus one for Aaron's idea. Right? Now that sounds interesting. 575 00:47:40.750 --> 00:47:42.709 Ralf Koller: Just wanted to point out 576 00:47:44.920 --> 00:47:47.579 Ralf Koller: one issue I have with the current 577 00:47:48.770 --> 00:47:53.940 Ralf Koller: way is, if you have admin tool by installed it's. 578 00:47:55.090 --> 00:48:01.020 Ralf Koller: I actually know how things are structured and laid out, but it always makes me think 579 00:48:02.440 --> 00:48:04.930 Ralf Koller: Where do I have to click? If I'm. 580 00:48:05.330 --> 00:48:12.149 Ralf Koller: I want to go into the in this into the note list. I have to click the top level item. But 581 00:48:12.370 --> 00:48:13.250 Ralf Koller: in the 582 00:48:13.320 --> 00:48:20.690 Ralf Koller: sub-level items you have at content, and comments and files and it's such a mixture and overlap 583 00:48:20.720 --> 00:48:22.080 Ralf Koller: that makes 584 00:48:22.140 --> 00:48:26.710 Ralf Koller: makes it confusing a bit, and always makes me think, and 585 00:48:26.790 --> 00:48:27.859 Ralf Koller: also 586 00:48:29.140 --> 00:48:39.409 Ralf Koller: from a naming perspective, to having the top level item called content, and then have another suppliable item, again called Content is also one 587 00:48:39.890 --> 00:48:41.599 Ralf Koller: sort of confusing. 588 00:48:42.390 --> 00:48:43.419 Ralf Koller: even though 589 00:48:44.880 --> 00:48:47.169 Ralf Koller: it's correct. And yeah. 590 00:48:47.380 --> 00:48:52.250 Ralf Koller: more precisely, node. But that is would be too complicated for 591 00:48:52.560 --> 00:48:54.060 Ralf Koller: as experienced people. 592 00:48:55.750 --> 00:48:58.120 Ralf Koller: But still it's confusing 593 00:48:58.810 --> 00:49:05.049 Benji Fisher: right. That's a a consequence of the problem that I described earlier as how we've tied herself up in not 594 00:49:05.170 --> 00:49:07.609 Benji Fisher: referring to notes as as content. 595 00:49:09.400 --> 00:49:10.570 Aaron McHale: One of the 596 00:49:11.470 --> 00:49:13.470 Aaron McHale: another interesting call is 597 00:49:13.780 --> 00:49:17.799 Aaron McHale: this issue we almost like becomes a lot easier to solve if we 598 00:49:18.740 --> 00:49:21.090 Aaron McHale: completely redesigned the toolbar. 599 00:49:21.560 --> 00:49:28.949 Aaron McHale: because the problem with like the approach is okay. We could do what search does. But as you, as we said, like you click content. 600 00:49:29.000 --> 00:49:31.899 Aaron McHale: and then you have to click content again right? 601 00:49:31.970 --> 00:49:41.940 Aaron McHale: But if we had a toolbar like the gin toolbar and plus admin toolbar, where you can just like, hover over the content icon, and you get a list of like great content. You get media right that 602 00:49:42.140 --> 00:49:48.990 Aaron McHale: almost mix it like by by by doing what they should suggest, and making content, behave like structure. 603 00:49:49.170 --> 00:50:03.509 Aaron McHale: we don't actually degrade the experience today. We because you would almost never get to get to that that listing page you would be using the toolbar to get to that second level content item. And I know the reason I bring it up is because I know there's like 604 00:50:03.960 --> 00:50:09.159 Aaron McHale: efforts to potentially do something like that, like, you know, we want to 2 bars 605 00:50:09.340 --> 00:50:13.450 Aaron McHale: to the that we think. But that's something that could actually happen. So I 606 00:50:14.050 --> 00:50:25.929 Aaron McHale: I wonder if it's worth even just the sporting this issue and saying, let's revisit this Once we redesign the toolbar because the hits the solution might be a lot clearer then. 607 00:50:33.540 --> 00:50:34.490 Okay. So 608 00:50:34.780 --> 00:50:41.130 Benji Fisher: so I I did just install the admin toolbar, and you can see the the dropdown on on several of these. 609 00:50:46.170 --> 00:50:48.349 Benji Fisher: no, I I I wonder why. 610 00:50:48.540 --> 00:50:54.169 Benji Fisher: we we don't have any children of of content in the administration Menu. 611 00:50:56.030 --> 00:50:58.190 Ralf Koller: and there usually is. 612 00:51:00.800 --> 00:51:01.640 Hmm. 613 00:51:04.250 --> 00:51:09.929 Benji Fisher: So do I have to go to? I I don't know I just. I just enabled it with the default configuration. 614 00:51:10.400 --> 00:51:12.389 Ralf Koller: Could you go to the extent again. 615 00:51:14.100 --> 00:51:16.830 Ralf Koller: and such for admin Tuba. 616 00:51:20.020 --> 00:51:24.870 Ralf Koller: I just collapsed. This. It'll be right there 617 00:51:25.420 --> 00:51:26.330 Ralf Koller: to link 618 00:51:26.380 --> 00:51:28.589 Ralf Koller: access links to those 2. 619 00:51:28.680 --> 00:51:29.339 So 620 00:51:29.840 --> 00:51:30.509 okay. 621 00:51:36.780 --> 00:51:37.720 Benji Fisher: okay. 622 00:51:40.480 --> 00:51:41.250 so. 623 00:51:42.120 --> 00:51:47.220 Benji Fisher: Yeah. So this this, I think, is a good idea, and would not be hard to add to core to 624 00:51:48.040 --> 00:51:50.220 Benji Fisher: I at these 625 00:51:50.420 --> 00:51:51.910 Benji Fisher: items to the 626 00:51:52.560 --> 00:51:54.180 Benji Fisher: administration menu 627 00:51:54.460 --> 00:51:56.550 Benji Fisher: and that would 628 00:51:57.320 --> 00:52:01.940 Benji Fisher: mitigate the the extra click problem that 629 00:52:02.230 --> 00:52:03.489 Benji Fisher: Aaron brought up. 630 00:52:03.920 --> 00:52:06.829 Benji Fisher: if Content did become 631 00:52:07.970 --> 00:52:14.490 Benji Fisher: a container page like this. And just as we can go to structure and click on the link. 632 00:52:16.070 --> 00:52:18.869 Benji Fisher: We could open up content in the 633 00:52:19.020 --> 00:52:23.460 Benji Fisher: core, admin menu and click on the link for notes. 634 00:52:26.020 --> 00:52:31.430 Benji Fisher: So, on the other hand, most people don't seem to use the toolbar in in the vertical 635 00:52:31.560 --> 00:52:33.810 Benji Fisher: orientation. 636 00:52:35.720 --> 00:52:37.300 Benji Fisher: So for the 637 00:52:37.550 --> 00:52:43.040 Benji Fisher: for those of us who do, or for those who install the admin toolbar. 638 00:52:45.760 --> 00:52:47.540 Benji Fisher: yes, I have to reload this page. 639 00:52:49.890 --> 00:52:53.120 Benji Fisher: that that would mitigate the extra click problem. 640 00:52:56.570 --> 00:53:01.480 Benji Fisher: Oh, yeah, the other thing I wanted to say is that even though 641 00:53:02.500 --> 00:53:04.760 Benji Fisher: people 8 and beyond 642 00:53:06.470 --> 00:53:10.119 Benji Fisher: have all these different entity types that are 643 00:53:10.240 --> 00:53:12.000 Benji Fisher: in some ways 644 00:53:12.580 --> 00:53:14.749 Benji Fisher: on the same level as known. 645 00:53:15.000 --> 00:53:16.569 Benji Fisher: In fact. 646 00:53:17.720 --> 00:53:23.089 Benji Fisher: there are a lot of places where nodes have a special case 647 00:53:23.190 --> 00:53:26.169 Benji Fisher: in Drupal, and I I I keep finding new ones. 648 00:53:28.230 --> 00:53:30.500 Benji Fisher: So 1 one is 649 00:53:31.130 --> 00:53:35.939 Benji Fisher: as the one that Aaron pointed out that that this page content 650 00:53:36.080 --> 00:53:40.429 Benji Fisher: is defined by the system module, and then overridden by the node module 651 00:53:42.150 --> 00:53:45.190 Benji Fisher: and and sort of related to that is the 652 00:53:45.650 --> 00:53:46.870 Benji Fisher: permission. 653 00:53:53.380 --> 00:53:58.230 Benji Fisher: i'm going to just type into my address bar. It's much module size. Node 654 00:54:02.590 --> 00:54:05.970 Benji Fisher: The what permission do I want? 655 00:54:08.500 --> 00:54:10.500 Aaron McHale: This is the view content. One year 656 00:54:10.610 --> 00:54:11.980 Aaron McHale: you publish content. 657 00:54:12.040 --> 00:54:13.930 Benji Fisher: Yeah, if you publish content 658 00:54:14.060 --> 00:54:17.830 Benji Fisher: that permission is actually created by the system. Module 659 00:54:20.200 --> 00:54:22.679 Benji Fisher: So that was an attempt to 660 00:54:23.350 --> 00:54:27.569 Benji Fisher: remove the special place the Node Module has 661 00:54:28.060 --> 00:54:29.209 Benji Fisher: Andrew Poll 662 00:54:29.360 --> 00:54:43.790 Benji Fisher: and and yet, when when that permission was to the system module they put in a hack to make it look like it's it's provided by the node module by by putting it under node rather than putting it under system. 663 00:54:46.220 --> 00:54:48.500 Benji Fisher: there are other places. 664 00:54:52.580 --> 00:54:54.299 Benji Fisher: and I oh, yes. 665 00:54:54.460 --> 00:54:58.189 Benji Fisher: the other one I wanted to mention was 666 00:54:59.650 --> 00:55:04.349 Benji Fisher: that, and and we we we've talked about this on 667 00:55:04.460 --> 00:55:05.790 Benji Fisher: on views. 668 00:55:06.320 --> 00:55:08.389 Benji Fisher: So when you go to the structure. 669 00:55:09.210 --> 00:55:10.630 Benji Fisher: use 670 00:55:11.020 --> 00:55:13.359 Benji Fisher: and let's edit the content view. 671 00:55:13.460 --> 00:55:16.270 Benji Fisher: You remember we talked about this a few months ago. 672 00:55:16.530 --> 00:55:18.749 Benji Fisher: what was it under 673 00:55:19.610 --> 00:55:23.030 Benji Fisher: the relationships and textual filters? 674 00:55:26.000 --> 00:55:29.270 Benji Fisher: If you add a textual filter? 675 00:55:36.560 --> 00:55:39.059 Benji Fisher: I don't see it. 676 00:55:41.710 --> 00:55:47.020 Benji Fisher: yes, there there is there an extra step that I i'd have to do. But there's some 677 00:55:48.000 --> 00:55:52.159 Benji Fisher: a special relationship between the node module and the tax on a new module. 678 00:55:52.260 --> 00:55:54.759 Benji Fisher: and you can filter on 679 00:55:55.580 --> 00:55:57.049 Benji Fisher: tax on a me term. 680 00:55:57.870 --> 00:56:01.110 Benji Fisher: so maybe, or maybe it wasn't. 681 00:56:01.160 --> 00:56:03.110 Benji Fisher: Their name was under the filter. 682 00:56:05.300 --> 00:56:06.759 If we 683 00:56:09.250 --> 00:56:09.910 well. 684 00:56:12.140 --> 00:56:16.620 Benji Fisher: let me not try to remember that. Let me let me just say there, there! There is a dedicated 685 00:56:16.980 --> 00:56:21.199 Benji Fisher: database table that keeps track specifically of nodes. 686 00:56:21.580 --> 00:56:24.230 Benji Fisher: and the taxonomy terms applied to them. 687 00:56:25.380 --> 00:56:31.639 Benji Fisher: and it doesn't apply. If you have taxonomy terms that attach to Media, for example. 688 00:56:32.590 --> 00:56:37.760 Benji Fisher: and that affects the the views filtering, so 689 00:56:38.360 --> 00:56:43.000 Benji Fisher: I mean it's too far into the weeds here. But but the point is 690 00:56:43.030 --> 00:56:49.839 Benji Fisher: that there are still lots of places in Drupal core where where the Node module has a special place. 691 00:56:54.490 --> 00:56:57.230 Benji Fisher: getting back to the issue. 692 00:57:10.910 --> 00:57:12.340 Benji Fisher: So 693 00:57:14.430 --> 00:57:23.269 Benji Fisher: What, what, what do we think now are? Are the the next steps for this? I I think 1 one is to add a at Aaron's suggestion. 694 00:57:23.650 --> 00:57:25.579 Benji Fisher: that we 695 00:57:25.960 --> 00:57:29.739 Benji Fisher: that when the Node module is not installed, that we 696 00:57:29.870 --> 00:57:34.269 Benji Fisher: could do, I think exactly what this issue recommends. Am I right? 697 00:57:35.310 --> 00:57:37.289 Aaron McHale: Yeah. The only 698 00:57:38.390 --> 00:57:39.580 Aaron McHale: Well. 699 00:57:39.670 --> 00:57:42.520 Aaron McHale: it sounds easy. But then you've considered okay. 700 00:57:42.940 --> 00:57:47.570 Aaron McHale: What do you do about the local tasks? Because 701 00:57:48.310 --> 00:57:55.419 Aaron McHale: if we simply go ahead and implement the issue as it's written, we, we, we convert some of the local tasks to value links. 702 00:57:55.450 --> 00:58:05.160 Aaron McHale: But if we go with what I was proposing, we need both manuals and local tasks. So then you would end up with a situation where you've got a bunch of local tasks on a structural looking page. 703 00:58:05.190 --> 00:58:07.930 Aaron McHale: and also all the links. 704 00:58:08.170 --> 00:58:11.460 Aaron McHale: so we would need to find a way to then also not 705 00:58:11.810 --> 00:58:17.660 Aaron McHale: show those local tasks, or only show this one for tasks when they, when the node modules installed. 706 00:58:23.010 --> 00:58:25.429 it is. Is that the case? 707 00:58:26.270 --> 00:58:28.099 Benji Fisher: Go ahead. 708 00:58:28.320 --> 00:58:40.170 Aaron McHale: Yeah. I mean, I think it would be the case like, Imagine the structure page for the bunch, but all of the like the media and the files local tasks as well as the media and files links on this page. 709 00:58:40.910 --> 00:58:42.580 Aaron McHale: You might end up, because that 710 00:58:42.600 --> 00:58:52.970 Aaron McHale: because we would have to define. Because what's happening is those modules are defining local tasks, not menu links, which is why, with our admin toolbar content doesn't have any value links under it. 711 00:58:53.650 --> 00:59:01.009 Aaron McHale: And so we wouldn't end up in a situation where they would all they would. They would just all get split on this page. 712 00:59:02.320 --> 00:59:07.289 Aaron McHale: So that might be something to we would need to be to be reconciled. 713 00:59:09.640 --> 00:59:11.629 Benji Fisher: I see your point, so I I guess. 714 00:59:11.730 --> 00:59:17.509 Benji Fisher: when the Node module is not enabled, we would want something like this content 715 00:59:17.600 --> 00:59:19.069 Benji Fisher: with 716 00:59:19.280 --> 00:59:23.680 Benji Fisher: I guess by default. comments media blocks. 717 00:59:23.780 --> 00:59:25.709 Benji Fisher: if those models are enabled. 718 00:59:27.130 --> 00:59:28.330 Benji Fisher: And then 719 00:59:29.860 --> 00:59:31.940 Benji Fisher: the node module would not only 720 00:59:32.340 --> 00:59:34.170 Benji Fisher: create this 721 00:59:34.600 --> 00:59:37.920 Benji Fisher: list of nodes on that page, but would also add them 722 00:59:38.220 --> 00:59:41.009 Benji Fisher: these other pages as 723 00:59:43.000 --> 01:00:00.949 Aaron McHale: as a local tasks, as as primary tabs on the page. Yeah, that that probably exists some some kind of again I don't want to dive into like implementation, but just work clear. It probably would make sense to have the node module. Then just look at all the menu links and generate the local tasks that rather than 724 01:00:00.960 --> 01:00:07.929 Aaron McHale: the other way around. Because then then it means, like media, all us to do is to provide one menu link, and it doesn't need to worry about the complexities around that. 725 01:00:13.100 --> 01:00:17.900 Aaron McHale: I I also do wonder, though, with like we should just say because this issue hasn't moved in 726 01:00:18.200 --> 01:00:31.310 Aaron McHale: years. It's more likely that the Admin Tob is going to get redesigned before this issue is done. and maybe it makes us just say, you know, yeah, let's just pull this on the Admin. To about redesign until 727 01:00:31.400 --> 01:00:33.739 Aaron McHale: and then revisit it. After that 728 01:00:41.570 --> 01:00:42.479 Benji Fisher: Well. 729 01:00:43.920 --> 01:00:51.280 Benji Fisher: the the admin toolbar redesign is also something that we've been talking about for a long time, but doesn't seem like it's going to happen anytime soon. 730 01:00:51.480 --> 01:00:53.080 Benji Fisher: so I i'm not sure. 731 01:00:53.530 --> 01:00:57.819 Benji Fisher: Yeah, although all the Ralph agrees with postponing it. 732 01:00:58.520 --> 01:01:03.370 Aaron McHale: Yeah, I just like to like. Is it like it's clearly nobody's 733 01:01:03.400 --> 01:01:07.790 Aaron McHale: like if this issue was really a massive problem for loads of people it would have been. 734 01:01:08.110 --> 01:01:11.530 Aaron McHale: I would hope that it would have seen more more activity. But, like 735 01:01:11.750 --> 01:01:14.659 Aaron McHale: it, it, it seems like we'd be doing a lot of work, and then. 736 01:01:14.980 --> 01:01:18.039 Aaron McHale: like potentially not needing it, because if if 737 01:01:18.220 --> 01:01:18.919 Aaron McHale: if 738 01:01:18.970 --> 01:01:27.040 Aaron McHale: that material bar was redesigned to loop more or less behave like the gen toolbar; but being back to which it's. From what I understand, this is the current 739 01:01:28.660 --> 01:01:31.670 Aaron McHale: like the designs, is what it is. 740 01:01:31.730 --> 01:01:36.720 Aaron McHale: then, or at least the proposed. I don't know how concrete all this is. 741 01:01:36.960 --> 01:01:42.610 Aaron McHale: then we you know the whole. It might be like. Oh, well, you know, we can just put a structure style page in, and no 742 01:01:42.800 --> 01:01:45.729 bother because it won't be any harder to get to the content 743 01:01:45.870 --> 01:01:47.169 Aaron McHale: link. So 744 01:01:48.140 --> 01:01:53.290 Aaron McHale: I don't want to see us doing a bunch of work and then being like, oh, actually, we don't need it, you know. 745 01:01:54.250 --> 01:01:58.959 Benji Fisher: Okay. So so good point. There, there is work going on to redesign the 746 01:01:59.800 --> 01:02:06.299 Benji Fisher: the the the the toolbar in in control. And specifically it's Jane Module 747 01:02:06.400 --> 01:02:11.680 Benji Fisher: I just uninstalled or deleted. I deleted the view 748 01:02:11.710 --> 01:02:16.009 Benji Fisher: that normally creates the content page. Let's reload this and see what we get. 749 01:02:18.780 --> 01:02:20.799 Benji Fisher: Okay. So this, I guess, is 750 01:02:21.250 --> 01:02:23.059 Benji Fisher: generated by the 751 01:02:23.920 --> 01:02:25.139 Aaron McHale: No, not too. 752 01:02:25.240 --> 01:02:31.499 Benji Fisher: Yeah, it'll be it. It looks pretty much the same, except without the filters. So I I was just curious what would happen there? 753 01:02:32.900 --> 01:02:35.959 Benji Fisher: yeah, what what if your question I wanted to bring up is is 754 01:02:36.260 --> 01:02:40.540 Benji Fisher: how hard it would be to implement that this change 755 01:02:40.840 --> 01:02:42.979 Benji Fisher: in a controlled module. 756 01:02:43.680 --> 01:02:51.450 Benji Fisher: So I guess you the first step is, you? Would you would delete or or disable that view, and then have a trip module. 757 01:02:51.560 --> 01:02:55.479 Benji Fisher: override this page. I wonder if that would be an option. 758 01:02:58.390 --> 01:03:03.329 Aaron McHale: And then, if if you have to be done in, can trip that that decreases the 759 01:03:04.110 --> 01:03:07.499 Benji Fisher: the argument for saying that we should do it in the core. 760 01:03:09.670 --> 01:03:12.099 Aaron McHale: I think you could do in control, because 761 01:03:14.600 --> 01:03:17.890 Aaron McHale: well, yeah, I don't see why you could 762 01:03:19.120 --> 01:03:21.169 Benji Fisher: you? You'd be overwriting around. 763 01:03:21.700 --> 01:03:23.039 I think that can be done. 764 01:03:24.550 --> 01:03:29.020 Aaron McHale: Yeah, because that's what the node module is doing, like literally the example we just saw of. 765 01:03:29.080 --> 01:03:33.890 Aaron McHale: or or we're looking at right now is the Don't module overriding a route provided by the system Module. 766 01:03:37.550 --> 01:03:41.660 Aaron McHale: So we we've got an example in core as to how you could do it. 767 01:03:44.200 --> 01:03:50.840 Aaron McHale: if you're if you're up for completely trash in the site. Go ahead and uninstall the node module, just refund and see what this looks like. 768 01:03:50.990 --> 01:04:04.770 Benji Fisher: Now we only have 2 min left, and you know, before I can uninstall the no module, I have to remove all the content. So never mind that it's more more than a click or 2, but but yes, it is a throwaway side. I I I could do that. 769 01:04:05.020 --> 01:04:05.720 Aaron McHale: Yeah. 770 01:04:13.020 --> 01:04:19.929 Benji Fisher: okay. So I I I will add a comments. I I think the the important things are are 771 01:04:20.230 --> 01:04:21.140 Benji Fisher: one. 772 01:04:21.330 --> 01:04:29.569 Benji Fisher: we. We might do this when the Node module is not installed to, if it can be done in contrib. Then there's less argument for doing it in the core. 773 01:04:31.400 --> 01:04:32.709 Benji Fisher: and 774 01:04:32.750 --> 01:04:34.029 Benji Fisher: and 3 775 01:04:35.800 --> 01:04:40.859 Benji Fisher: with ongoing work to redesign the admin toolbar 776 01:04:42.080 --> 01:04:44.000 Benji Fisher: especially in 777 01:04:44.200 --> 01:04:47.939 Benji Fisher: that that may. Maybe we should just 778 01:04:50.450 --> 01:04:52.219 Benji Fisher: post phone this issue till later. 779 01:04:53.200 --> 01:04:55.399 Benji Fisher: Any other closing comments. 780 01:04:56.970 --> 01:05:06.459 Aaron McHale: I I think that sounds good. I I would only add that if if it was, the idea of doing it contrived is, is could also be seen as a proof of concept as to how you would do it. 781 01:05:08.700 --> 01:05:12.669 Aaron McHale: So maybe phrasing it as a proof of concept way of getting it, you know. 782 01:05:13.380 --> 01:05:14.129 Aaron McHale: getting it done. 783 01:05:16.200 --> 01:05:16.970 Benji Fisher: Okay. 784 01:05:17.850 --> 01:05:18.729 Good point. 785 01:05:20.080 --> 01:05:25.409 Benji Fisher: Well, thank you all for coming, and it is just at the top of the hour. So 786 01:05:26.140 --> 01:05:28.980 Benji Fisher: have a good day, and hope to see that next week. 787 01:05:30.450 --> 01:05:31.509 Aaron McHale: I think so. 788 01:05:32.200 --> 01:05:32.870 What? 789 01:05:33.620 --> 01:05:34.560 Ralf Koller: All right. 790 01:05:34.750 --> 01:05:35.470 Aaron McHale: right?