diff --git a/entity_browser.views.inc b/entity_browser.views.inc index 19bcf04..bc1df86 100644 --- a/entity_browser.views.inc +++ b/entity_browser.views.inc @@ -11,7 +11,7 @@ use Drupal\search_api\Entity\Index; * Implements hook_views_data_alter(). */ function entity_browser_views_data_alter(&$data) { - foreach (\Drupal::entityTypeManager()->getDefinitions() as $entity_type_name => $entity_type) { + foreach (\Drupal::entityTypeManager()->getDefinitions() as $entity_type) { if ($base_table = $entity_type->getBaseTable()) { $entity_keys = $entity_type->get('entity_keys'); $data[$base_table]['entity_browser_select'] = [ diff --git a/modules/entity_form/entity_browser_entity_form.module b/modules/entity_form/entity_browser_entity_form.module index 2e07150..0fa4a9f 100644 --- a/modules/entity_form/entity_browser_entity_form.module +++ b/modules/entity_form/entity_browser_entity_form.module @@ -103,7 +103,7 @@ function entity_browser_entity_form_reference_form_validate(array &$reference_fo // Check if the entity is already referenced by the field. if (!empty($attach_entities)) { foreach ($attach_entities as $attach_entity) { - foreach ($form_state->get(['inline_entity_form', $ief_id, 'entities']) as $key => $value) { + foreach ($form_state->get(['inline_entity_form', $ief_id, 'entities']) as $value) { if ($value['entity']->getEntityTypeId() == $attach_entity->getEntityTypeId() && $value['entity']->id() == $attach_entity->id()) { $form_state->setError($reference_form['entity_browser'], t('The selected @label has already been added.', ['@label' => $labels['singular']])); $reference_form['entity_browser']['entity_ids']['#value'] = ''; diff --git a/src/Form/EntityBrowserEditForm.php b/src/Form/EntityBrowserEditForm.php index 465dc75..4427712 100644 --- a/src/Form/EntityBrowserEditForm.php +++ b/src/Form/EntityBrowserEditForm.php @@ -337,7 +337,7 @@ class EntityBrowserEditForm extends EntityForm { $output .= '
'; - foreach ($definitions as $plugin_id => $plugin_definition) { + foreach ($definitions as $plugin_definition) { $output .= '
' . $plugin_definition['label'] . ':
'; $output .= '
' . $plugin_definition['description'] . '
'; } diff --git a/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php b/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php index 13df19e..dd6b0f3 100644 --- a/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php +++ b/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php @@ -489,7 +489,6 @@ class EntityReferenceBrowserWidget extends WidgetBase { $triggering_element = $form_state->getTriggeringElement(); if (!empty($triggering_element['#attributes']['data-entity-id']) && isset($triggering_element['#attributes']['data-row-id'])) { $id = $triggering_element['#attributes']['data-entity-id']; - $row_id = $triggering_element['#attributes']['data-row-id']; $parents = array_slice($triggering_element['#parents'], 0, -static::$deleteDepth); $array_parents = array_slice($triggering_element['#array_parents'], 0, -static::$deleteDepth); diff --git a/tests/src/FunctionalJavascript/ConfigurationTest.php b/tests/src/FunctionalJavascript/ConfigurationTest.php index 9d9d705..0a85d9b 100644 --- a/tests/src/FunctionalJavascript/ConfigurationTest.php +++ b/tests/src/FunctionalJavascript/ConfigurationTest.php @@ -199,7 +199,6 @@ class ConfigurationTest extends WebDriverTestBase { $this->assertSession()->responseContains('Select view mode to be used when rendering entities.'); // Test ajax update of Multi step selection display "Entity type". - $entity_type = $this->assertSession()->selectExists('selection_display_configuration[entity_type]')->selectOption('taxonomy_term'); $this->assertSession()->assertWaitOnAjaxRequest(); $this->assertSession()->optionExists('selection_display_configuration[display_settings][view_mode]', 'default'); $this->assertSession()->assertWaitOnAjaxRequest(); diff --git a/tests/src/FunctionalJavascript/EntityBrowserTest.php b/tests/src/FunctionalJavascript/EntityBrowserTest.php index f2bc387..886c046 100644 --- a/tests/src/FunctionalJavascript/EntityBrowserTest.php +++ b/tests/src/FunctionalJavascript/EntityBrowserTest.php @@ -138,9 +138,6 @@ class EntityBrowserTest extends EntityBrowserWebDriverTestBase { // Create a file. $image = $this->createFile('llama'); - // Create a second file. - $image2 = $this->createFile('llama2'); - $this->drupalGet('node/add/article'); $this->assertSession()->linkExists('Select entities');