diff --git a/core/core.services.yml b/core/core.services.yml index 868d4ab..b4953d6 100644 --- a/core/core.services.yml +++ b/core/core.services.yml @@ -191,6 +191,9 @@ services: controller_resolver: class: Drupal\Core\Controller\ControllerResolver arguments: ['@service_container'] + title_resolver: + class: Drupal\Core\Controller\TitleResolver + arguments: ['@controller_resolver', '@string_translation'] http_kernel: class: Drupal\Core\HttpKernel arguments: ['@event_dispatcher', '@service_container', '@controller_resolver'] @@ -358,7 +361,7 @@ services: - { name: event_subscriber } controller.page: class: Drupal\Core\Controller\HtmlPageController - arguments: ['@http_kernel', '@controller_resolver'] + arguments: ['@http_kernel', '@controller_resolver', '@title_resolver'] controller.dialog: class: Drupal\Core\Controller\DialogController arguments: ['@http_kernel'] diff --git a/core/lib/Drupal/Core/Controller/HtmlPageController.php b/core/lib/Drupal/Core/Controller/HtmlPageController.php index d87b3ed..a2bbfaa 100644 --- a/core/lib/Drupal/Core/Controller/HtmlPageController.php +++ b/core/lib/Drupal/Core/Controller/HtmlPageController.php @@ -7,6 +7,7 @@ namespace Drupal\Core\Controller; +use Symfony\Cmf\Component\Routing\RouteObjectInterface; use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpKernel\HttpKernelInterface; @@ -31,15 +32,25 @@ class HtmlPageController { protected $controllerResolver; /** + * The title resolver. + * + * @var \Drupal\Core\Controller\TitleResolver + */ + protected $titleResolver; + + /** * Constructs a new HtmlPageController. * * @param \Symfony\Component\HttpKernel\HttpKernelInterface $kernel * @param \Drupal\Core\Controller\ControllerResolverInterface $controller_resolver * The controller resolver. + * @param \Drupal\Core\Controller\TitleResolver $title_resolver + * The title resolver. */ - public function __construct(HttpKernelInterface $kernel, ControllerResolverInterface $controller_resolver) { + public function __construct(HttpKernelInterface $kernel, ControllerResolverInterface $controller_resolver, TitleResolver $title_resolver) { $this->httpKernel = $kernel; $this->controllerResolver = $controller_resolver; + $this->titleResolver = $title_resolver; } /** @@ -66,8 +77,8 @@ public function content(Request $request, $_content) { ); } // If no title was returned fall back to one defined in the route. - if (!isset($page_content['#title']) && $request->attributes->has('_title')) { - $page_content['#title'] = $request->attributes->get('_title'); + if (!isset($page_content['#title'])) { + $page_content['#title'] = $this->titleResolver->getTitle($request, $request->attributes->get(RouteObjectInterface::ROUTE_OBJECT)); } $response = new Response(drupal_render_page($page_content)); diff --git a/core/lib/Drupal/Core/Controller/TitleResolver.php b/core/lib/Drupal/Core/Controller/TitleResolver.php new file mode 100644 index 0000000..13da2f3 --- /dev/null +++ b/core/lib/Drupal/Core/Controller/TitleResolver.php @@ -0,0 +1,84 @@ +controllerResolver = $controller_resolver; + $this->translationManager = $translation_manager; + } + + /** + * Returns the title from a static or dynamic title. + * + * @param \Symfony\Component\HttpFoundation\Request $request + * The request object passed to the title callback. + * @param \Symfony\Component\Routing\Route $route + * The route information of the route to fetch the title. + * + * @return string + * The title of the route as string. + */ + public function getTitle(Request $request, Route $route) { + // A dynamic title takes priority. + if ($route->hasDefault('_title_callback')) { + $callback = $route->getDefault('_title_callback'); + $callable = $this->controllerResolver->getControllerFromDefinition($callback); + $arguments = $this->controllerResolver->getArguments($request, $callable); + return call_user_func_array($callable, $arguments); + } + elseif ($route->hasDefault('_title')) { + // Fall back to a static string from the route. + $title = $route->getDefault('_title'); + return $this->t($title); + } + else { + return ''; + } + } + + /** + * Translates a string to the current language or to a given language. + * + * See the t() documentation for details. + */ + protected function t($string, array $args = array(), array $options = array()) { + return $this->translationManager->translate($string, $args, $options); + } + +} diff --git a/core/modules/aggregator/aggregator.module b/core/modules/aggregator/aggregator.module index aaffcdc..dad6234 100644 --- a/core/modules/aggregator/aggregator.module +++ b/core/modules/aggregator/aggregator.module @@ -90,7 +90,6 @@ function aggregator_theme() { */ function aggregator_menu() { $items['admin/config/services/aggregator'] = array( - 'title' => 'Feed aggregator', 'description' => "Configure which content your site aggregates from other sites, how often it polls them, and how they're categorized.", 'route_name' => 'aggregator_admin_overview', 'weight' => 10, diff --git a/core/modules/aggregator/aggregator.routing.yml b/core/modules/aggregator/aggregator.routing.yml index 57da7ee..2ad97e2 100644 --- a/core/modules/aggregator/aggregator.routing.yml +++ b/core/modules/aggregator/aggregator.routing.yml @@ -2,6 +2,7 @@ aggregator_admin_overview: pattern: 'admin/config/services/aggregator' defaults: _content: '\Drupal\aggregator\Controller\AggregatorController::adminOverview' + _title: 'Feed aggregator' requirements: _permission: 'administer news feeds' diff --git a/core/modules/system/lib/Drupal/system/Tests/System/PageTitleTest.php b/core/modules/system/lib/Drupal/system/Tests/System/PageTitleTest.php index 43c5786..97cd47a 100644 --- a/core/modules/system/lib/Drupal/system/Tests/System/PageTitleTest.php +++ b/core/modules/system/lib/Drupal/system/Tests/System/PageTitleTest.php @@ -128,9 +128,10 @@ function testTitleXSS() { /** * Tests the page title of render arrays. * - * @see \Drupal\test_page_test\Controller\Test::renderTitle() + * @see \Drupal\test_page_test\Controller\Test */ - public function testRenderTitle() { + public function testRoutingTitle() { + // Test the '#title' render array attribute. $this->drupalGet('test-render-title'); $this->assertTitle('Foo | Drupal'); @@ -150,6 +151,20 @@ public function testRenderTitle() { $this->assertTitle('Test dynamic title | Drupal'); $result = $this->xpath('//h1'); $this->assertEqual('Test dynamic title', (string) $result[0]); + + // Test the static '_title' route option. + $this->drupalGet('test-static-title'); + + $this->assertTitle('Static title | Drupal'); + $result = $this->xpath('//h1'); + $this->assertEqual('Static title', (string) $result[0]); + + // Test the dynamic '_title_callback' route option. + $this->drupalGet('test-dynamic-title'); + + $this->assertTitle('Dynamic title | Drupal'); + $result = $this->xpath('//h1'); + $this->assertEqual('Dynamic title', (string) $result[0]); } } diff --git a/core/modules/system/tests/modules/test_page_test/lib/Drupal/test_page_test/Controller/Test.php b/core/modules/system/tests/modules/test_page_test/lib/Drupal/test_page_test/Controller/Test.php index 850ca2d..d73838c 100644 --- a/core/modules/system/tests/modules/test_page_test/lib/Drupal/test_page_test/Controller/Test.php +++ b/core/modules/system/tests/modules/test_page_test/lib/Drupal/test_page_test/Controller/Test.php @@ -26,4 +26,26 @@ public function renderTitle() { return $build; } + /** + * Returns a 'dynamic' title for the '_title_callback' route option. + * + * @return string + * The page title. + */ + public function dynamicTitle() { + return 'Dynamic title'; + } + + /** + * Returns a generic page render array for title tests. + * + * @return array + * A render array as expected by drupal_render() + */ + public function renderPage() { + return array( + '#markup' => 'Content', + ); + } + } diff --git a/core/modules/system/tests/modules/test_page_test/test_page_test.routing.yml b/core/modules/system/tests/modules/test_page_test/test_page_test.routing.yml index 2de2a4d..b1feead 100644 --- a/core/modules/system/tests/modules/test_page_test/test_page_test.routing.yml +++ b/core/modules/system/tests/modules/test_page_test/test_page_test.routing.yml @@ -19,3 +19,18 @@ test_page_render_title_controller: requirements: _access: 'TRUE' +test_page_static_title: + pattern: '/test-static-title' + defaults: + _content: 'Drupal\test_page_test\Controller\Test::renderPage' + _title: 'Static title' + requirements: + _access: 'TRUE' + +test_page_dynamic_title: + pattern: '/test-dynamic-title' + defaults: + _content: 'Drupal\test_page_test\Controller\Test::renderPage' + _title_callback: 'Drupal\test_page_test\Controller\Test::dynamicTitle' + requirements: + _access: 'TRUE' diff --git a/core/modules/user/lib/Drupal/user/Controller/UserController.php b/core/modules/user/lib/Drupal/user/Controller/UserController.php index cd63cb0..d4842ef 100644 --- a/core/modules/user/lib/Drupal/user/Controller/UserController.php +++ b/core/modules/user/lib/Drupal/user/Controller/UserController.php @@ -7,7 +7,9 @@ namespace Drupal\user\Controller; +use Drupal\User\UserInterface; use Drupal\user\Form\UserLoginForm; +use Drupal\Component\Utility\Xss; use Symfony\Component\DependencyInjection\ContainerAware; use Symfony\Component\HttpFoundation\RedirectResponse; use Symfony\Component\HttpFoundation\Request; @@ -42,6 +44,19 @@ public function userPage(Request $request) { } /** + * Route title callback. + * + * @param \Drupal\Core\Entity\UserInterface $user + * The user account. + * + * @return string + * The user account name. + */ + public function userTitle(UserInterface $user = NULL) { + return $user ? Xss::filter($user->getUsername()) : ''; + } + + /** * Logs the current user out. * * @param \Symfony\Component\HttpFoundation\Request $request diff --git a/core/modules/user/user.module b/core/modules/user/user.module index f629882..ba37de7 100644 --- a/core/modules/user/user.module +++ b/core/modules/user/user.module @@ -855,13 +855,9 @@ function user_menu() { $items['user/%user'] = array( 'title' => 'My account', - 'title callback' => 'user_page_title', - 'title arguments' => array(1), - 'page callback' => 'user_view_page', - 'page arguments' => array(1), - 'access callback' => 'entity_page_access', - 'access arguments' => array(1), + 'route_name' => 'user_view', ); + $items['user/%user/view'] = array( 'title' => 'View', 'type' => MENU_DEFAULT_LOCAL_TASK, @@ -1015,13 +1011,6 @@ function user_menu_title() { } /** - * Menu item title callback - use the user name. - */ -function user_page_title(UserInterface $account = NULL) { - return $account ? $account->getUsername() : ''; -} - -/** * Try to validate the user's login credentials locally. * * @param $name @@ -1328,18 +1317,6 @@ function user_delete_multiple(array $uids) { } /** - * Page callback wrapper for user_view(). - */ -function user_view_page($account) { - if (is_object($account)) { - return user_view($account); - } - // An administrator may try to view a non-existent account, - // so we give them a 404 (versus a 403 for non-admins). - throw new NotFoundHttpException(); -} - -/** * Generate an array for rendering the given user. * * When viewing a user profile, the $page array contains: diff --git a/core/modules/user/user.routing.yml b/core/modules/user/user.routing.yml index ba75389..b458de5 100644 --- a/core/modules/user/user.routing.yml +++ b/core/modules/user/user.routing.yml @@ -103,6 +103,14 @@ user_page: requirements: _access: 'TRUE' +user_view: + pattern: '/user/{user}' + defaults: + _entity_view: 'user.full' + _title_callback: 'Drupal\user\Controller\UserController::userTitle' + requirements: + _entity_access: 'user.view' + user_login: pattern: '/user/login' defaults: