The convention for Views plugins is MODULENAME_plugin_TYPE_SUFFIX:
views_plugin_style_fullcalendar => fullcalendar_plugin_style
views_plugin_node_fullcalendar => fullcalendar_plugin_row

In addition, the templates should start with MODULENAME:
views-view-fullcalendar.tpl.php => fullcalendar-view.tpl.php
views-view-node-fullcalendar.tpl.php => fullcalendar-view-row.tpl.php

In addition, all of the views related files will move into an includes folder.

Comments

tim.plunkett’s picture

Status: Active » Postponed

After reading http://drupal.org/node/369445, postponing on git. Seriously. Totally not worth it.

geerlingguy’s picture

Heh... had to remove a folder and add a folder in CVS once for Airy Blue. It's worth waiting.

tim.plunkett’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
Status: Postponed » Active

YEAH!

geerlingguy’s picture

Is Git working yet? Can't check from work, because git port is blocked :(

tim.plunkett’s picture

Status: Active » Needs review

Made a new feature branch, git clone --branch reorganize-1003602 tim.plunkett@git.drupal.org:project/fullcalendar.git

aspilicious’s picture

Ok, back in action :)

- Should we create a css folder?
(I like readme, changelog, install, module and info be the only things in main folder)

- Should we brake up the include folder a bit more?
includes/
includes/views
includes/views/handlers
includes/views/plugins
(thats the structure ctools, and commerce modules are using if I'm not mistaken)

- I love the fact that you ripped out the views template stuff

BTW: I didn't test it :)

geerlingguy’s picture

Makes sense, wrt the views subdirectories...

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned

Okay made those changes, can I get a quick test from someone before I pull it into the main branch?

aspilicious’s picture

Status: Needs review » Needs work

Tested! Calendar stuff is working but admin section isn't. :)

  $items['admin/config/calendar/fullcalendar'] = array(
    'title' => 'FullCalendar',
    'description' => 'Adjust FullCalendar settings.',
    'file' => 'fullcalendar.admin.inc',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('fullcalendar_admin_settings'),
    'access arguments' => array('administer site configuration'),
  );

file path has to be changed!

tim.plunkett’s picture

Status: Needs work » Needs review

Changed.

Damn, working without patches is fun.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looked at all your commits in the branch (I love my gui tools).
Analysed the changes and tried to brake stuff.

I broke admin but after you fixed the path I wasn't able to break anything else :(
I didn't test everything but I think I have tested the parts that could be broken by the changes you made.

RTBC...

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Fixed! Git++.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

Follow-up, I failed to rename the empty handler.
http://drupalcode.org/project/fullcalendar.git/commit/0720a9f

tim.plunkett’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Assigned: Unassigned » tim.plunkett
Status: Closed (fixed) » Active

Bringing order to the D6 branch.

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Active » Needs review

Pushed a branch called reorganize, does anyone want to test it before I merge it in?

tim.plunkett’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.