Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The bot now runs against D7. This makes all 6.x patches fail and confuses developers + causes a multitude of related issues to be filed regarding this.
- The bot should be able to test patches against various core versions.
- For starters, patches could be auto-tested against the version of the issue they are posted to.
- Later on, there should be an option upon upload allowing to select the version against which the patch(es) will be tested.
Comments
Comment #1
pillarsdotnet CreditAttribution: pillarsdotnet commentedSort-of fixed.
Right now all patches in issues marked 6.x are given a status of "Postponed".
I suspect that there aren't any D6 testbots right now.
Comment #2
klonosLike you said Bob: "sort-of fixed". Thanx for the update concerning the postponed status of 6.x patches. This at least will take care of the patches failing tests when people expect them to pass.
PS: ...corrected minor typo in issue's title.
Comment #3
klonos...if #66484: Allow issues to be filed against multiple versions/branches. gets ever implemented, then the 'run tests against the core version the issue is set to' part of the request should become 'run tests against the version each patch is set to'.
Comment #4
pillarsdotnet CreditAttribution: pillarsdotnet commentedLooks like the testbots are testing against the version the issue is set to. so marking this "fixed".
Comment #5
klonosYep. Now should I file a new issue about the test bot running against the core version each patch is set to and keep this issue's status fixed, or should we rename this one instead and keep it open?
Still relevant: #66484: Allow issues to be filed against multiple versions/branches.
Also related: #1050616: Figure out backport workflow from Drupal 8 to Drupal 7
Comment #6
pillarsdotnet CreditAttribution: pillarsdotnet commentedYou must do what you think is right, of course. But any further progress is going to block on #66484: Allow issues to be filed against multiple versions/branches.
Comment #7
klonosI hear you Bob. The thing is that some maintainers roll patches for both D6 & D7 in one go. They usually file the issue against 7.x and simply leave the 6.x patch be ignored by the bot. This needs to be addressed in a manner that tests both/all patches against their respective core version.
PS: ...issue title change to reflect what actually got fixed.
Comment #8
klonos#1171958: Allow files to be assigned to branch(es)/version(s) and thus tested against it
Comment #10
Mile23A bit of a follow-up for the new era of drupalci: #2663018: Useful core branch defaults for contrib CI