After update to 6.x-2.1, I now have borders around tables on all pages. Have found that there is new table css in style.css. One line in particular causes the problem which I have commented out in the following code:

tr td, tr th {
/* border:1px solid #bbb; */
padding: 0 6px;
}

This fixes the table border problem.

Some css that has been removed from style.css causes the spurious tables lines. The following needs to be added back to remove the lines:

/* Code to eliminate daft 1px line from themes having tables inside a page */
tbody {
border-top: 0px solid #ccc;
}

/* Code to eliminate daft 1px line from bottom of node content */
.node {
border-bottom:0px solid #BBBBBB;
}

Comments

danpros’s picture

danpros CreditAttribution: danpros commented
Category: bug » task

Hi,

Yes I add new borders on 6.x-2.1, so this is not a bug :) and you are welcome to add this into Danland's documentation, like "How to removing the borders around tables" etc.

Dan,

srhart’s picture

srhart CreditAttribution: srhart commented

Sorry, while I appreciate the work you've put in creating the theme but if I wanted to have borders round the tables I'd have put them there already. Why suddenly put borders round tables, especially if they specifically state border="0"?

And why remove the fix for the 1px horizontal lines?

danpros’s picture

danpros CreditAttribution: danpros commented

Hi,

Hmm.. okay I will condisering to go back to previous border style in my next release (D6 version). How about the D7 version? are you already test that? someday you must using the D7 version isn't? :)

Dan,

itserich’s picture

itserich CreditAttribution: itserich commented

Thanks srhart.

srhart’s picture

srhart CreditAttribution: srhart commented

Hi

Yes just knocked a D7 site together and the same issue applies, and is fixed using the above patches.

danpros’s picture

danpros CreditAttribution: danpros commented

Hi,

Its seem all of you liked if no border in tables like Danland 6.x-2.0 :) okay I will considering to change the D7 version in final release. For D6 version I will change it later time since currently I am focus to D7 version only.

Thanks,
Dan

itserich’s picture

itserich CreditAttribution: itserich commented

I had figured out how to comment out the code for most of the border via Firebug, but it would never have occurred to me to add the node and tbody code to remove the remaining border.

Some documentation would probably fix it.

I have looked at a lot of themes and this one is wonderful. And thanks Dan for helping people so much with responses.

http://petnotice.com/

danpros’s picture

danpros CreditAttribution: danpros commented
Status: Active » Closed (fixed)

Hi itserich,

Thanks I will updating the handbook later. Nice site :)

I will close this.

Dan

digitalista77’s picture

digitalista77 CreditAttribution: digitalista77 commented
Version: 6.x-2.1 » 7.x-1.0

Thanks man , u saved my life. U just need to go to style.css and change

tr td, tr th {
border:1px solid #bbb; /* change this values to whatever u want */
padding: 0 6px;
}

and it will work as a charm.

Thanks again people.