A minor point for performance, it's better to run empty() against a variable before comparing it to another variable, rather than the reverse.

CommentFileSizeAuthor
#1 features-n1009900.patch914 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
914 bytes

Patch attached.

hefox’s picture

hefox’s picture

Status: Fixed » Patch (to be ported)

wrong status

hefox’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
mpotter’s picture

Status: Patch (to be ported) » Fixed

Committed f39fe8c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.