nodequeue2flag migration, global flags & default weights, size of weights in database [#1011664]

Hello,

Indymedia linksunten (http://linksunten.indymedia.org) migrated from nodequeue module to flag, flag weights and draggable views. We wrote a migration module which might help people who want to migrate their nodequeues to global flags, too. Find the module attached to this posting.

We found two problems with flag weights:
1. The size of the weight field in the database is tinyint (-128 to 127) which is much too small. The horrible ui of nodequeue when it comes to big queues was the main reason to migrate to flag module.
2. The patch in #550008: Default weight on flag does not respect global flags.

We addressed both issues and attached patches which fix the problem for us.

Now we have to test if our flag_solr_bias module (which is mainly a port of the relevant parts of the nodequeue module) works as expected then we can disable nodequeue module.

File	Size	Author
flag_weights.module.linksunten.patch	2.31 KB	linksunten
flag_weights.install.linksunten.patch	1.23 KB	linksunten
nodequeue2flag.zip	1.35 KB	linksunten

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lyricnz CreditAttribution: lyricnz commented 13 January 2011 at 12:48

On the size of the flag weight, you have a point. However, there are a couple of issues with the patch:

- 'length' doesn't apply to int types (use size)

- default value for int fields should be 0 not '0'

- need to update hook_schema_alter also, so that schemas still match. should not modify existing/old hook_update_x (since they won't be run for existing installs)

- need to update existing table structures in a hook_update_xx not just change the base install (otherwise existing installs won't be updated)