after upgrading to the dev version from 11 jan 2011, i started to get PHP warning messages re. illegal offset type in common.inc, line 1805 -- only with the new version of views_slideshow.

a diff between the previous version and this one showed that the culprit is this statement in line 201:
drupal_add_css($module_path . '/views_slideshow_controls_text.css', array('type' => 'file'));

  1. 'type' shouldn't be 'file'; according to the documentation in common.inc, it's either "module" or "theme", defaulting to "module";
  2. the function in common inc (function drupal_add_css($path = NULL, $type = 'module', $media = 'all', $preprocess = TRUE)) doesn't expect an array at this point, but a string;

not providing this parameter, or providing the string 'module' resolves this problem; no error or warning messages appear.

Files: 

Comments

sorry, i forgot to mention which file i'm talking about: views_slideshow.theme.inc.

Whoops Bad backport from drupal 7.

Status:Active» Reviewed & tested by the community
StatusFileSize
new610 bytes

Quicker to get this in if a patch is provided?

Status:Reviewed & tested by the community» Fixed

Committed thank you.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.