hey

i've tried setting a logo through the theme configuration page, but it never displays.
i've looked in the code and it seems the logo part is logo absent.

can you add that, for branding purposes?

Files: 
CommentFileSizeAuthor
#1 page.tpl_.php_.patch2.14 KBlpalgarvio
#1 style.css_.patch1.17 KBlpalgarvio

Comments

Status:Active» Patch (to be ported)
StatusFileSize
new1.17 KB
new2.14 KB

hey

made a patch for this and more.
it replaces the branding div html/php code with this:

<div id="branding" class="clearfix">
    <div id="header">
      <div id="header-left">
        <?php if (!empty($breadcrumb)): ?><?php print $breadcrumb; ?><?php endif; ?>
        <?php if ($site_name || $site_slogan): ?>
          <div id="name-and-slogan">
            <?php if ($site_name): ?>
              <?php if ($title): ?>
                <div id="site-name"><strong>
                  <a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home"><span><?php print $site_name; ?></span></a>
                </strong></div>
              <?php else: /* Use h1 when the content title is empty */ ?>
                <h1 id="site-name">
                  <a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home"><span><?php print $site_name; ?></span></a>
                </h1>
              <?php endif; ?>
            <?php endif; ?>
            <?php if ($site_slogan): ?>
              <div id="site-slogan"><?php print $site_slogan; ?></div>
            <?php endif; ?>
          </div> <!-- /#name-and-slogan -->
        <?php endif; ?>
      </div>
      <div id="header-right">
        <?php if ($logo): ?>
          <a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home" id="logo"><img src="<?php print $logo; ?>" alt="<?php print t('Home'); ?>" /></a>
        <?php endif; ?>
      </div>
    </div>
    <div id="title-tabs">
      <?php if (!empty($title)): ?>
        <h1 class="page-title"><?php print $title; ?></h1>
      <?php endif; ?>
      <?php if (!empty($primary_local_tasks)): ?><ul class="tabs primary"><?php print $primary_local_tasks; ?></ul><?php endif; ?>
    </div>
  </div>

and adds a few classes to the styles.css:

/**
* Headers
*/
div#header {
  height: 90px;
}
div#header-left {
  float: left;
}
div#header-right {
  float: right;
  position: relative;
  top: -10px;
}
/**
* Logo
*/
#logo /* Wrapping link for logo */ {
  margin: 0;
  padding: 0;
}
#logo img {
  vertical-align: bottom;
}
/**
* Name and Slogan
*/
#name-and-slogan /* Wrapper for website name and slogan */ {
}
h1#site-name,
div#site-name /* The name of the website */ {
  display: inline;
  margin: 0;
  font-size: 1.5em;
  line-height: 1.3em;
}
#site-name a:link,
#site-name a:visited {
  color: #fff;
  text-decoration: none;
}
#site-name a:hover,
#site-name a:focus {
  color: #000;
  text-decoration: none;
}
#site-slogan /* The slogan (or tagline) of a website */ {
  display: inline;
  color: #fff;
}

also added a administration menu class to change the font.

/* Administration Menu */
#admin-menu {
  font-family: "Helvetica Neue",Helvetica,Arial,sans-serif;
  font-size: 13px;
  line-height: 20px;
}

I have added these code into my files. from the code itself, I guess I should have a region which call header-right ? but I still only got a 'content' region in my site. How can I have a 'header' region ? Thanks

my code is flawed. the tabs/tasks get shown incorrectly. i will upload a new version whenever i get new some time.

provided you did patch correctly, even thought the css/html needs fixes, you still need to clear the cache and visit the themes page to remap the regions for themes.

Status:Patch (to be ported)» Closed (won't fix)

This theme is meant to be a direct backport of the Seven theme in Drupal 7, which isn't designed to support a logo, so this request isn't in line with the project's goals. But you can easily create a sub-theme of it and make any modifications you want to the templates and regions in that. That way you can make your changes without having to hack the theme.

Also, when you submit a patch, the status should be set to "needs review". See Status settings for an issue.