Port Decisions module to Drupal 7

It's possible, if anarcat don't mind. I think I can port Decisions to D7.

Unless somebody else volunteers, you're it! We can easily create branches now with git so that's cool :)

subscribe!

subscribe

Some talk here to combine Advanced Poll and Decisions in a new D7 module:
#1022944: D7 port of Advanced Poll

Updating title so it makes more sense in activity display on dashboard.
Plus that gets me updates without having to say the "S" word :-)

Anyone have an update whether a D7 version of anything similar is available yet?
Anyone up for a code sprint for this at Drupalcon Denver?

No info yet about the port? Developers in Advanced Poll are already starting into D7, it would be great to combine efforts and create a single and more powerful module.

Subscribing

I am interessted in an D7 Module, too. Are there any news yet? Thank you!

Subscribed to this. Would love to see a D7 version.

I have started porting this module to Drupal 7.

@nouriassafi / #15: can you post a zip file of how far you got, plus some comments about your focus?
How about considering joining forces with http://drupal.org/project/advpoll and http://drupal.org/project/pollfield modules?
Ref. #589210: The future of Pollfield

FYI I've developed an Election module for D7, which overlaps in functionality with Decisions and Advanced Poll, although it's a quite different approach. Review thread: #1679472: Election.

Ref. http://association.drupal.org/election2013-results

"Posted by sun on Thu, 2012-10-11 02:24
- I patched Decisions module instead:"
http://drupal.org/node/674112#comment-6586262

"Posted by sethcohn on Fri, 2012-10-19 02:07
- I'll volunteer to port Decisions to D7"
https://association.drupal.org/comment/3548#comment-3548

association.drupal.org has now been upgraded to Drupal7.

The board's election committee is starting to plan for next year's elections. I note a couple of people have offered to port this module - has there been any progress on that?

tagging...

Nothing outside what is documented in this issue unfortunately.

Not even close to be usable, I haven't even tested any of the changes that have been made so for, nor even enabled the module, and in the last 10 minutes of my train ride this morning I was only taking the softball coder issues, however I wanted to get a patch up to get the ball rolling.

wow. thanks @Deciphered!

They say talk is silver, code is gold, so a start is definitely progress! :)

Here's a move forward of the work by Deciphered in #23 but still a huge amount of work to do here.

Now module installs without breaking the site and schema is safe, also some of the database queries have been transformed to DBTNG and fixed php errors all around. Also marked ranking & selection as D7.

//@TODO :)

- decision_form I guess need to be transformed to hook_forms as I think it's invoked from $node->content['decisions']['form']['#value'] = drupal_get_form('decisions_' . $mode . '_voting_form', $node, $teaser, $page);
- Also hook_view will probably need to be transformed to hook_node_view or hook_entity_view. I'd probably need to install the module in D6 to copycat the features to D7.
- hook_menu needs some love, but I need to see where are the tabs.
- We need desperately a decisions.page.inc for all these, decisions.module is 1700+ lines of code that can be split.
- More tests.

@anarcat, the way I see the port happening goes through opening a d7-dev branch to keep a better track of all the changes.

I'd be happy to give commit access to you or Deciphered to finish this port.

Is it me or does those patches have a lot of unrelated whitespace changes? Some of those changes are great an necessary, but they make it really hard to review the port properly. If this is done in a git repo, at the very least those should be in separate commits.

Is it me or does those patches have a lot of unrelated whitespace changes?

Hmm I'm reviewing with Dreditor and I don't see such changes, are they all over for you?

Sure, with dreditor. Witness:

+++ b/INSTALL.txtundefined
@@ -1,31 +1,30 @@
 
 INSTALLATION
 ------------
 
-1. DOWNLOAD AND INSTALL VOTING API 
+1. DOWNLOAD AND INSTALL VOTING API

removes trailing space

+++ b/decisions.installundefined
@@ -1,60 +1,148 @@
-      'mode' => array('type' => 'varchar', 'length' => '32', 'not null' => TRUE),

this gets turned in this:

+++ b/decisions.installundefined
@@ -1,60 +1,148 @@
+      'mode' => array(
+        'type' => 'varchar',
+        'length' => '32',
+        'not null' => TRUE,

... and numerous others.

oh yeah, that's probably the editor used in any of the patches fixing coding standards :(

Maybe you could open a D7 "experimental" branch or whatever name you prefer and start making progress in there, I'll be happy to push it forward.

I think git -w ignores whitespaces?

Alright, you're it. I hereby grand pcambra commit access to the decisions module, but please restrict yourself to the 7.x-1.x branch I just created for now, and be careful when importing commits: don't mix whitespace and "let's move around code" with the actual porting effort. There's a lot of cruft in this module, and there's a lot of that uncrufting that seems to happen in this patch that could be beneficial both to D7 and D6... So isolating those commits will allow them to be cherry-picked across branches so be careful with that.

@Deciphered - if you're interested in commit access on that branch, also let me know.

@pcambra any progress here? :)

Not at all, sorry. Finally the association elections were done with election module and couldn't move this further.

Cleaning the whitespaces from the patch will be quite arduos too :(