Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drupal a11y’s picture

Guess this Is the same as here: http://drupal.org/node/1407418

Jackinloadup’s picture

Title: show format preview on wysiwyg insert format page » Display image format preview on field insert as well as wysiwyg insert format page
Version: 7.x-1.x-dev » 7.x-2.x-dev
Priority: Normal » Major

Marked #1407418: Apply Image Styles to Thumbnail (after Image has been uploaded) as a duplicate.

In that issue it is expressed that this is "a really essential feature, especially if landscape pictures are used, the square preview is really bad to see what image was used." - mori

I moved this issue to 2.x b/c I don't believe any more features are being added to 1.x

John Pitcairn’s picture

I really hope this would be an optional feature. I'd want to turn it off for every image field.

areikiera’s picture

Just checking in on the status of this feature request. Any updates?

Also, I agree with John Pitcairn, that it should be optional first, and with the ability to override by field.

Thanks!

Devin Carlson’s picture

Assigned: Unassigned » Devin Carlson
Status: Active » Needs review
FileSize
3.09 KB

A patch to display a real preview of the file being embedded using WYSIWYG that updates via AJAX whenever a view mode is selected.

Pretty cool if I say so myself!

ParisLiakos’s picture

this is awesome!
I would just commit this, since code looks good too, but i want to make sure first with John Pitcairn and areikiera.
Could you please test Devin's patch and see if you still think this should be optional?

just commited this part:
http://drupalcode.org/project/media.git/commit/9ef998a

in case someone wants to add this through hook_form_alter().

ParisLiakos’s picture

Status: Needs review » Needs work

Oh, i guess this needs to be rerolled now:/

Devin Carlson’s picture

Status: Needs work » Needs review
FileSize
1.97 KB

Reroll of #5.

I'll probably add this to Media WYSIWYG View Mode in case anyone wants to test out this functionality (until this issue is fixed and any necessary concerns are addressed).

gmclelland’s picture

Status: Needs review » Needs work
gmclelland’s picture

Devin Carlson’s picture

Status: Needs work » Needs review
FileSize
2.18 KB

An update of #8.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

I think this is a huge UX win...so i ll go ahead and rtbc this
lets wait a bit before committing though to give time for reactions

John Pitcairn’s picture

Argh. Sorry, i've been fairly busy and did not test this, but yes I definitely still think this should be optional - most of my users should absolutely not be choosing an image view mode or worrying about the preview size. We frequently alter the displayed size in css anyway on responsive themes, so the preview would not be accurate.

I think this would benefit from a simple Boolean configuration option in field instance settings, off by default.

I have become a little concerned about the way media is constantly adding quite obtrusive features which are turned on by default. UX is considerably dependent on the specific site and its intended users' sophistication and ability - feature proliferation does not equal improved UX. In this case, my users' UX would suffer because you're forcing them to look at something they do not need to consider at all.

aaron’s picture

Status: Reviewed & tested by the community » Needs work

joseph.olstad’s picture

Issue summary: View changes

Fixed a while back, thanks @Devin Carlson and @aaron.

joseph.olstad’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.