The string "Location" needs context for translators to be able to translate it correctly.

Some languages (Norwegian, at least -- I assume there are others) use different words for "location as a geographical place" and "location of files on a computer". Drupal core uses the string "Location" in the latter way (see screendump: http://drupal.org/files/issues/location_in_report.png). So in order to translate "Location" correctly for the location module, a context should be added, for instance "Geographical".

Related issue for the Location module: #1037278: Need string context for "Location". The context text should be the same for both these modules.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sutharsan’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
FileSize
584 bytes
559 bytes

This patch add a 'geolocation' context to the string 'Location'.

I have also extracted all translatable strings from Gmap module that contain the string 'location' and that are short enough to be reused in a different context. But I don't see any other candidates for context.

Not that introducing this context in the code will break the translation on existing sites. One way to mitigate this, is use an update script to copy existing translations to include the context. Some example code for this update can be found here: https://drupal.org/comment/8282125#comment-8282125

Sutharsan’s picture

Status: Active » Needs review

Needs review.

podarok’s picture

Status: Needs review » Fixed

#1 commited to 7.x-2.x
thanks!

podarok’s picture

tagged in new alpha release https://drupal.org/node/2159307

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.