Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When you disable the devel module it will attempt to restore the smtp library setting by copying the value of the devel_old_smtp_library variable into the smtp_library variable.
However the devel_old_smtp_library variable is only set when you visit the devel module's settings page. If you disable the module without ever visiting the settings page it will just blank your current smtp_library value since devel_old_smtp_library doesn't exist.
Either devel_old_smtp_library should be set when you enable the module or the disable should be a bit more discerning about what it actually changes.
Comment | File | Size | Author |
---|---|---|---|
#5 | devel-6.x-1.26-smtp-library-3.patch | 961 bytes | Dmitriy.trt |
#3 | devel-6.x-1.26-smtp-library-2.patch | 1.02 KB | Dmitriy.trt |
#1 | devel-6.x-1.26-smtp-library.patch | 1.02 KB | Dmitriy.trt |
Comments
Comment #1
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedSetting major priority, because this bug could completely break email sending for a whole site, like it was in our case.
Patch was made from stable 6.x-1.26 version, it fixes problem.
Comment #2
salvisThank you for the patch.
Please use NULL instead of '' and...
... empty() rather than =='' and swap the conditions.
Again empty() and swap.
This is to encourage clean and efficient coding.
Comment #3
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedMade all changes, here is a new version.
Comment #4
salvisMuch better. empty() and isset() are very fast, much faster than comparisons.
Should this go outside the braces?
Comment #5
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedYes, you're right.
Comment #6
salvisCommitted to D6 -dev. Not applicable to the other versions.
Thanks!