Strict warnings: Non-static methods should not be called statically [#1055568]

There are more strict warnings:

# Strict warning: Non-static method NodeController::buildQuery() should not be called statically, assuming $this from incompatible context in EntityCacheNodeController->buildQuery() (line 158 of entitycache.module).
# Strict warning: Non-static method CommentController::buildQuery() should not be called statically, assuming $this from incompatible context in EntityCacheCommentController->buildQuery() (line 206 of entitycache.module).

I refactored the module so controllers extend their original controller while using a helper class to get/set the cache. I needed to wrap the EntityCacheCommentController in a module_exists('comment') if-block to prevent errors of extending an unresolvable class.

Comment	File	Size	Author
#2	echelper2.patch	13.73 KB	casey
#2
	echelper.patch	13.26 KB	casey

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

catch

he/him

English

CreditAttribution: catch commented 9 February 2011 at 02:05

Thanks for this, extending the core controllers plus the helper is a good idea.

Couple of questions though:

The patch sets 'static cache' => TRUE for all entity types. Core specifically doesn't do this for comments and files since they're rarely loaded more than once per page, and for comments they're potentially loaded in large numbers so there's a good chance of bloating memory use for something that will only be requested once anyway.

It looks like this is done because otherwise the cacheSet and cacheGet methods won't be called at all. I don't see another way around this except for overriding load() - could we add that to the helper?

Also, I really don't like executing module_exists() in the raw .module file, looks like we could move the entity classes to .inc and let the registry handle it instead.