Incorrect format_date() call in _webform_filter_values() [#1058020]

At line 2708 we find this call:

 $replacement = format_date(strtotime($value['month'] . '/' . $value['day'] . '/' . $value['year']), 'custom', 'F j, Y', '0');

However this means we should use timezone '0' which does not exist. This argument should be omitted and become:

 $replacement = format_date(strtotime($value['month'] . '/' . $value['day'] . '/' . $value['year']), 'custom', 'F j, Y', '0');

Else you will get these messages:

Warning: timezone_open() [function.timezone-open]: Unknown or bad timezone (0) in format_date() (line 1867 of /home/berend/src/ibmt/www/includes/common.inc).
Warning: date_timezone_set() expects parameter 2 to be DateTimeZone, boolean given in format_date() (line 1905 of /home/berend/src/ibmt/www/includes/common.inc).

Comment	File	Size	Author
#2	webform_date_token-d6.patch	1.24 KB	quicksketch
#2
#2	webform_date_token-d7.patch	1.23 KB	quicksketch
#2
	webform_format_date.patch	762 bytes	berenddeboer

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch commented 10 February 2011 at 23:45

Status:

Needs review

» Needs work

Thanks, though I'd say that the argument should be 'UTC', not omitted. In Drupal 6, "timezones" were expressed by numbers, so 0 in D6 == 'UTC' in D7. Omitting the option will use the server or user timezone.

Comment #2

quicksketch

he/him

CreditAttribution: quicksketch commented 18 February 2011 at 23:27

Status:

Needs work

» Fixed

File	Size
webform_date_token-d7.patch	1.23 KB

webform_date_token-d6.patch	1.24 KB

I've tested and committed the attached patch, which uses the relatively new Webform date functions to accomplish the same thing as this patch, but works consistently across D6 and D7.

Comment #3

4 March 2011 at 23:31

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

carl.ben CreditAttribution: carl.ben commented 23 March 2012 at 04:55

Version:	7.x-3.6	» 7.x-3.17
Status:	Closed (fixed)	» Active

I get the same warnings using the latest version of Webform, after submitting a form:

Warning: timezone_open() [function.timezone-open]: Unknown or bad timezone (0) in format_date() (line 1899 of /public_html/includes/common.inc).
Warning: date_timezone_set() expects parameter 2 to be DateTimeZone, boolean given in format_date() (line 1937 of /public_html/includes/common.inc).

Comment #5

quicksketch

he/him

CreditAttribution: quicksketch commented 25 March 2012 at 22:10

@carl.ben: Have you set your site-wide timezone?

Comment #6

carl.ben CreditAttribution: carl.ben commented 26 March 2012 at 14:58

yes, it was set right after installation.

Comment #7

kevinsiji CreditAttribution: kevinsiji commented 18 April 2012 at 08:27

Site default timezone is set, as well as the submitting user timezone also. Submission is success. The error is displayed while viewing the submission.

Warning: date_timezone_set() expects parameter 2 to be DateTimeZone, boolean given in format_date() (line 1937 of /var/www/html/mendies/includes/common.inc).
This error is repeating for each date field.

Version: 7.x-3.17

Comment #8

quicksketch

he/him

CreditAttribution: quicksketch commented 13 May 2012 at 05:41

Status:

Active

» Postponed (maintainer needs more info)

I'm unable to reproduce this problem. If steps are provided to reproduce this problem from a fresh install I'll take another look.

Comment #9

quicksketch

he/him

CreditAttribution: quicksketch commented 17 February 2014 at 21:25

Issue summary:	View changes
Status:	Postponed (maintainer needs more info)	» Closed (won't fix)

We haven't had any confirming reports of this issue recently and I don't know how to reproduce the problem. Please reopen if this is still an issue and we have a way to reproduce it.