Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I was planning on working for an implementation for fullcalendar.
But this fails because my code depends on the beautytip js files and these get loaded AFTER my files, which leads to js errors.
You should use hook_library, create the library and than I can put a dependency on that library.
Deal? ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | beautytips_library_v2.patch | 14.83 KB | aspilicious |
| #2 | beautytips_library.diff | 1.56 KB | aspilicious |
Comments
Comment #1
kleinmp CreditAttribution: kleinmp commentedIt's a deal. When I get a chance, I'll do this but I'm also open to patches.
Comment #2
aspilicious CreditAttribution: aspilicious commentedHere is an untested patch (I think it should work but I can have made some typos)
Comment #3
aspilicious CreditAttribution: aspilicious commentedComment #4
aspilicious CreditAttribution: aspilicious commentedTested a bit, and isn't working somehow hook_librar doesn't get called :(
Comment #5
aspilicious CreditAttribution: aspilicious commentedThis is a first working step.
Only the IE stuff isn't working yet.
(This also contains the fixes needed to install beautytips in D7 without problems, see other issue)
Comment #6
aspilicious CreditAttribution: aspilicious commentedComment #7
xurizaemonCan you elaborate on "the IE stuff isn't working yet"?
I stopped being excited about IE when the ability to change frameborder colours wore off, but if this doesn't work for IE then it's still "Needs Work" IMO.
Comment #8
aspilicious CreditAttribution: aspilicious commented+ //for IE add this
+ $expath = $path . '/other_libs/excanvas_r3';
+ if (count(file_scan_directory($expath, '/excanvas.compiled.js/', $options = array('recurse' => FALSE)))) {
+ $jsPath = array($expath . '/excanvas.compiled.js' => array());
+ array_merge($javascript, $jsPath);
+ }
this doesn't work yet (I think, its been a while since I looked at this)
Comment #9
xurizaemonI think that code shouldn't use file_scan_directory with recurse and then assume the found file is at the top of the path?
This code adds the IE conditional tags for excanvas in D7. But I don't know how libraries module handles IE conditional tags, or if the excanvas reference should go in a separate library folder etc.
Comment #10
kleinmp CreditAttribution: kleinmp commentedI used the above patch, got the excanvas library loading, and committed this to the 7.x-2.x-dev branch. Please reopen if this does not work for you.
Comment #12
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedwhere do I place the excanvas folder now?
Comment #13
Adam S CreditAttribution: Adam S commentedI'm developing on Windows 7. Oh, joy! The file_exists() function doesn't work on Windows well. Doesn't the Libraries module have a mechanism to check this without using file_exists()? Also, for convention sake should the excanvas library be placed in sites/all/libraries for convention sake?
Comment #14
kleinmp CreditAttribution: kleinmp commentedThe libraries api module uses file_exists in a bunch of places and it's used all over the place elsewhere in Drupal. If we can identify what's causing the file_exists to fail in Windows, then we can probably make it work.
Right now, it's checking the file starting from the drupal root, but it could check from the root of the disk using DRUPAL_ROOT constant. I don't have a good way of checking if this works in Windows or not.
Yeah, the excanvas should go into sites/all/libraries. Both of these items should probably be separate issues.
Comment #15
hefox CreditAttribution: hefox commentedRe-open reason for this issue sounds like a new bug report, no?
Else there'd be no need for new issues, everyone would just re-open an the original feature request when they find any bug.
"needs work" with this issue title does not convey what the current is, at least.
Comment #16
pifagor