D7 has a class registry. There's no need to stuff test helpers in .inc files and try to include them. Just name them .test files and be done with it. This makes it way harder for everyone else to run tests.

CommentFileSizeAuthor
#4 1066822-test-include-cleanup.patch18.54 KBDave Reid
#1 1066822-test-include-cleanup.patch43.32 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
1066822-test-include-cleanup.patch43.32 KB
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Assigned: Unassigned » Dave Reid
pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented

Offtopic I know, but somebody oughtta extend the format of patch/diff to indicate a file rename as a single operation rather than a line-by-line removal from one name and addition to another.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
1066822-test-include-cleanup.patch18.54 KB

There you go. :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Committed to Git.
http://drupalcode.org/project/feeds.git/commit/98bacbd

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Committed to 6.x-1.x as well:
http://drupalcode.org/project/feeds.git/commit/976e8dd

twistor’s picture

twistor CreditAttribution: twistor commented

The last patch adds a few dpm calls to FeedsNodeProcessor.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.