CVS edit link for vasi1186

Hello,

My name is Vasi CHINDRIS and I am a Drupal developer for about 3 years. I recently developed a drupal module that is capable of sending invitations for organic groups via a mail. The idea of the module is to send hashed links (like the ones sent when the user has to confirm the account) and when the user will access those links he will be automatically logged in and subscribed into the group.
The idea of the module came to me when I developed an application where the users could invite other users to join their groups, but the links from the mail were something like: og/subscribe/node_id. Now, if the user that got the mail was not already logged in, he would get an access denied, or redirected to the user login page, then he had to login, and the he became a member of the group. This module skips the login process and subscribes the user automatically based on the special token from the link. So this module improves the usability of the subscribing process in the applications where organic groups are used.
The hashed link looks something like: group/node_id/join/user_id/1b110493dd0152f927d2883a1ba23f69 and the invitations can be sent from a url like: og/users/node_id/invite_user and it is shown as a tab near the "List" and "Add Members" tabs for an organic group.

CommentFileSizeAuthor
#1 og_invite_link.zip6.71 KBvasi1186
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vasi1186’s picture

Component: Miscellaneous » miscellaneous
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +invitation, +organic group
FileSize
6.71 KB

I attached the drupal 6 version of the module.

arianek’s picture

Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
apaderno’s picture

Component: miscellaneous » new project application
Issue tags: -invitation, -organic group
vasi1186’s picture

Project: Drupal.org CVS applications » Drupal.org security advisory coverage applications
Status: Postponed » Needs review

I created the experimental project for this module here: http://drupal.org/sandbox/vasi/1082946

I also pushed on git a first version of the module that can be reviewed.

Vasi.

a.ross’s picture

Status: Needs review » Needs work

Your code follows the coding standards relatively well. There are three exceptions I've spotted: control structures (a space before the opening curly brace), string concatenation (spaces before and after the concatenation operator) and spaces between commas, as in: array(1,3,4), which should be array(1, 3, 4).

Besides that, you seem to have a fairly good understanding of the Drupal API. I would only advise you not to make your lines exceed 80 chars too often.

vasi1186’s picture

Status: Needs work » Needs review

Hi,

thank you for your fast reply! I pushed into git the coding standards changes that you reported. I didn't change anything else. I will also consider your advice to not exceed more than 80 chars in my code lines too often.

a.ross’s picture

I'm sorry, I should have pointed you to the Code review module in the first place. This module will parse your code and will give you a lot of tips, especially regarding coding standards in Drupal. There are still ~50 warnings, mostly trailing spaces and still indentation.

Additionally, I have tested your module and it appears to work. I don't have experience with Organic Groups though, so maybe it's best if you ask someone in IRC #drupal-contribute who does have experience with OG to more thoroughly review your work.

a.ross’s picture

Status: Needs review » Needs work

But first you should correct those 50 warnings. Mind you, that if coder tells you about the CVS $Id$ tag, you should ignore that. The ID tag is not needed in GIT.

vasi1186’s picture

Status: Needs work » Needs review

I made a new push after inspecting the module files with the coder module.

Regarding the testing, I will also try to find some people that are willing to do that.

sreynen’s picture

Status: Needs review » Fixed

The sandbox project seems to be a full project now, so I'm changing the status:

http://drupal.org/project/og_invite_link

It would be good to add documentation of what happened to this issue.

vasi1186’s picture

ok, where should I write that documentation?

sreynen’s picture

@vasi1186, if you know how that sandbox project became a full project, I'd suggest documenting it in a comment here, so anyone looking back at this issue will know how it got fixed.

vasi1186’s picture

So, in the beginning, I created a sandbox project where I exposed the idea and uploaded a first version of the module for testing. I must say that during the testing and after receiving some feedback from the community, there were quite a lot of changes in the code. Special thanks to Mike (http://drupal.org/user/107190), he took care of making the sandbox project a full project (maybe he can describe more about the steps he did). So, in the end, the process was not so complicated: applying with a sandbox project, making some activity (some commits, ask interested people to test the module and give feedback, and so on), getting a full project, release some development snapshots and in the end a stable version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

apaderno’s picture

Component: new project application » distribution/profile
Issue summary: View changes
apaderno’s picture

Title: vasi1186 [vasi1186] » [D6] OG Invite Link
Component: distribution/profile » module