Add a option for use of imagecache when displaying a taxonomy image in forum list.

Taxonomy image have a such option but it effects all taxonomy images displayed all over the site, and sometimes you don't want that.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Scyther’s picture

This patch addes a select list for all imagecache presets on Advanced Forum settings page and uses it when displaying the taxanomy image in forum list.

Michelle’s picture

Thanks. I can't apply it right now because I've got a huge amount of uncommitted code I need to work thru first. But a quick visual review looks reasonable enough.

Assuming it works as advertised, I'll get it in before Alpha 4. If any problems arise, though, it'll be pushed to Alpha 5 because I am really hoping to get Alpha 4 out before DCC.

Michelle

__Sander__’s picture

FileSize
79.29 KB

Not exactly sure whether I am addressing the right issue.
Turning on taxonomy image and the corresponding option in AF makes the forum look weird.
For example, the table heading has one column less than the table raws
Please have a look at the screenshot

Shadlington’s picture

Sooooo... This is probably pushing to alpha 5 then?

Also, in the D7 version this would probably be quite different as terms are fieldable in core.

Michelle’s picture

Given how badly delayed Alpha 4 has been and the limited time I have for this module in the immediate future, this is going to have to wait, sorry. :(

Michelle

mcdruid’s picture

Status: Needs review » Closed (won't fix)

Scyther - sorry, this looks like a great idea, but AFAICS the patch doesn't apply to 6.x-2.x-dev any more.

As the priority is now shipping a 6.x-2.0 release, I'm having to de-prioritise 3rd-party module integration features; so as desirable as this is... I'm afraid I have to close it as "won't fix".

If you - or anyone else - are desperate to get this feature in, please reopen this issue with a patch that applies against 6.x-2.x-dev.

Scyther’s picture

Status: Closed (won't fix) » Needs review
FileSize
3.81 KB

I would like this to get into this module, so I am willing to help with this.

New patch attached that should work.

Michelle’s picture

@mcdruid: Just as an FYI, Scyther is one of the Author Pane maintainers. If this is something he wants, I would really appreciate it if we could make it happen. :) I love all you peeps who showed up to save my modules from my current life-chaos. :)

mcdruid’s picture

Michelle - your input is very welcome as always :-)

I'd definitely like to get this in, but didn't have time to resurrect the patch myself, so I'm grateful to you for looking at it again Scyther; thanks!

I'll try and get this tested and committed in the next few days, and intend to include it in the beta2.

mcdruid’s picture

Status: Needs review » Fixed

Thanks again Scyther - committed to 6.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.