First, big thanks for creating and open sourcing this feature. We'll be using it on one of our OA installs very soon.

I think there should be a test for Kit compliance. The following patch takes its queues from https://github.com/phase2/atrium_kit

CommentFileSizeAuthor
#1 1071272_ideation_kit_compliance_1.patch679 byteslangworthy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

langworthy’s picture

Status: Active » Needs review
FileSize
679 bytes

I believe this test is defined correctly but it will currently fail as votingapi is a dependency of fivestar and won't be enabled on drush -y en ideation.

langworthy’s picture

I was incorrect. votingapi enables successfully as per the test instructions.

langworthy’s picture

I wonder what the best practice is for placement of kit compliance tests.

irakli’s picture

I am a little confused.

You submitted a minimal drush make file which installs ideation module, but how is that test for Kit compliance?

irakli’s picture

Status: Needs review » Postponed (maintainer needs more info)
langworthy’s picture

Status: Postponed (maintainer needs more info) » Needs review

As outlined in the original post, the make file is modeled after https://github.com/phase2/atrium_kit which is a set of make files for testing atrium kit compliance. The make file I've included does the same for the Ideation feature.

Kit compliance means that the feature can run by itself with only its dependencies (ie: does not need to be installed in Open Atrium). This make file sets up an environment to test whether this is true.

langworthy’s picture

Title: Make file for testing Kit compliance » Test for Kit compliance of Ideation