Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
First, big thanks for creating and open sourcing this feature. We'll be using it on one of our OA installs very soon.
I think there should be a test for Kit compliance. The following patch takes its queues from https://github.com/phase2/atrium_kit
Comment | File | Size | Author |
---|---|---|---|
#1 | 1071272_ideation_kit_compliance_1.patch | 679 bytes | langworthy |
Comments
Comment #1
langworthy CreditAttribution: langworthy commentedI believe this test is defined correctly but it will currently fail as votingapi is a dependency of fivestar and won't be enabled on
drush -y en ideation
.Comment #2
langworthy CreditAttribution: langworthy commentedI was incorrect. votingapi enables successfully as per the test instructions.
Comment #3
langworthy CreditAttribution: langworthy commentedI wonder what the best practice is for placement of kit compliance tests.
Comment #4
irakli CreditAttribution: irakli commentedI am a little confused.
You submitted a minimal drush make file which installs ideation module, but how is that test for Kit compliance?
Comment #5
irakli CreditAttribution: irakli commentedComment #6
langworthy CreditAttribution: langworthy commentedAs outlined in the original post, the make file is modeled after https://github.com/phase2/atrium_kit which is a set of make files for testing atrium kit compliance. The make file I've included does the same for the Ideation feature.
Kit compliance means that the feature can run by itself with only its dependencies (ie: does not need to be installed in Open Atrium). This make file sets up an environment to test whether this is true.
Comment #7
langworthy CreditAttribution: langworthy commented