Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The module breaks "Add This" and "Administration menu" functionality, disabling labJs module fixes the "Add This" functionality but no solution for "Administration menu" here is a screenshot of broken menu :
http://img18.imageshack.us/img18/7143/sshot1imb.png
I am using Parallel module to load CSS and JS.
Comment | File | Size | Author |
---|---|---|---|
#12 | advagg-debug-1071368-12.patch | 1.4 KB | mikeytown2 |
#11 | advagg-support-labjs-1071368-11.patch | 1.63 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedhmmm didn't account for the parallel module... u thought about trying CDN? Did some quick tests on my local box and I can't repo the issues with admin menu & parallel.
labjs looks like another module I'll have to pull in as a sub module.
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedlabjs could use a script tag modifier; much like the unlimited css will need. Once I have a modifier in place I'll see if some kind of arrangement can be reached as the majority of this modules code is used in support of the labjs project and not hacking around D6 issues.
Comment #3
deepesh CreditAttribution: deepesh commentedIf it's not an issue with admin menu and/or parallel what could it be - I have disabled labjs on my site and the admin menu issue is still there ?
I also noticed that admin menu css and js are being loaded from a completely different directory :
http://img696.imageshack.us/i/sshot3qq.png/
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedThats a pretty odd bug. What does it look like when advagg is disabled?
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedOther JS loaders to be aware of
http://sotak.co.uk/blog/head-js-script-drupal
https://github.com/chriso/load.js
http://stevesouders.com/controljs/
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedlooks like labjs doesn't work with jquery update... but that can be fixed ;)
Code to check execution order of page hook:
Comment #7
deepesh CreditAttribution: deepesh commentedThis is how it looks when advagg is disabled :
http://img203.imageshack.us/i/sshot1jre.png/
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedWhat version of admin menu are you using? 1.x or 3.x
Also can you paste in the output from the above script? Paste output between < code > tags.
Comment #9
deepesh CreditAttribution: deepesh commentedI am using Administration menu 6.x-3.x-dev, where should I paste the above code ?
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedDrop the code into a new file call it test.php and run it. Copy the output and then delete the file.
I'm using the 1.x version of the admin menu; I'll test with the 3.x version soon then.
Comment #11
mikeytown2 CreditAttribution: mikeytown2 commentedCommitted this patch for labjs support. Keep labjs installed.
http://drupalcode.org/project/advagg.git/commitdiff/8c42039?hp=1bbc812b1...
Now off to admin_menu 3.x
Comment #12
mikeytown2 CreditAttribution: mikeytown2 commentedcan't repo with admin menu 3 installed... but with the gui in place you can enable debug mode and paste the output from that. Shows up in watchdog. Also paste in the hook theme info text box.
Committed this patch for the info box.
Comment #13
mikeytown2 CreditAttribution: mikeytown2 commentedthis should be fixed with the latest version