Make privatemsg_filter tags translatable [#1071470]

Title tells everything: please make the privatemsg tags translatable (provided by the privatemsg_filter submodule). It could be done with (an optional dependency on) i18nstrings.module, like other modules do.

Comment	File	Size	Author
#1	privatemsg-1071470-1.patch	3.91 KB	Boobaa
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Boobaa

he/him

CreditAttribution: Boobaa commented 24 February 2011 at 09:01

Status:

Active

» Needs work

File	Size
privatemsg-1071470-1.patch	3.91 KB

Attached is a patch against 1.3 that adds preliminary support for translatable tags. After applying it, one will be able to translate the tags. Anyway, there are still quite a bunch of things to do:
- display the translated tags (now only the original tags are displayed),
- make it possible to filter on translated tags (now the filter uses the tag name in the URL, which makes filtering on translated tags impossible),
- etc.

Comment #2

Berdir

German

Switzerland

CreditAttribution: Berdir commented 26 February 2011 at 13:32

Not exactly sure why they need to be translated, tags are something personal and aren't shared across multiple users.

+++ b/privatemsg_filter/privatemsg_filter.admin.inc
@@ -135,8 +135,13 @@ function privatemsg_tags_form_submit($form, &$form_state) {
+    $form_state['values']['tag_id'] = db_last_insert_id('pm_tags', 'tag_id');

Why not simply save it as $tag_id? At least it shouldn't be inside values imho.

Powered by Dreditor.

Comment #3

Boobaa

he/him

CreditAttribution: Boobaa commented 28 February 2011 at 06:32

Because the original string needs to be updated when it's edited, and this use case is handled by this very same code, too. (The original code without the patch handled it this way, too.)

Comment #4

oadaeh CreditAttribution: oadaeh as a volunteer commented 26 July 2016 at 14:41

Issue summary:	View changes
Status:	Needs work	» Closed (won't fix)

This issue is being closed because it is against a branch for a version of Drupal that is no longer supported.
If you feel that this issue is still valid, feel free to re-open and update it (and any possible patch) to work with the 7.x-1.x branch (bug fixes only) or the 7.x-2.x branch.
Thank you.