Implement CTools exportables and export UI [#1073026]

Comment	File	Size	Author
#11	wordfilter-exportability-1073026-11.patch	31.79 KB	q0rban

#9	wordfilter-exportables-1073026-9.patch	29.68 KB	q0rban

#4	wordfilter-1073026-4.patch	16.59 KB	q0rban

#3	wordfilter-1073026-3.patch	16.27 KB	q0rban

#2	wordfilter-1073026-2.patch	16.4 KB	q0rban

#1	wordfilter-1073026-1.patch	16.4 KB	q0rban

Comment #1

q0rban CreditAttribution: q0rban commented 25 February 2011 at 20:47

Status:

Active

» Needs review

File	Size
wordfilter-1073026-1.patch	16.4 KB

Patch attached. I'm not sure how helpful this is though, as I'm thinking people would probably rather export a whole language, not individual words. Not sure the best way to implement that yet though.

Log in or register to post comments

Comment #2

q0rban CreditAttribution: q0rban commented 25 February 2011 at 21:01

File	Size
wordfilter-1073026-2.patch	16.4 KB

Log in or register to post comments

Comment #3

q0rban CreditAttribution: q0rban commented 25 February 2011 at 21:02

File	Size
wordfilter-1073026-3.patch	16.27 KB

Darn, accidentally uploaded the same file. ;)

Log in or register to post comments

Comment #4

q0rban CreditAttribution: q0rban commented 25 February 2011 at 21:55

File	Size
wordfilter-1073026-4.patch	16.59 KB

Added support for disabled items.

Log in or register to post comments

Comment #5

csevb10 CreditAttribution: csevb10 commented 26 February 2011 at 01:52

Ok. I admit that I made your life (or mine) a little more difficult, but now that I've separated out admin functionality into a separate file, getting your patch to apply to the latest code might be harder than just writing it from scratch. :-/ If you can re-roll a patch based on the re-work of the code that I did, I would love to add exportable functionality.
Regardless, this functionality is definitely on my list of features to develop moving forward, so if you don't have time, I will get to this as soon as time allows.

Log in or register to post comments

Comment #6

q0rban CreditAttribution: q0rban commented 26 February 2011 at 21:53

Hmm, I was working off of the latest in the 7 branch when I made my patch. Is there a separate branch I should be working from?

Log in or register to post comments

Comment #7

csevb10 CreditAttribution: csevb10 commented 24 March 2011 at 20:32

You did everything correctly, I just happened to be making changes at the exact same time to a lot of the same code, so pulling all of your changes into what I did became very difficult. Does that make sense? If you can roll off the current d7 branch, it'll just make life easier, otherwise, I'll get to this myself as soon as I can.

Log in or register to post comments

Comment #8

q0rban CreditAttribution: q0rban commented 21 April 2011 at 13:12

Assigned:	Unassigned	» q0rban
Status:	Needs review	» Needs work

Ok, I'm going to try to re-roll this patch, and also make it exportable by language. This will mean I'll have to increase the language support a bit.

Log in or register to post comments

Comment #9

q0rban CreditAttribution: q0rban commented 21 April 2011 at 15:38

Status:

Needs work

» Needs review

File	Size
wordfilter-exportables-1073026-9.patch	29.68 KB

Here's a new patch, made with git format-patch. The language stuff is in a separate commit, so if you don't want that to be included with this work, you can separate it out, and we can create a new issue for that (or post to the existing one for 6: #265565: Multilanguage support (at least for 6.x)).

To apply this patch:

git checkout 6a6a8bb1f6158b1238e51fb94686e2a93fbec360
git checkout -b wordfilter-exportables
git am wordfilter-exportables-1073026-9.patch
# If you don't want the language commit, run this:
#git reset HEAD~1 --hard
# Otherwise, proceed with merging this into development.
git checkout 7.x-1.x
git merge wordfilter-exportables --no-ff

Log in or register to post comments

Comment #10

q0rban CreditAttribution: q0rban commented 21 April 2011 at 16:04

Actually, the language portion is going to need work, as caching needs to be updated to be on a per language level.

Log in or register to post comments

Comment #11

q0rban CreditAttribution: q0rban commented 21 April 2011 at 19:21

File	Size
wordfilter-exportability-1073026-11.patch	31.79 KB

Updated patch to fix caching as mentioned in #10. It will be harder to separate out the language stuff from this patch, so let me know if you need a hand with that.