Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It would be useful if we could load all coupon objects associated with an order.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | uc_coupon_purchase_oid-1077554.patch | 3.55 KB | ezra-g |
Comments
Comment #1
ezra-g CreditAttribution: ezra-g commentedI'd like to be able to list coupons purchased with a specific order, rather than all coupons purchased by a specific user across order.
Currently, we don't store the oid of the order where the coupon was purchased.
This patch adds an oid column to {uc_coupon_purchase_users} and stores the order id when the coupon is created, and an API function to load coupons associated with an order.
Comment #2
ezra-g CreditAttribution: ezra-g commentedComment #3
ezra-g CreditAttribution: ezra-g commentedWe need to add this to the initial schema for fresh installations.
Comment #4
wodenx CreditAttribution: wodenx commentedSorry for long delay in responding to this.
At a quick glance, it looks like there needs to be a check on whether the order_id is null - or need to remove not_null from the schema.
Otherwise looks ok to me.
@longwave - what do you think?
Comment #5
longwaveI agree not_null might need to be removed - this would also allow it to cope with any rows that already exist in the table. The new API function needs better documentation as well. Otherwise it looks okay.
@ezra-g: isn't hook_schema() and hook_install() enough to do that?
Comment #6
longwaveActually, setting 'not null' = TRUE and 'default' = 0 should be enough here.