Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I am just trying resolve a random bug so decided to run some modules through the Coder module to eliminate that as a possible issue. Saw few issues with the D7 version that would be great to get into an upcoming release.
Comment | File | Size | Author |
---|---|---|---|
#5 | run_through_coder-1078778-5.patch | 6.28 KB | idflood |
Comments
Comment #1
febbraro CreditAttribution: febbraro commentedDid a first quick pass. Need to investigate some of the FAPI stuff.
http://drupalcode.org/project/context.git/commit/fcaf202
Comment #2
mgiffordCool, thanks! There are a number of changes in FAPI for sure in D7.
Comment #3
febbraro CreditAttribution: febbraro commentedThe coder messages are a bit weird with respect to FAPI #title and #description. It keeps saying:
and
What the heck is c(), d() or f()?
Comment #4
mgiffordIt's definitely a cryptic message. Certainly for critical errors coder should be really clear and point to a url with more info.
Have you asked in the Coder issue queue?
Comment #5
idflood CreditAttribution: idflood commentedThe coder error message seems to be related to this issue: http://drupal.org/node/912490 . So make sure to use the 7.x-1.x-dev version of coder, these errors are now something like:
Line 45: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
Here is a first pass. There are still a lot of @file blocks missing (http://drupal.org/node/1354#files) and some other issues. I also added a t() function and changed some.
Comment #6
mgiffordSorry, doesn't apply against 7.x-3.x:
$ git apply run_through_coder-1078778-5.patch
error: patch failed: plugins/context_reaction_block.inc:42
error: plugins/context_reaction_block.inc: patch does not apply
Comment #7
kenorb CreditAttribution: kenorb commentedPatch doesn't apply.
I've also these onces when checking (drush --contrib --no-empty --upgrade7x coder-review):
Comment #8
kenorb CreditAttribution: kenorb commented