There are a bunch of issues that come up in Coder. I can make a patch to resolve them, but just wanted to check in with you first Jeff.

CommentFileSizeAuthor
#4 coder-1078874-4.patch30.98 KBmgifford
#2 coder-1078874-2.patch10.48 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

A patch would be very nice, I havent run it through coder at all :)

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
coder-1078874-2.patch10.48 KB

This seems to work. There are some outstanding issues with how the Coder module deals with themes though.

Edit: I might need to remove the IDs if they are no longer required with Git. Not sure.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented 
+++ b/genesis/templates/user-profile-category.tpl.php
@@ -1,3 +1,11 @@
+// $Id$

Yeah, these are not needed by Git, during the migration they were all stripped.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
coder-1078874-4.patch30.98 KB

Ok, here's the new patch without the CVS stuff.

Another interesting thing is that Coder really has no way of knowing to treat these as templates:
gpanels/2col-33-66.php

Normally it would be something like:
gpanels/2col-33-66.tpl.php

and I assume Coder would know to not worry about stuff like endif; .

None of this stuff was at all important programatically, but it's nice to be closer to a standard that can be easily reviewed.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Active » Reviewed & tested by the community

Applied cleanly, good stuff Mike, looks great.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Glad to help make an incremental improvement in this great theme.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

When can this be brought into the dev release? I'd like to mark this as fixed.

I also think that the Coder review to add:
+// $Id$

Should probably be taken out as that's for the old CVS.

If we can bring this into Genesis for the 7.2 then I can quickly re-roll this patch to remove those.