Fix PHP Notices [#1079064]

The attached patch fixes this.

Comment	File	Size	Author
#3	imagecache_profiles.module.patch	1000 bytes	joelstein
#2	1079064-notice.patch	971 bytes	andypost
#1	imagecache_profiles.module.patch	986 bytes	joelstein
	imagecache_profiles.module.patch	592 bytes	joelstein

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joelstein CreditAttribution: joelstein commented 2 March 2011 at 20:12

Title:

Notice: Undefined variable: size in imagecache_profiles_preprocess_user_picture()

» Fix PHP Notices

File	Size
imagecache_profiles.module.patch	986 bytes

I found another bug in imagecache_profiles_form_user_profile_form_alter(). It needs to check if the 'picture' form item is present, which is won't be if editing one of the profile category forms.

The patch has been updated to fix this.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost commented 2 March 2011 at 20:43

Version:

6.x-1.3

» 6.x-1.x-dev

File	Size
1079064-notice.patch	971 bytes

Please, provide a patch against current code from 6.x-1.x git branch...

+++ (clipboard)undefined
@@ -65,7 +65,9 @@
-      $preset = is_numeric($size) ? imagecache_preset($size) : imagecache_preset_by_name($size);
+      if (isset($size)) {
+        $preset = is_numeric($size) ? imagecache_preset($size) : imagecache_preset_by_name($size);
+      }

There's no such code in 6.x-1.x branch. $size was changed to $preset and I'm not sure that logic is correct...

Suppose it's better to add !empty($preset) for previous if statement.

+++ (clipboard)undefined
@@ -221,6 +223,9 @@
+  if (!isset($form['picture'])) {
+    return;
+  }

Any reason to check for this key?

Powered by Dreditor.

Comment #3

joelstein CreditAttribution: joelstein commented 2 March 2011 at 21:22

File	Size
imagecache_profiles.module.patch	1000 bytes

Please, provide a patch against current code from 6.x-1.x git branch...

Sorry. I updated the patch. The problem still exists, and this patch fixes it.

Any reason to check for this key?

Yes, because your code depends on the 'picture' form item being present, which it won't be if editing one of the profile category forms (if Profile is installed).