How about private filesystem? [#1081648]

Comment	File	Size	Author
#9	advagg-private-1081648-9-D6.patch	1.86 KB	mikeytown2

#8	advagg-private-1081648-8.patch	1.01 KB	mikeytown2

#7	advagg-private-1081648-7.patch	712 bytes	mikeytown2

#4	advagg-1081648-4.patch	8.95 KB	mikeytown2

#3	advagg-private-1081648-3.patch	23.58 KB	mikeytown2

#3	advagg-private-1081648-3.patch	23.58 KB	mikeytown2

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 4 March 2011 at 19:12

Category:	support	» feature
Priority:	Normal	» Major

It could be made to work. Good idea.

Log in or register to post comments

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 4 March 2011 at 19:19

@HLopes
I've never dealt with Drupal's private file system. Does it use htaccess rules to limit access to the files directory?

Log in or register to post comments

Comment #3

mikeytown2 CreditAttribution: mikeytown2 commented 5 March 2011 at 02:04

Status:

Active

» Fixed

File	Size
advagg-private-1081648-3.patch	23.58 KB

advagg-private-1081648-3.patch	23.58 KB

Private file system workaround added in. You need to create a writable directory in your webroot. If you have the cache folder from boost, you can use that.

This is the patch that was applied.

Log in or register to post comments

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 9 March 2011 at 02:01

File	Size
advagg-1081648-4.patch	8.95 KB

did another change in regards to the private file system. This patch has been committed.

Log in or register to post comments

Comment #5

23 March 2011 at 02:01

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #6

HLopes CreditAttribution: HLopes commented 30 March 2011 at 11:59

Works like a charm... Had some issues to install it properly, but it boiled down to a missing variable in page.tpl.php.

You could also add functionality to create the necessary folders at advagg.admin.inc, around line 299, if folders don't exist.

$path_arr = explode('/',$files_dir);
$cumulative = array_shift($path_arr);

foreach($path_arr as $k => $v){
  file_check_directory($cumulative,1,NULL);
  $cumulative .= '/'.$v;
}

Something like that....

Log in or register to post comments

Comment #7

mikeytown2 CreditAttribution: mikeytown2 commented 30 March 2011 at 18:01

Status:

Closed (fixed)

» Needs review

File	Size
advagg-private-1081648-7.patch	712 bytes

mind testing this patch?


        // Create Dirs
        foreach (advagg_get_root_files_dir() as $full_dir) {
          $path_array = explode('/', $full_dir);
          $cumulative = array_shift($path_array);
          foreach ($path_array as $dir) {
            file_check_directory($cumulative, 1);
            $cumulative .= '/' . $dir;
          }
        }