I have made some changes to that way the theme is generated. I am using image_formatter theme function to display the thumbnails and the image_style_url to give you the link to the styled zoomed image.

Let me know what you think, but I think this will fix both using the imagestyles and the public/private path issues.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gopherspidey’s picture

Title: Paths fixes and simplified themeing » Public/private paths and using the image styles
jackhutton’s picture

the patch looks great.. admittedly, i'm a bit green w. applying patches..
using cygwin..
i navigated to the galleria directory; the patch file is there as well
ran patch -p0 --dry-run < 0001-public-private-and-themeing.patch

then consistently get an error :
;cant find file at line 19 ..
perhaps you used the wrong -p or --strip option
then it lists out the lines of code leading up to line 19..

diff --git a/galleria-container.tpl.php b/galleria-container.tpl.php
index 5a416ea..54bbf7a 100644
--- a/galleria-container.tpl.php
+++ b/galleria-container.tpl.php

so . it looks super promising.. can you help a 'greenhorn' move a step forward there..
thanks for your input..

jack

jackhutton’s picture

I applied your patch manually and it works. ..reading from image cached values..
thanks alot for doing this.. !!!

gopherspidey’s picture

I am glad I could help. Sorry about being a bad patch file, I am still learning git.

jackhutton’s picture

dunno if it was a 'bad' patch file or 'user error' on my part... i'm not well versed in applying patches.
but the lines of code you modified/ added are nothing short of GREAT...so thank you..
now.
if you have any ideas as to how I can integrate their 'twelve' theme.. into the module.. :)

thanks again.

jackhutton’s picture

Had success applying the 'twelve' theme.. posted the steps here:
after using the patch in comment #9 and lots of head scratching..

http://drupal.org/node/802206#comment-4231154

gopherspidey’s picture

Fyi,

I found a bug in the above patch. It is when you do not have the image style set. I am looking at fixing it, but I do not have a complete solution yet.

Until I find a fix, make sure the you set both the thumb and the zoom style.

gopherspidey’s picture

FileSize
8.72 KB

Ok that did not take me long. I was not checking to see if the image style existed.

eggonbeagle: There is some incomplete code in the module for choosing the theme. If I have time I will work at the Javascript and theme changing code.

Also I think this patch will apply clean. There was junk on the patch from git at the top.

osopolar’s picture

The patch works so far for me. It is still not like the demo under http://galleria.aino.se/ but before the images didn't show up.

BTW: after applying the patch don't forget to clear the theme cache.

edit: Now I saw that there are different themes available.

jackhutton’s picture

-- applying those different themes isn't straightforward.
I worked through this but have it bombing in IE right now.

thanks gopherspidey for looking into the theme..

dcal’s picture

Hello,

please how to use this patch
I'm looking for several days but have not found any solution how to use it.

1 - My pictures are not displayed in my module (Galleria Classic)

2 - Then I want to get to install the theme Galleria Twelve

thank you for your help, I'm a beginner.

dcal’s picture

Hello,

I managed to apply the patch manually
(the second patch of post # 8 of 21 March)
following the procedure Eggonbeagle whom I thank.

Everything works fine in Drupal 7 to the Classic theme like this:
http://galleria.aino.se/themes/classic/

I then bought the theme Twelve:
http://galleria.aino.se/themes/twelve/

It works by placing the theme as indicated on the Aino's website and changing the line of the file galleria.module:
drupal_add_js ($ path '. / js / themes / classic / galleria.classic.js');
by
drupal_add_js ($ path '. / js / themes / twelve / galleria.twelve.min.js');

But I have a problem.
With theTwelve theme When i want to choose an image from the thumbnails that appear with the icon on bottom left of the bar Galleria Twelve:
the overlay that is displayed and includes the thumbnails do not go down automatically after i click on any image, it must descend in to click on its icon and i can see after the new image that is displayed correctly.

Another problem is when i use the fullscreen mode by clicking on the icon at the bottom right, i can't return to normal mode, i must refresh the page to get there.

jackhutton’s picture

i think i had some of those issues.. and cannot recall exactly what ; but i think updating some of the .js files included in the module addressed that.. i reviewed the support forum at the galleria site.. ; I'll see if i can track down some of what i did there.

I still need to resolve the issue w. IE 8..
lets keep on this.. I'd like to use this module. (wish the developers were more supportive..esp. considering we've purchased their addtional themes )

domineaux’s picture

I use this module consistently on D6 sites. It is very easy to use, and the best part you include an array of images in one node.
The array can be re-sequenced from edit screen. I also like it because site users have to click on thumbnails or large rendered image to view. Hoverovers with mouse are a pain, because when users are on slow connections they become frustrated and leave the site.

In D6 you can work with images thru image module or CCK, or both. You can make your own best fit for features.

I particularly like it because you can give your site owner the permissions to create and edit his own albums, even though you maintain the website. This saves alot of time and aggravation, because the site owner can display the pictures they way he wants and isn't constanly telling you to move this or delete that,etc.

IMO, this is one of the best modules for Drupal. This is one of the major modules for my sites. I have tried other choices, but this is a first best choice for me. I haven't moved any sites to D7, until a few of the better modules like this one are ported over.

I love the Galleria

dcal’s picture

I managed to use the Classic theme but also the theme Twelve
that does not work correctly with the file 'jquery.galleria.js'
that is included in the archive module Drupal Galleria (7.x-1.x-dev)
(Galleria v 1.2 2010-11-23 1.1 prerelease)

I actually forgot to replace his latest 'galleria-1.2.3.min.js'
available here:
http://galleria.aino.se/download/
(Galleria v 1.2.3 2011-04-14)

Thank you to the developers of Drupal
developers Galleria
developers of the module for Drupal 7,
to gopherspidey for the patch
and eggonbeagle for having indicated the procedure to follow to use the Module Twelve and show us the result
(I can't even do the same, my tests are still only locally).

jackhutton’s picture

dcal.. have you tested the Twelve themed galleria in IE?

DrupOn’s picture

Status: Needs review » Fixed

gopherspidey's patch from post #8 is now applied. It works without any problems. The entire module folder and module file look now much cleaner. Thanks for the patch, I appreciate the help.

gopherspidey’s picture

Status: Fixed » Needs work

Something when you applied the patch. It did not remove some files.
You still have galleria.theme.inc and galleria-insert-image.tpl.php in the git repo.

You can just delete those files from git

DrupOn’s picture

My bad, forgot to clean up my local repository. i will clean that up and apply some other changes in the next commit.

kroimon’s picture

Status: Needs work » Closed (fixed)

I just tested using private image upload with the latest version and it works like a charm, so I removed the warning from README.txt and close this issue.