"User picture preset" image style not respected [#1084520]

I realise the D7 version isn't 'officially' supported yet, but I am posting this in the hope that Troky sees it anyway
Right... First off, the D7 version seems to be coming along really well! Nice work!

There's one or two minor issues though.
One issue could possibly be a theme problem so I will leave that for now till I've looked into it more (essentially some of the buttons look a little odd around the edges).

The other issue however is pretty clear though: user images in topics are not respecting the "User picture preset" image style selected in the AF config. Instead, the "Picture display style" defined in account settings is used.

Note: I am using AF by itself - I haven't tried this with AP.

Comment	File	Size	Author
#3	advforumscreeny.jpg	90.26 KB	Shadlington
#4	advforumbroke.jpg	25.07 KB	Shadlington

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

troky CreditAttribution: troky commented 9 March 2011 at 10:47

Can you send a screenshot of odd buttons?

"User picture preset" setting is used only with AP enabled. I can't see any user pictures with AP disabled.

Comment #2

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 12:01

I'll get the screenshot later on. I would have gone into more detail but I had intended to create a separate issue for the buttons when I got round to looking at it again - just wanted a note for myself really.

As for the user picture preset - I haven't even downloaded AP and I definitely see user pictures (possibly because of the 'User pictures in posts' option in the theme settings? I'll have to test this later on)
They appear in the correct place (I think) in the section on the left of posts so I assumed that was intended.
I'll include a screenshot of this too.

Also, I suppose if the 'user picture preset' option is specific to AP then it probably shouldn't be available if you don't have AP.

EDIT: Tested - the display of the pictures has nothing to do with the 'User pictures in posts' theme setting - it shows regardless.

Comment #3

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 13:19

File	Size
advforumscreeny.jpg	90.26 KB

Got round to it sooner than expected.

The button issue really is minor, it just stuck out as not looking quite right.
There's this visible squared off corner behind the curved corner on some of them.

Oh and I'm using chrome by the way, in case that matters.

Comment #4

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 11:57

File	Size
advforumbroke.jpg	25.07 KB

Huh.
I wanted to see whether having AP would make any difference so I installed the latest dev of it.
It doesn't work at all - the theme gets completely dropped and the forum page just displays as basic text (and on non-forums that the block is enabled for it gives WSOD).

I don't think I'm explaining well enough so I've attached a screenshot.

Comment #5

troky CreditAttribution: troky commented 9 March 2011 at 13:17

Css glitch with button will be solved in next commit.

Rendering user picture without AP is done in core user.module and there is not much I can do about it.
I'll try to install latest AP-dev and check for errors.

Comment #6

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 20:22

I found out that both of my issues with AP are related to the user picture preset options!

The WSOD I was getting was actually because I had set the user picture preset to something other than blank for the AP block - I raised an issue for this over at AP: #1086254: WSOD when user picture preset assigned

Following the same path I cleared the user picture preset in my AF settings too (the setting this issue is concerning) and the problem I was having with AF + AP went away too!

Comment #7

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 20:30

I've figured out what's going on... Its the default user picture that's the problem!
All these problems were only happening when showing a post by someone with only the default user picture.
If I don't set a user picture preset there's no problem.
If I go to a post by a user that has uploaded their own picture there's no problem.
If I disable the default picture there's no problem.

So it seems there is this one specific case where things break down: default picture + preset applied.

Comment #8

troky CreditAttribution: troky commented 9 March 2011 at 20:50

So, are you suggesting this is AP issue? I am trying to reproduce error unsuccessfully.

Comment #9

Shadlington CreditAttribution: Shadlington commented 9 March 2011 at 21:00

I'm inclined to believe it is. I'm not sure though.
In order for me to reproduce this I need to:
a) Be using AF + AP
b) Have a default user picture set in account settings (admin/config/people/accounts)
c) Have assigned an image preset in the AF settings page (admin/config/content/advanced-forum)
d) View a forum topic by someone whom is showing the default picture (i.e. someone that hasn't uploaded their own picture)

If all of those conditions are satisfied I get the error.

Comment #10

troky CreditAttribution: troky commented 9 March 2011 at 22:16

Well, I tried and everything seems to be fine. No errors at all.

Do you have clean D7 install or upgraded from D6?

Comment #11

Shadlington CreditAttribution: Shadlington commented 10 March 2011 at 00:17

Clean install. Weird. I'm not sure what else to tell you - there must be something else.

EDIT: Uh. I think it might have something to do with the way the default picture is pathed? Searching through old D7 core issues showed that at some point there was an issue a bit like this that is meant to be fixed now.

Can I ask what path for the default picture is that you are entering in account settings?
Mine was 'sites/default/files/default-picture.png'.

However, I just changed it to 'public://default-picture.png' and I stopped getting the errors I was getting.
The default image is being displayed correctly (with the correct image style, even) but the path the image links to is wrong! Its linking to: http://example.com/http://example.com/, which is odd.

Finally, with the setup like this, if I then go to a non-forum node with the AP block enabled, I get the same bad linking as well as the message: "Notice: Trying to get property of non-object in include() (line 25 of /var/www/sites/all/modules/author_pane/author-pane-user-picture.tpl.php)."

So... I guess this is an AP issue! Sorry for taking up your time like this.