When attempting to print a Coder page, the 

 tags do not wrap and run off the screen. This should wrap _only_ on print, using the print CSS media type.
CommentFileSizeAuthor
#1 add-print-css-1094606-1.patch1.11 KBerikwebb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Needs review
FileSize
add-print-css-1094606-1.patch1.11 KB

Patch adds coder.print.css with style to reformat 

 tags to include wrap. drupal_add_css() used to add this CSS file to the "print" media type.
cashwilliams’s picture

cashwilliams CreditAttribution: cashwilliams commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Patch still applies to 6.x-2.x branch.

douggreen’s picture

douggreen CreditAttribution: douggreen commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Assigned: Unassigned » douggreen
douggreen’s picture

douggreen CreditAttribution: douggreen commented
Status: Reviewed & tested by the community » Needs work

I tried updating this to the #attached syntax, and printed before and after, and saw no difference. Maybe I have the #attached wrong. Or maybe chrome is handling this for me already. Can you update this in the 7.x-2.x branch ... and provide a step-by-step test case.

I tried:

+ $form['#attached']['css'][] = array("$path/coder_review.print.css" => array('media' => 'print'));

See

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

Coder 7.x is frozen now and will not receive updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.