This is probably related to #329412: enable muliple Sending Methods; also - there is a patch in messaging that is necessary for this to work #309461: Multiple Send methods.

This patch aims to add support to notifications methods to allow a user object to pass multiple messaging endpoints, such that multiple subscriptions are added at that point in time. Clearly the notifications framework supports multiple subscriptions to different messaging endpoints. The thought here is to take it a step further and allow a user to add *default* multiple selections and have notifications add those default as subscriptions on a notification add.

CommentFileSizeAuthor
#13 multiple_endpoint_support-1101806-13.D6.patch5.47 KBchristianchristensen
#12 multiple_endpoint_support-1101806-12.D6.patch5.45 KBchristianchristensen
#11 multiple_endpoint_support-1101806-11.D6.patch6.79 KBtravist
#10 multiple_endpoint_support-1101806-10.D6.patch9.94 KBtravist
#9 multiple_endpoint_support-1101806-9.D6.patch9.94 KBtravist
#8 multiple_endpoint_support-1101806-8.D6.patch7.91 KBtravist
#7 multiple_endpoint_support-1101806-7.D6.patch4.73 KBpdrake
#6 multiple_endpoint_support-1101806-6.D6.patch4.72 KBpdrake
#4 multiple_endpoint_support-1101806-4.make_.patch4.7 KBtravist
#3 multiple_endpoint_support-1101806-2.make_.patch5.53 KBchristianchristensen
#2 multiple_endpoint_support-1101806-2.make_.patch5.51 KBchristianchristensen
#1 multiple_endpoint_support-1101806-2.patch6.93 KBchristianchristensen
multiple_endpoint_support-1.patch0 byteschristianchristensen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented
FileSize
multiple_endpoint_support-1101806-2.patch6.93 KB

Patch correction...

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented
FileSize
multiple_endpoint_support-1101806-2.make_.patch5.51 KB

Patchfile for drush make.

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented
FileSize
multiple_endpoint_support-1101806-2.make_.patch5.53 KB

Another quick update - include an array_filter on the provided defaults to filter out the non-defaults.

travist’s picture

travist CreditAttribution: travist commented
FileSize
multiple_endpoint_support-1101806-4.make_.patch4.7 KB

Found an issue with the patch above. It is possible to fall into an infinite function recursion if the user does not have a send_method already defined in their settings. This patch is better.

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented

Nice catch travist! That patch is indeed better (but, I think it still provides the flexibility to messaging is now able to ease into multiple endpoints)

pdrake’s picture

pdrake CreditAttribution: pdrake commented
FileSize
multiple_endpoint_support-1101806-6.D6.patch4.72 KB

Fixed a couple of logic errors. See attached. Thanks for the help on this travist.

pdrake’s picture

pdrake CreditAttribution: pdrake commented
FileSize
multiple_endpoint_support-1101806-7.D6.patch4.73 KB

Slightly fixed version of the above patch.

travist’s picture

travist CreditAttribution: travist commented
FileSize
multiple_endpoint_support-1101806-8.D6.patch7.91 KB

Had to pull in the patch from #1075862: Notifications queuing adds a lot of time to node/comment inserts into this because it was causing a conflict. Here is a re-roll with that patch included.

travist’s picture

travist CreditAttribution: travist commented
FileSize
multiple_endpoint_support-1101806-9.D6.patch9.94 KB

Apparently, a previous patch removed a portion of the original. Here is the updated patch.

travist’s picture

travist CreditAttribution: travist commented
FileSize
multiple_endpoint_support-1101806-10.D6.patch9.94 KB

Changed a variable to control the queue immediate flag.

travist’s picture

travist CreditAttribution: travist commented
FileSize
multiple_endpoint_support-1101806-11.D6.patch6.79 KB

Changed this patch back to the original by removing the reference to #1075862: Notifications queuing adds a lot of time to node/comment inserts since it really doesn't apply here.

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented
FileSize
multiple_endpoint_support-1101806-12.D6.patch5.45 KB

Updated this patch to be cognizant of notification_lite enqueue options with multiple send methods.

christianchristensen’s picture

christianchristensen CreditAttribution: christianchristensen commented
FileSize
multiple_endpoint_support-1101806-13.D6.patch5.47 KB

Clean up whitespace diff