Hi
It would be nice to see a consistent use of the Portable Network Graphics image format for the supporting images of the Zen theme, where this is now a mix of png and gif, the Graphics Interchange Format.

CommentFileSizeAuthor
#10 cog_0.png1.21 KBrport
#9 cog_IE.png1.83 KBkdebaas
#8 cog.png764 bytesrport
#7 cog_browsercomparison.png2.51 KBkdebaas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jjeff’s picture

Good point.

rport’s picture

Assigned: Unassigned » rport
Status: Active » Needs review

kdebaas, jjeff,

I have created a zip of the updated files to resolve this issue for review. This includes all of the relevant .png files with two patch files for icons.css and style.css.

I have also included patched versions of icons.css and style.css.

I've tested this on my own test server and everything seems to work ok.

Over to you for testing and final committ.

rport

zirafa’s picture

The reason gif was used for some images was because of the headache with IE and its lack of support for PNG transparency. I'm pretty sure going all PNG will introduce this problem, unless we give the PNG solid background colors.

jjeff’s picture

Awesome! Thanks.

I will review this today and try to get it committed soon.

-jeff

jjeff’s picture

I will also test in IE. I believe that we're okay if we use 8-bit PNGs (with binary transparency) rather than 24-bit (with an alpha channel), but the proof is in the pudding. If this breaks things for IE, we'll roll it back.

m3avrck’s picture

PNGs still work in IE.

The problem arises when those PNGs use alpha transparency, they should still work well at the 8bit level.

+1 for consistency if it doesn't break anything :)

kdebaas’s picture

FileSize
2.51 KB

I didn't apply the patches, but instead replaced the appropriate files in the zen theme folder. I tested the theme against IE6 on windows, and tried out different background colors for #page and body. I don't have a forum, so I haven't actually looked at all the images in action, but what I have seen works.

Peering closer at these little icons made me realize something else though: the cog image for the administration panels doesn't have a transparent background. Instead, it uses the same color background as .admin-panel h3. In IE, this color is rendered in a slightly different hue, framing the cog inside a little blue box. Compare results in the attached picture of a piece of the screen, grabbed from Firefox (left) and IE (right).

rport’s picture

FileSize
764 bytes

I have updated the cog image (see attached) this should address the transparency issue.

I have also edited most of the other images in the zen-theme set. The complete set can be found here. Perhaps this might go some way to resolving the issue: Icons should be 'color-neutral', however, I've not adjusted the .css files to match the grey images.

Hope this helps.

rport

kdebaas’s picture

FileSize
1.83 KB

Unfortunately, the cog transparency doesn't seem to work in IE. Strange, because the images for menu-expanded etc retain their transparency in IE. See attached screenshot.

I welcome your efforts towards a more color-neutral set of icons. Maybe economizing on the use of images in css could go some way to solve that? Of course, my perspective on this is somewhat colored by my agenda: I am looking for a clean and healthy theme to use as the basis for personal customizations. And I would therefore naturally lean towards sacrificing all that makes Zen look good at first sight, for a more sparse base to start out from.

rport’s picture

FileSize
1.21 KB

Hi kdebaas,
Here is a new 16x16 'Cog' attached.
I've tested the transparency with FF2 & IE6 and.... It Works...
Give this little baby a go.
~ rport

kdebaas’s picture

rport - you're the best! It works. Any ideas why the previous cog.png didn't preserve its transparency? I couldn't figure that out.

suzanne.aldrich’s picture

Version: 5.x-0.6 » 5.x-1.x-dev

I'm making a new subtheme (mostly just flipping the background to black and overriding all the colors) at http://www.gogoray.net and I wanted a color neutral icon set that will work with a black background and use the png format. First I tried putting the png images in a subdir of my subtheme and using css in overrides, which worked pretty well except I had to use a couple of list-style: none; statements so there weren't extra bullets next to various of <li></li> tags. But then after awhile I kept noticing it was loading zen's original images before loading mine, and that's just inefficient for every page-load, so I just went and replaced zen's original images with the png images and replaced all references per the patch files. (One comment: why keep calling it "blue_bullet.png" if it's now color-neutral? I call it "bullet.png".) Now I've got nice png images that are color neutral and not-double loading, but there's one problem: there's something wrong with transparency on the list item images next to the links in the user login block: <div class="item-list"><ul><li><a href="/user/register" title="Create a new user account.">Create new account</a></li><li><a href="/user/password" title="Request new password via e-mail.">Request new password</a></li></ul></div> and I can't figure out what's wrong. I tried looking at all the images individually, and nothing seems wrong with the background transparency to me, but maybe fresher eyes can spot it.

suzanne.aldrich’s picture

I think another image with broken transparency is blue_bullet.png

Any chance 5.2 will get the PNG format, color neutral images? Also, may I suggest a cleaner naming scheme:

  • background.png
  • blog.png
  • bullet.png
  • cog.png
  • dialog-information.png
  • dialog-warning.png
  • links.png
  • menu-collapsed.png
  • menu-expanded.png
  • menu-leaf.png
  • page.png
  • tabs.png
  • unpublished.png
  • user.png

Excellent Zen conference call last weekend! I will try to help more with the development process. I am very enthusiastic about this theme/engine and happy there is already a community built around it. Drupal drupal drupal drupal dru-pal!

JohnAlbin’s picture

Status: Needs review » Fixed

Fixed in 5.x-1.x-dev.

Anonymous’s picture

Status: Fixed » Closed (fixed)