I have D7 loaded.
I installed Comment Notify 7.x-1.0-alpha1
When anyone writes an reply to any comment I get the following errors.
PS : I changed my original site name with "mysiite.com"

Notice: Undefined index: name in _comment_notify_mailalert() (line 417 of mysiite.com/public_html/drupal/sites/all/modules/comment_notify/comment_notify.module).
Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 440 of mysiite.com/public_html/drupal/sites/all/modules/comment_notify/comment_notify.module).
Notice: Undefined variable: cid in comment_notify_tokens() (line 43 of mysiite.com/public_html/drupal/sites/all/modules/comment_notify/comment_notify.tokens.inc).
// ----this error repeates itself for each commented member.----
Notice: Undefined variable: cid in comment_notify_tokens() (line 43 of mysiite.com/public_html/drupal/sites/all/modules/comment_notify/comment_notify.tokens.inc).

CommentFileSizeAuthor
#6 1106336_comment_notify_isset_but_empty.patch406 bytesgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ibrahim ali’s picture

ibrahim ali CreditAttribution: ibrahim ali commented

I have the first and the third errors. I hope they would be fixed in a new update release, or at least in a new dev version.

TribalMan’s picture

TribalMan CreditAttribution: TribalMan commented

I have an error on line 43 when posting a comment by the author of the node

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Line 417, 440 and 43 errors » Notices when posting a comment on Line 417, 440 and 43

Those are probably just notices. Worth fixing, but not dealbreakers.

andrebonfanti’s picture

andrebonfanti CreditAttribution: andrebonfanti commented

I have the first error too.
Notice: Undefined index: name in _comment_notify_mailalert() (linea 417 di /home/(mysite)/public_html/sites/all/modules/comment_notify/comment_notify.module).

slater101’s picture

slater101 CreditAttribution: slater101 commented

Yep I have the first one :-(

Going to turn off module until update. everything works perfect though, Subscribed for a fix

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Notices when posting a comment on Line 417, 440 and 43 » Notices when posting a comment on Line 417, 440
Status: Active » Needs review
FileSize
1106336_comment_notify_isset_but_empty.patch406 bytes

The issue on 43 is probably no longer relevant now that #952072: [comment:unsubscribe-url] is not working (and a few other token issues) is fixed.

I think the issue on 417, 440 was based on a thinko about isset vs. empty.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I believe this is a bug meaning the module isn't sending mails when it should and we should commit it soon :)

Reviews would be great, but I'll commit anyway before too long.

Status: Needs review » Needs work

The last submitted patch, 1106336_comment_notify_isset_but_empty.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs work » Needs review

The tests pass locally, so maybe this is some other issue. I plan to disable testing for this since it's not working well.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Fixed

Fixed http://drupalcode.org/project/comment_notify.git/commit/652e3ef

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.