Notice : Undefined index: allowed_values in hs_taxonomy_form_field_ui_field_edit_form_alter()

I have the same error message. After disable the HS module, it is back to normal.

Same problem

subscribe

same problem...

+1

Having the same problem. I did notice that it only appears when you *don't* use a hierarchical-select widget. If you do use the HS widget, the notice doesn't appear.

Writing clear and precise titles improves searchability.

The hook is executed for all fields, also non taxonomy fields. So it looks like there should be a simple check added around the code:

old:

function hs_taxonomy_form_field_ui_field_edit_form_alter(&$form, &$form_state) {
  require_once DRUPAL_ROOT . '/' . drupal_get_path('module', 'hierarchical_select') . '/includes/common.inc';

  $vocabulary = taxonomy_vocabulary_machine_name_load($form['#field']['settings']['allowed_values'][0]['vocabulary']);
  $config = hierarchical_select_common_config_get("taxonomy-$vocabulary->vid");

  if ($config['dropbox']['status'] || $config['save_lineage']) {
    $form['field']['cardinality']['#disabled'] = TRUE;
    $form['field']['cardinality']['#description'] .= ' <strong>' . t('This setting is now managed by the Hierarchical Select configuration.') . '</strong>';
  }
}

new:

function hs_taxonomy_form_field_ui_field_edit_form_alter(&$form, &$form_state) {
  if (isset($form['#field']['settings']['allowed_values'][0]['vocabulary'])) {
    require_once DRUPAL_ROOT . '/' . drupal_get_path('module', 'hierarchical_select') . '/includes/common.inc';

    $vocabulary = taxonomy_vocabulary_machine_name_load($form['#field']['settings']['allowed_values'][0]['vocabulary']);
    $config = hierarchical_select_common_config_get("taxonomy-$vocabulary->vid");

    if ($config['dropbox']['status'] || $config['save_lineage']) {
      $form['field']['cardinality']['#disabled'] = TRUE;
      $form['field']['cardinality']['#description'] .= ' <strong>' . t('This setting is now managed by the Hierarchical Select configuration.') . '</strong>';
    }
  }
}

However, I have some other remarks about the code:
- Wouldn't it be better to replace require_once with module_load_include('inc', 'hierarchical_select', 'includes/common')?
- for clarity it would be better to use curly brackets in the string "taxonomy-$vocabulary->vid" : "taxonomy-${vocabulary->vid}"

So no patch, The change is easy enough, to allow the module maintainer to create it himself and at the same time incorporating (or not) my suggestions.

Same problem. #10 fixed it.

thanks.#10 fix my problem

Git patch attached. To apply: Put patch into hs folder (not the modules subfolder), and enter in terminal: git apply -v [patchname.patch].

#13 worked for me - also, this works fine with the standard patch command patch -p1 < fix_undefined_index-1115498-13.patch.

simple patch, applies cleanly, fixes the problem.

#13 works for me too, this should be added to the module perhaps?

+1 works for me too.

To get this to patch I had to save the patch to the modules subfolder of HS and then apply the patch by issuing the following command:

cd [space] then file path of modules subfolder - just drag and drop from finder into terminal.

in my example:

cd /Applications/MAMP/htdocs/mrfgr/sites/all/modules/hierarchical_select/modules

followed by:

patch < fix_undefined_index-1115498-13.patch

This then works.

@fietserwin: solid suggestions, but:
1) I don't know if there was a particular reason for me to do this: maybe it's a leftover from the D5 days, maybe it's because module_load_include() is not available in AJAX calls — I don't remember. Hence, I will not make this change right away, but I welcome a patch that does this (in a separate issue).
2) Personally, I don't think it's particularly more legible that way — maybe it depends on your editor's syntax highlighting?

@spessex: alternatively, you could just use `git apply

Committed the patch in #13 by geerlingguy: http://drupalcode.org/project/hierarchical_select.git/commit/d6b991a

Hmmm, I'm still getting the 2nd notice:

Notice: Trying to get property of non-object in hs_taxonomy_form_field_ui_field_edit_form_alter() (line 144 of D:\Projecten\Maisonnera\public_html\sites\all\modules\hierarchical_select\modules\hs_taxonomy.module).

It turns out there are fields that have $form['#field']['settings']['allowed_values'][0] set, and that contain a string (fields with type = list_integer). So $form['#field']['settings']['allowed_values'][0]['vocabulary'] will then return the first character of that string, which is set...

I think it will be better to check on the type of the field:

  if (isset($form['#field']['type']) && $form['#field']['type'] === 'taxonomy_term_reference') {
   ...
 }

Good catch. Committed your suggestion: http://drupalcode.org/project/hierarchical_select.git/commit/e14b895. Thanks again!