Error in paypal wps recurring [#1136984]

When install and configure uc_recurring (6.x-2.0-alpha6) for paypal wps the following errors are noticed.

1. Click on submit button on cart checkout form then it go to indefinitely switch form cart/checkout/review to cart/checkout and vice versa.
and the following error message display.

Your order cannot be completed, because we could not process your recurring payment. Please review your payment details and contact us to complete your order if the problem persists.

2. Hidden values of normal paypal wps payment.(ie form uc_paypal module) are not unset in uc_recurring_hosted_form_uc_paypal_wps_form_alter function in uc_recurring_hosted.module file

3. Recurring fee is not populating using uc_recurring_product_get_recurring_products_in_order in uc_recurring_hosted_form_uc_paypal_wps_form_alter function in uc_recurring_hosted.module file.

Can you please give the reply of the above issues

Comment	File	Size	Author
#3	uc_recurring_hosted_1136984.patch	2.22 KB	zyxware
#3	uc_recurring_product_1136984.patch	857 bytes	zyxware
#1	uc_recurring_1136984.patch	2.22 KB	zyxware
#1	uc_recurring_product_1136984.patch	857 bytes	zyxware

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

zyxware CreditAttribution: zyxware commented 24 April 2011 at 13:30

File	Size
uc_recurring_product_1136984.patch	857 bytes
uc_recurring_1136984.patch	2.22 KB

Can any one please check the attached patch files fix the above issue, Because it is working for me.

Comment #2

univate CreditAttribution: univate commented 25 April 2011 at 11:23

Status:

Active

» Postponed (maintainer needs more info)

what version of ubercart are you using, as documented on the project page paypal WPS is broken in 2.3 and 2.4 either downgrade to 2.2 or use ubercart 2.x-dev

Comment #3

zyxware CreditAttribution: zyxware commented 26 April 2011 at 04:09

File	Size
uc_recurring_product_1136984.patch	857 bytes
uc_recurring_hosted_1136984.patch	2.22 KB

Sorry,

Don't use #1 patch files. Please use below patch files.

Comment #4

zyxware CreditAttribution: zyxware commented 26 April 2011 at 04:11

I am using ubercart 6.x-2.4

Comment #5

zyxware CreditAttribution: zyxware commented 26 April 2011 at 07:09

Status:

Postponed (maintainer needs more info)

» Needs review

The attached patches in #3 seems to work for me with Ubercart 2.4. There is still one aspect which is not taken care of - i.e. changing the status of the order before submission to paypal.

Comment #6

univate CreditAttribution: univate commented 2 May 2011 at 01:27

As I pointed out above there is already a known issue with Paypal WPS and ubercart 2.4, this has been resolved in the current development release of ubercart.

So I would like to understand how this effects the current development version of ubercart?

Comment #7

univate CreditAttribution: univate commented 2 May 2011 at 01:31

Status:

Needs review

» Needs work

+++ uc_recurring_product-new.module	2011-04-24 17:06:21.000000000 +0530
@@ -477,7 +477,9 @@
-        continue;
+        if (!$order->paypal_wps_recurring) {
+          continue;
+        }

I can't accept this code can as it includes gateway specific code and I have resolved to keep gateways separate from the core uc_recurring functionality.

Personally I would prefer to put all the gateway stuff with the gateway themselves, as code like this is just messing and just causes problem for users who what to be able to remove/disable gateways.