Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On the style-guide page you have a css rule (line 19 of styleguide.css) that set's a background color to the top navigation block but you don't set a text color as well.
In my case - light text on dark background theme - this looks like a major accessibility issue.
Two possible solutions will be not setting the background color or setting the text color as well.
This screenshot demonstrate my situation :
http://rookery9.aviary.com.s3.amazonaws.com/7842500/7842523_33ad.png
Thanks anyway for this very useful module.
Comment | File | Size | Author |
---|---|---|---|
#7 | accessible_colors-1142982-5-6x.patch | 1.97 KB | agentrickard |
#5 | accessible_colors-1142982-5.patch | 1.99 KB | dcmouyard |
Comments
Comment #1
dcmouyard CreditAttribution: dcmouyard commentedI would recommend removing color from the css altogether.
If you do decide to use color, then you should specify background colors, text colors, and link colors.
Comment #2
agentrickardPatch?
Comment #3
dcmouyard CreditAttribution: dcmouyard commentedI'd be happy to provide a patch once I know what direction to take: remove color declarations or make them accessible?
Comment #4
agentrickardLet's go for accessible. I think we need some base styles for the Style Guide labels and links.
Comment #5
dcmouyard CreditAttribution: dcmouyard commentedUpdated the CSS with more accessible colors and tweaked some theme functions.
Comment #6
agentrickardNice. Tested against Bartik, Austin, and Abstract themes.
Committed to 7.x. Needs backport to 6, but should apply cleanly.
Comment #7
agentrickardAnd committed to 6.x. Nice work!