Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Admin configuration UI for AWS SDK for PHP
Comment | File | Size | Author |
---|---|---|---|
#3 | 1143650-ui.patch | 5.1 KB | boombatower |
#1 | 1143650_01.patch | 1.34 KB | heshanlk |
#2 | 1143650_02.patch | 6.28 KB | heshanlk |
Comments
Comment #1
heshanlkComment #2
heshanlkComment #3
boombatower CreditAttribution: boombatower commentedDid a bit of cleanup:
- removed trailing spaces
- don't think there is a hook_admin() so I used _form() which seems to be standard
- updated form function signature
- moved to just ui/awssdk_ui.* we can always move if we add more modules since git makes that easy
Something we should probably decide since I suppose it would require an update hook to be correct is the variable namespace. It was something I considered originally, but the amazon variables already have 'aws' at the front which seemed sufficient. I removed it from the patch, but I can see it either way.
Something else to consider, do we want any of the fields to be password fields as they are all technically private keys. I think mollom module for example doesn't hide keys.
Lastly, just a cool thought we could make it auto generate settings page since the module already pulls all the defined constants, get the comments shouldn't be much harder. Could switch it over to use PHP's token_get_all() that way it automatically updates with the SDK. Not sure if we want to go that far.
I am happy to commit this patch, we can always add the namespace or automatic later. I should then probably add a UI component for issues.
Comment #4
heshanlkYes. Pointed out things are vital and it seems this patch is ready to go.
Comment #5
boombatower CreditAttribution: boombatower commentedCommitted, thanks.