Hi,

I like this module because it's simple and efficient !
But, I would suggest a modest feature request, even if it may appear a bit out of scope of this module...

The idea would be to add some support for "Audio" players, like Deezer and such...
I've no idea about "legal" issues on this subject, and/or practical feasibility on a wide range of audio player providers, so I just give the idea...

I succeeded to add Deezer support as a first example, by adding the following code in the video_filter.codecs.inc file, at the proper places :

<?php
  $codecs
['deezer'] = array(
   
'name' => t('Deezer'),
   
'sample_url' => 'http://www.deezer.com/listen-SONGID',
   
'callback' => 'video_filter_deezer',
   
'regexp' => '/deezer\.com\/listen-([a-z0-9\-_]+)/i',
   
'ratio' => 220 / 55,
  );
function
video_filter_deezer($video) {
 
$video['source'] = 'http://cdn-files.deezer.com/swf/singlePlayer-v10.swf?idSong='.$video['codec']['matches'][1];
  return
video_filter_flash($video);
}
?>

Thanks for considering my request, even to tell me it's a firm no go ;)

Comments

Status:Active» Postponed (maintainer needs more info)

We've discussed this earlier, and I'm still not sure what the best route is. This being the video filter module, adding support for other media kind of feels wrong, but at the same time I can see the demand.

Perhaps someone is interested in creating a new module? Audio filter, Media filter or something similar.

One interesting way can be to create a Media filter module having the global filter code inside, but not doing anything on itself.... like a kind of API. Then Video filter can be an extension of it, depending on it. This allows to reuse the same codebase to add more specialized filters like Audio, etc.

Does it seems logical to you?

#2 seems like a good approach to me. I've just created an audio filter module but there is so much reuse from video filter. Only issue with a media_filter module would be confusion with the Media project.