Downloading a single file breaks if the folder doesn't exist [#1143936]

Hi,

I am trying to download the i18n-ascii.example.txt into the modules/ folder with a makefile.
But no matter how I do it, I always end up with the file in a subfolder, and not even the pathauto one.

This is my last try:

; Extra features
;---------------

; Pathauto i18n-ascii.txt file
; Dependencies: pathauto 6.x-1.5

libraries[i18n-ascii][download][type] = "file"
libraries[i18n-ascii][download][url] = "http://drupalcode.org/project/pathauto.git/blob_plain/refs/heads/6.x-1.x:/i18n-ascii.example.txt"
libraries[i18n-ascii][destination] = "modules"
libraries[i18n-ascii][download][directory_name] = "pathauto"
libraries[i18n-ascii][download][filename] = "i18n-ascii.txt"

I can see there are several requests concerning the download of single files and archive subtrees. But they do not seem to be commited yet?

Is it possible to do what I'm looking for at this point?

Thanks

Comment	File	Size	Author
#10	singlefile.patch	954 bytes	RobLoach
#2	drushmake-singlefile.patch	2.95 KB	RobLoach

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

adrien.felipe CreditAttribution: adrien.felipe commented 2 November 2011 at 11:26

Version:	6.x-2.2	» 6.x-2.3
Category:	support	» bug

Still no way to download a single file without having it on the array key folder?

Comment #2

RobLoach

he/him

CreditAttribution: RobLoach commented 8 November 2011 at 22:48

Version:	6.x-2.3	» 6.x-2.x-dev
Status:	Active	» Needs review

File	Size
drushmake-singlefile.patch	2.95 KB

Found that the file won't download if the folder didn't exist. Should apply to the 3.x branch too.

Comment #3

RobLoach

he/him

CreditAttribution: RobLoach commented 8 November 2011 at 23:10

Title:

Downloading a single file in modules/ root

» Downloading a single file breaks if the folder doesn't exist

Fixing the title.

Comment #4

adrien.felipe CreditAttribution: adrien.felipe commented 10 November 2011 at 11:17

Hi Rob,

Actually I am not sure about that

the file won't download if the folder didn't exist

For me it's the oposite:
if I try to put it in pathauto folder the drush make fails returning "pathauto folder already exits"
I mean this way libraries[pathauto][download][url] = "...i18n-ascii.example.txt"

But if I try the way as posted in #1, I end up with the file in:
sites/all/modules/pathauto/i18n-ascii/i18n-ascii.txt

And I don't want it to be in a i18n-ascii folder

Comment #5

RobLoach

he/him

CreditAttribution: RobLoach commented 10 November 2011 at 14:10

Maybe try libraries[i18n-ascii][destination]?

Comment #6

adrien.felipe CreditAttribution: adrien.felipe commented 10 November 2011 at 14:26

I have tried both:

libraries[i18n-ascii][destination] = "modules"
libraries[i18n-ascii][download][directory_name] = "pathauto"

and

libraries[i18n-ascii][destination] = "modules/pathauto"

Always get the i18n-ascii folder. And I think last example is what you are saying (folder does not exist)
I don't remember.

Actually I have tried all combinations I could imagine. Can't get this to work.

Comment #7

helmo CreditAttribution: helmo commented 16 December 2011 at 22:02

Project:	Drush Make	» Drush
Version:	6.x-2.x-dev	»
Component:	Code	» Make
Status:	Needs review	» Needs work

[ Powered by #1115636: Issue Macros and Templates - Drush Make]

Drush make is being merged into drush core (discussed in issue:#1310130: Put drush make in drush core)
This means that the issue queue is also moving. The drush queue has a component 'Make' especially for drush_make.

More information will be posted on the drush_make and drush project pages.

Comment #8

helmo CreditAttribution: helmo commented 22 December 2011 at 12:53

Status:

Needs work

» Fixed

The following recipe works both with drush_make 2.3 and the HEAD version in drush core.

libraries[i18n-ascii][download][type] = "get"
libraries[i18n-ascii][download][url] = "http://drupalcode.org/project/pathauto.git/blob_plain/refs/heads/6.x-1.x:/i18n-ascii.example.txt"
libraries[i18n-ascii][download][filename] = "i18n-ascii.txt"
libraries[i18n-ascii][destination] = "modules"
libraries[i18n-ascii][directory_name] = "pathauto"
libraries[i18n-ascii][overwrite] = TRUE