Problem exporting data without a ctools "api" string [#1155310]

When exporting a stylizer style with Features, the style code is created with an "empty" filename, probably attributed to the fact that the "version" and "api" strings are empty.

Steps to repeat:

1) Create a style in the stylizer admin interface.
2) Create a new feature, and select the stylizer style you just created.
3) Download + untar.

What you get:

1) the feature_name.info file produces

features[ctools][] = "stylizer::"

2) the hook_ctools_plugin_api in feature_name.features.inc contains:

  if ($module == "stylizer" && $api == "") {
    return array("version" => );
  }

3) while the contents of the file containing hook_default_stylizer look good, the file is "nameless":

feature_name..inc

Comment	File	Size	Author
#4	stylizer-n1155310.patch	520 bytes	jwilson3
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 12 May 2011 at 13:48

Subcribe.

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 12 May 2011 at 17:19

Technically this is a bug of features because there is no requirement that exportables actually utilize the api features.

But that's only a technicality, because stylizer should be using this, which would 'fix' features. But there are some exportables that specifically do not want 'api' features and features will still choke on them, so features possibly needs a bug report as well.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 12 May 2011 at 19:18

Title:	Stylizer export lacks "api" and "version"	» Problem exporting data without a ctools "api" string
Project:	Chaos Tool Suite (ctools)	» Features
Version:	7.x-1.0-alpha4	» 7.x-1.x-dev
Component:	Exportables	» Code

Making it so.

Comment #4

jwilson3

English

Ecuador

CreditAttribution: jwilson3 commented 12 May 2011 at 20:48

File	Size
stylizer-n1155310.patch	520 bytes

So there should probably be something in features that doesn't allow export unless $schema[$element]['export']['api'] exists.

I'd like to still provide a patch that fixes the original issue identified in the stylizer module, that would provide real integration with not just ctools export but also features. It makes sense that anything exportable should be linked to an API version, various instructions I've found all include these additional lines, and many other modules submit to this methodology.

Comment #5

Torenware CreditAttribution: Torenware commented 28 June 2011 at 00:09

This one falls in between the cracks of CTools and Features, and I don't think that it will get resolved quickly w/o some amount of coordination between the teams. Somebody in this group really ought to contact Earl Miles and hammer out how best to resolve this, since either the Features group isn't using his API right, or it isn't clear via the CTools documentation how a plug-in client should behave in this case. Letting the issue ping-pong between the two issues queues isn't helpful.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 15 July 2011 at 20:29

merlinofchaos fixed the Stylizer problem: #1199590: Stylizer fails to do export via Features

Comment #7

jwilson3

English

Ecuador

CreditAttribution: jwilson3 commented 15 July 2011 at 20:39

Project:	Features	» Chaos Tool Suite (ctools)
Status:	Active	» Fixed

From merlinofchaos in comment #8 on #1199590: Stylizer fails to do export via Features:

I've gone ahead and added an "api" section for stylizer

I believe this issue can be closed now, since my patch in #4 also does just that.

Comment #8

jwilson3

English

Ecuador

CreditAttribution: jwilson3 commented 15 July 2011 at 22:25

Project:	Chaos Tool Suite (ctools)	» Features
Status:	Fixed	» Active

Actually, I suppose based on Earl's comments in #2, this should perhaps be left open in the Features module issue queue, to see what they have to say. Though, now that stylizer has added the "api" section, I wonder if this is still relevant.