The Media help file (admin/help/media) states
"Enable WYSIWYG plugin on your desired WYSIWYG profile. Please note that you will need to have WYSIWYG module enabled."

Shouldn't this be "Enable Media Browser plugin..."?

Also, it would be helpful to clarify
"Add Media Filter to the WYSIWYG enabled Input format"

with something like
"(displayed as "Converts Media tags to Markup")

Files: 
CommentFileSizeAuthor
#10 media-media_markup_filter_documenation-1157670-10.patch2.73 KBcachee
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]
#9 media-media_markup_filter_documenation-1157670-9.patch2.72 KBcachee
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]
#6 media_markup_filter_documenation-1157670-3.patch1.65 KBcachee
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-3_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#5 media_markup_filter_documenation-1157670-5.patch1.51 KBcachee
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 media_markup_filter_documenation-1157670-3.patch1.64 KBcachee
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 media_markup_filter_documenation-1157670-1.patch1.4 KBmpgeek
FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 0 fail(s), and 12 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.4 KB
FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 0 fail(s), and 12 exception(s).
[ View ]

@carole, towards your first point, the media browsing is separate from setting up the input format for media markup, so i think the language is fine. Towards the second point, i would agree the documentation language is a bit confusing. Patch attached.

Status:Needs review» Needs work

The last submitted patch, media_markup_filter_documenation-1157670-1.patch, failed testing.

Version:7.x-1.x-dev» 7.x-1.2
Status:Needs work» Needs review
StatusFileSize
new1.64 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Recreated patch for 7.x.1.2

Version:7.x-1.2» 7.x-2.x-dev
Status:Needs review» Needs work

Thanks for the updated patch!

Can you make a patch against Media 2.x (the issue should be solved in 2.x and backported to 1.x)?

Also, I would suggest replacing <em>Convert Media tags to markup</em> with a %variable placeholder. See format_string for more information.

Status:Needs work» Needs review
StatusFileSize
new1.51 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Created the patch for 7.x.2.x-dev and inlcuded the suggested change using the %variable function.

StatusFileSize
new1.65 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch media_markup_filter_documenation-1157670-3_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

The patch was recreated for 7.x-1.2 to include the suggested changes from comment #4

Version:7.x-2.x-dev» 7.x-1.x-dev

thanks commited to 2.x
http://drupalcode.org/project/media.git/commit/74d8686
moving back for 1.x

Status:Needs review» Needs work

Either patch looks good (they should both work since the same change must be made to Media 1.x as 2.x) but they won't apply.

diff --git a/sites/all/modules/media/media.module b/sites/all/modules/media/media.module
index eaec736..8fe1124 100644
--- a/sites/all/modules/media/media.module
+++ b/sites/all/modules/media/media.module

It looks like the patches were made from the root of a webserver. @cachee can you reroll either patch from inside of the Media repository?

Status:Needs work» Needs review
StatusFileSize
new2.72 KB
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]

Regenerated the patch for 7.x-1.x-dev using instructions I found at http://drupal.org/node/707484. I also updated an additional line found with the suggested change from comment #4 - This patch has an cut/paste error please to not use.

StatusFileSize
new2.73 KB
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]

The patch from comment #9 has been corrected. Sorry for the earlier error.

Status:Needs review» Fixed

Actually <em>Convert Media tags to markup</em> is not a variable..so it does not need a placeholder

1.x commit
http://drupalcode.org/project/media.git/commit/194673c
2.x commit
http://drupalcode.org/project/media.git/commit/f4bbf77

Thanks cachee

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.