Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
1. Terms are ordered alphabetically instead of term weight.
2. Though there is a dash, "-", in front of child terms, hierarchy is broken since alpha ordering overrides hierarchy.
Comment | File | Size | Author |
---|---|---|---|
#2 | profile_taxonomy_unnecessary_encoding-1161454.patch | 1.12 KB | AaronBauman |
Comments
Comment #1
AaronBaumanSorry, I was mis-reading this bug.
It seems that the weights and hierarchy are respected, but the dash, "-", is added inconsistently, making it appear as if the terms are mis-ordered.
Comment #2
AaronBaumanThis issue is limited to term values whose names contain html special chars.
The specific cause of this issue is this line of profile_taxonomy_field_widget(), around line number 278:
1. The encoding callback is invoked on every iteration of a loop, which means that values are encoded once for every option. This means we end up with values like
&...
2. It's not even necessary to call it once, since none of the term values for which we're searching are encoded in the first place.
3. Since this is the only place where _profile_taxonomy_check_html_special_chars() is called, the function itself is now superfluous.
Attached patch addresses these concerns.
Comment #3
AaronBaumanComment #5
gnindl CreditAttribution: gnindl commentedThanks aaronbauman, as this is a quite obvious patch which shouldn't have any side effect, it has been committed to repository:
http://drupalcode.org/project/profile_taxonomy.git/blobdiff/1e9596e285d8...