Remove non-specific CSS selectors [#1163126]

I'm sure there was a reason for this at some point, but it's annoying that uc_product.css contains declarations for h3.title (line 40). That's a standard selector that is output on a lot of theme's sidebar blocks (e.g. Basic) and I have to manually override it on every site that uses Ubercart.

I'm assuming that it has to do with Ubercart's default product list, but it's a bit obnoxious for a contrib module to hijack such a common selector.

I can provide a patch if there is no real need for it.

Comment	File	Size	Author
#4	removeSelectors-1163126-4.patch	299 bytes	balsama
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

longwave

he/him

English

CreditAttribution: longwave commented 23 May 2011 at 22:20

I can't even see anywhere that Ubercart outputs <h3 class="title"> - the only use of h3 seems to be for attribute titles, and they don't have a class specified - so it does look like this can be removed entirely. Are there any other selectors that should be removed at the same time?

Comment #2

balsama

he/him

English

boston

CreditAttribution: balsama commented 25 May 2011 at 17:57

Possibly this one:
.node-form tbody {
border: none;
margin: 0;
}

Is it there to fix a problem when editing/creating products perhaps?

Comment #3

longwave

he/him

English

CreditAttribution: longwave commented 25 May 2011 at 19:31

That one fixes an annoying rule in /modules/system/system.css:

tbody {
  border-top: 1px solid #CCCCCC;
}

The price fields on the node edit form are displayed using a table, and the top border is unnecessary - bad semantics, but it looks like we can change .node-form tbody to .node-form .product-field tbody at least.