This module provides Domain Access mappers for the Feeds module. Once you've created domains in domain access module settings you will be able to map to them in the feeds module mapping settings. In your .csv file, please use "1" to attach nodes to domains.

http://drupal.org/sandbox/Jim/1163310

Comments

jim.m’s picture

bump

jim.m’s picture

bump

lslinnet’s picture

Hey,

Have taken a look at the code part of this module, haven't tested the functionality as of yet.

  • looks like it could use som dependencies in the info file,
  • remove the $id$ part - it's deprecated
  • ($data['domain_id'] == 0) ? $key = -1 : $key = $data['domain_id'];
    

    could (and should as it's more clear whats going on) be rewritten to

    $key = ($data['domain_id'] == 0) ? -1 : $data['domain_id'];
    
  • "else if" on line 46 should be moved to a new line
  • Missing newline at end of file.

except for the above mentions the code looks fine

lslinnet’s picture

Status: Needs review » Needs work

forgot to change status

jim.m’s picture

Status: Needs work » Needs review

Fixed.

lslinnet’s picture

Status: Needs review » Reviewed & tested by the community

Just because i'm picky of nature there is still a little code-formatting issue, but nothing that should prevent you from having this module upgraded to full project status.

For future work remember to run your code through the coder module, it helps correct a lot of the minor issues like whitespace at the end of a line.

mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Congratulations, Jim.M!  You can now promote sandbox projects to full status ones.  When you would like further review for any project please do ask at http://groups.drupal.org/peer-review/requests

Further cleanup issues can be filed on your project issue queue.  Thank you for your contribution and i look forward to seeing its refinement and development and your continued involvement in Drupal!

benjamin, agaric

jim.m’s picture

Thanks, mlncn. When should I see the "promote" tab?

Thanks,

mlncn’s picture

Jim.M - both when you edit the project near the project shortname and as a link on the project page.

jim.m’s picture

Are you sure you gave my account the correct permissions? :)

mlncn’s picture

Apparently not... wonder if i accidentally vetted some random passerby... ;-) Should be all set now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Title: Domain Feeds » [D7] Domain Feeds
Issue summary: View changes