Add a warning on module_enable() if the module [#1172754]

#885478: Improve Memcache as installation profile friendly allowed memcache_admin to be installed without memcache being set up in settings.php

The new memcache.module also allows this.

Both show warnings on the status report on runtime, but I'm a bit concerned that people new to memcache who don't understand how the backends work are going to end up enabling the module then forgetting about it, thinking that will automatically switch to using memcache.

So it might be worth adding a drupal_set_message() on module install (and maybe a hook_help() too) so that there's an additional nudge to set it up properly.

Comment	File	Size	Author
#2	memcache-hook_requirements-1172754-2.patch	2 KB	markpavlitski

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

erikwebb CreditAttribution: erikwebb commented 22 February 2013 at 19:23

Version:

6.x-1.x-dev

» 7.x-1.x-dev

Comment #2

markpavlitski CreditAttribution: markpavlitski commented 6 June 2013 at 13:13

Status:

Active

» Needs review

File	Size
memcache-hook_requirements-1172754-2.patch	2 KB

The current hook_requirements will pass if dmemcache_set() exists, i.e. $conf['cache_backends'][] = 'sites/all/modules/memcache/memcache.inc'; has been put in settings.php, however this doesn't guarantee that memcache is configured and working.

This patch adds some additional checks to confirm that memcache is configured correctly.

Comment #3

Jeremy CreditAttribution: Jeremy commented 17 February 2014 at 22:06

Issue summary:	View changes
Status:	Needs review	» Fixed

I ended up reworking this a lot, but hopefully people will find the module a little easier to install with more helpful and consistent errors. As @catch suggested, we now throw a warning if the module is enabled but Memcache isn't working for any of a variety of reasons.

Committed here:
http://drupalcode.org/project/memcache.git/commitdiff/d9e5e35