hi,

at the moment there is an extra a tag that is positioned over the bullet icon of the list. that approach can have theming issues.

in my opinion it would be better just to use the extra a tag for the icon (background-image), disable the bullet icon.

In the 7.x version there is also inline code that moves the a tag, so you could not even override that because inline priority > *:

element.style {
left: -16px;
margin-left: 21px;
}

as i remember the 6.3x version did not do that.

CommentFileSizeAuthor
#4 expand_on_bullet-1176834-2.patch1.39 KBckng
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcoka’s picture

marcoka CreditAttribution: marcoka commented

so somehow the above code is the one that creates the inline code (with hardcoded sizes, i uncommented the lines)
(info: there is already a patch applied, the if statment checking hasClass('dhtml-menu'); , without that it kills a lot of stuff in views and others)

 // When using LTR, all icons can be shifted as one, as the text width is not relevant.
    if (settings.nav == 'bullet' && !rtl) {
      // Shift overlay to the left by the width of the icon and the distance between icon and text.
        if ($('.menu li').hasClass('dhtml-menu')) {
//        var shift = '-' + (Math.ceil(($('.menu li').css('margin-left').replace('px', ''))) + 16) + 'px';
//        // Shift the overlay using a negative left-hand offset, and the text using a negative right-hand margin.
//        $('.dhtml-menu-icon').css('left', shift).css('margin-right', shift);
      }

    }
  }
}
ckng’s picture

ckng
Primary language English
CreditAttribution: ckng commented
Title: Bullet open/close on klick logic » "Expand on Bullet" not working
Component: CSS code » PHP Code
Category: feature » bug

Attached patch to correct the margin calculation and a better way to theme the .dhtml-folder
Somehow fixes #1380498: Admin options are disabled when "expand on bullet" is selected for me also, didn't investigate further.

ckng’s picture

ckng
Primary language English
CreditAttribution: ckng commented
Status: Active » Needs review
ckng’s picture

ckng
Primary language English
CreditAttribution: ckng commented
FileSize
expand_on_bullet-1176834-2.patch1.39 KB

Somehow the patch in #2 is missing from d.o

twooten’s picture

twooten CreditAttribution: twooten commented

The patch in #4 fixed my issues.

Thanks!

Rory’s picture

Rory CreditAttribution: Rory commented

The patch in #4 also fixed my issues. I had to apply the !important rule to get a CSS style to apply properly from the dhtml_menu.css file though, as menu items began showing bullets afterwards.
So specifically from the patch:

li.dhtml-folder {
  list-style: none;
}

became:

li.dhtml-folder {
  list-style: none !important;
}
marcoka’s picture

marcoka CreditAttribution: marcoka commented

after nothing happening,i wrote http://drupal.org/project/dynatree
using an external script having the same name as the module, pretty solid.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
CreditAttribution: mvc commented
Status: Needs review » Reviewed & tested by the community

patch #4 fixed this and #1380498: Admin options are disabled when "expand on bullet" is selected for me using 7.x-1.0-beta1. thanks!

  • ilchovuchkov committed c1793b7 on 7.x-1.x 
    Issue #1176834 by ilchovuchkov, ckng: 'Expand on Bullet' not working.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed to the latest 7.x-1.x-dev branch.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented

Give some credits about the issue. Thanks to everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented