Don't force drupal_get_schema() on ctools_custom_content [#1179204]

Comment	File	Size	Author
#10	1179204-ctools-custom-content-10.patch	2.14 KB	amitaibu
#1	dont-reset-schema-on-custom-content-1.patch	788 bytes	amitaibu
	dont-reset-schema-on-custom-content.patch	776 bytes	amitaibu

Comment #1

Hebrew

Israel

CreditAttribution: amitaibu commented 5 June 2011 at 13:43

File	Size
dont-reset-schema-on-custom-content-1.patch	788 bytes

Fix typo.

Log in or register to post comments

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 5 June 2011 at 16:06

Can you explain this to me? Is there something I'm missing about this case being special?

Log in or register to post comments

Comment #3

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 9 June 2011 at 06:08

> Is there something I'm missing about this case being special?

*I* might be the one missing ;)

What I've seen is this:
1) I've created a Panels page with some content panes, and ctools_custom_content.
2) Without this patch drupal_get_schema() is reset, resulting with cache::set() updating the cache, that was actually not changed, because ctools_custom_content doesn't have tables.

Log in or register to post comments

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 9 June 2011 at 06:29

Yes, ctools_custom_content has tables:


function ctools_custom_content_schema_1() {
  $schema = array();

  $schema['ctools_custom_content'] = array(
    'description' => 'Contains exportable customized content for this site.',
    'export' => array(
      'identifier' => 'content',
      'bulk export' => TRUE,
      'primary key' => 'cid',
      'api' => array(
        'owner' => 'ctools',
        'api' => 'ctools_content',
        'minimum_version' => 1,
        'current_version' => 1,
      ),
      'create callback' => 'ctools_content_type_new',
    ),
    'fields' => array(
      'cid' => array(

Log in or register to post comments

Comment #5

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 9 June 2011 at 06:38

> Yes, ctools_custom_content has tables:

But only when you enable the ctools_custom_content module.

Log in or register to post comments

Comment #6

merlinofchaos CreditAttribution: merlinofchaos commented 9 June 2011 at 06:42

It shouldn't be looking for the schema if that module is not enabled. That would be a bug. :)

Log in or register to post comments

Comment #7

merlinofchaos CreditAttribution: merlinofchaos commented 9 June 2011 at 06:44

Status:

Needs review

» Needs work

ahh. The custom content type isn't testing if the module is enabled before trying to load its tables. Thats where this should be fixed, not special casing in export.inc